[GitHub] qpid pull request #10: feat(disposition): respect messageAnnotation mods in ...

2016-06-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] qpid pull request #10: feat(disposition): respect messageAnnotation mods in ...

2016-06-28 Thread mbroadst
Github user mbroadst commented on a diff in the pull request: https://github.com/apache/qpid/pull/10#discussion_r68772313 --- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp --- @@ -108,6 +109,19 @@ void OutgoingFromQueue::write(const char* data, size_t size)

[GitHub] qpid pull request #10: feat(disposition): respect messageAnnotation mods in ...

2016-06-28 Thread grs
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid/pull/10#discussion_r68769620 --- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp --- @@ -108,6 +109,19 @@ void OutgoingFromQueue::write(const char* data, size_t size)

[GitHub] qpid pull request #10: feat(disposition): respect messageAnnotation mods in ...

2016-06-28 Thread mbroadst
GitHub user mbroadst opened a pull request: https://github.com/apache/qpid/pull/10 feat(disposition): respect messageAnnotation mods in modified state The modified outcome supports an optional messageAnnotations parameter, allowing the user to modify these annotations for

[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...

2016-06-27 Thread mbroadst
Github user mbroadst closed the pull request at: https://github.com/apache/qpid/pull/9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] qpid pull request #:

2016-06-24 Thread grs
Github user grs commented on the pull request: https://github.com/apache/qpid/commit/7b8a91375dc0528e2c15686ab71c3647ac3e2f96#commitcomment-18005323 In qpid/cpp/src/qpid/broker/Queue.h: In qpid/cpp/src/qpid/broker/Queue.h on line 538: should be fixed now --- If your project

[GitHub] qpid pull request #:

2016-06-24 Thread mbroadst
Github user mbroadst commented on the pull request: https://github.com/apache/qpid/commit/7b8a91375dc0528e2c15686ab71c3647ac3e2f96#commitcomment-18004761 In qpid/cpp/src/qpid/broker/Queue.h: In qpid/cpp/src/qpid/broker/Queue.h on line 538: sorry I know it's not your commit,

[GitHub] qpid pull request #:

2016-06-24 Thread mbroadst
Github user mbroadst commented on the pull request: https://github.com/apache/qpid/commit/7b8a91375dc0528e2c15686ab71c3647ac3e2f96#commitcomment-18004752 In qpid/cpp/src/qpid/broker/Queue.h: In qpid/cpp/src/qpid/broker/Queue.h on line 538: @grs this line prevents builds as it

[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...

2016-06-24 Thread grs
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid/pull/9#discussion_r68367813 --- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp --- @@ -79,6 +79,9 @@ OutgoingFromQueue::OutgoingFromQueue(Broker& broker, const std::string& source,

[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...

2016-06-23 Thread mbroadst
Github user mbroadst commented on a diff in the pull request: https://github.com/apache/qpid/pull/9#discussion_r68328482 --- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp --- @@ -79,6 +79,9 @@ OutgoingFromQueue::OutgoingFromQueue(Broker& broker, const std::string& source,

[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...

2016-06-23 Thread mbroadst
Github user mbroadst commented on a diff in the pull request: https://github.com/apache/qpid/pull/9#discussion_r68322985 --- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp --- @@ -79,6 +79,9 @@ OutgoingFromQueue::OutgoingFromQueue(Broker& broker, const std::string& source,

[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...

2016-06-23 Thread grs
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid/pull/9#discussion_r68322398 --- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp --- @@ -79,6 +79,9 @@ OutgoingFromQueue::OutgoingFromQueue(Broker& broker, const std::string& source,

[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...

2016-06-23 Thread grs
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid/pull/9#discussion_r68322267 --- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp --- @@ -142,11 +145,10 @@ void OutgoingFromQueue::handle(pn_delivery_t* delivery) if

[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...

2016-06-23 Thread mbroadst
Github user mbroadst commented on a diff in the pull request: https://github.com/apache/qpid/pull/9#discussion_r68313162 --- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp --- @@ -142,11 +145,10 @@ void OutgoingFromQueue::handle(pn_delivery_t* delivery) if

[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...

2016-06-23 Thread mbroadst
Github user mbroadst commented on a diff in the pull request: https://github.com/apache/qpid/pull/9#discussion_r68312642 --- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp --- @@ -79,6 +79,9 @@ OutgoingFromQueue::OutgoingFromQueue(Broker& broker, const std::string& source,

[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...

2016-06-23 Thread grs
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid/pull/9#discussion_r68299958 --- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp --- @@ -142,11 +145,10 @@ void OutgoingFromQueue::handle(pn_delivery_t* delivery) if

[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...

2016-06-23 Thread grs
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid/pull/9#discussion_r68299289 --- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp --- @@ -79,6 +79,9 @@ OutgoingFromQueue::OutgoingFromQueue(Broker& broker, const std::string& source,

[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...

2016-06-23 Thread mbroadst
GitHub user mbroadst opened a pull request: https://github.com/apache/qpid/pull/9 feat(disposition): support undeliverable-here in modified outcomes Previously, specifying `undeliverable-here` as `true` in a modified outcome simply resulted in the message being rejected. This

[GitHub] qpid pull request: Get qpid C++ building on OSX.

2016-01-11 Thread sideshowcoder
Github user sideshowcoder commented on the pull request: https://github.com/apache/qpid/pull/7#issuecomment-170585150 I just found this and also http://web.archive.org/web/20100501115556/http://le-depotoir.googlecode.com/svn/trunk/misc/clock_gettime_stub.c which tries to provided a

[GitHub] qpid pull request: Get qpid C++ building on OSX.

2016-01-11 Thread astitcher
Github user astitcher commented on the pull request: https://github.com/apache/qpid/pull/7#issuecomment-170631466 As a way to implement clock_gettime() this seems like a good approach. However the bigger problem is the timekeeping between clock_gettime() and condition vars

[GitHub] qpid pull request: NO-JIRA: Fixed .NET Native-Managed string conve...

2015-08-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid/pull/8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled

[GitHub] qpid pull request: QPID-6470: FieldValue::getFloatingPointValue() ...

2015-07-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid/pull/6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled

[GitHub] qpid pull request: NO-JIRA: Fixed .NET Native-Managed string conve...

2015-07-19 Thread gaborsulyok
GitHub user gaborsulyok opened a pull request: https://github.com/apache/qpid/pull/8 NO-JIRA: Fixed .NET Native-Managed string convervsion The string conversion was not correct when you wanted to convert from native UTF-8 string to a managed one. A conversion method has ben

[GitHub] qpid pull request: Get qpid C++ building on OSX.

2015-05-14 Thread astitcher
Github user astitcher commented on the pull request: https://github.com/apache/qpid/pull/7#issuecomment-101935319 This implementation doesn't follow the usual qpid portability strategy for *not* introducing inline conditional compilation. The way we do do this in qpid is to

[GitHub] qpid pull request: QPID-6470: FieldValue::getFloatingPointValue() ...

2015-05-07 Thread gemmellr
Github user gemmellr commented on the pull request: https://github.com/apache/qpid/pull/6#issuecomment-99921669 The mentioned JIRA has been marked resolved, but the commits didnt include the needed message to automatically close this PR. Can you check if the changes resolve your

[GitHub] qpid pull request: QPID-6213: fix queue cleaner connection timeout...

2015-05-07 Thread ChugR
Github user ChugR closed the pull request at: https://github.com/apache/qpid/pull/4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled

[GitHub] qpid pull request: Get qpid C++ building on OSX.

2015-04-07 Thread tibbetts
GitHub user tibbetts opened a pull request: https://github.com/apache/qpid/pull/7 Get qpid C++ building on OSX. QPID-2536: Implement posix clock_gettime QPID-4280: clock_gettime not available on Mac OS X QPID-4278: Broken OS X Build Add documentation to INSTALL and

[GitHub] qpid pull request: QPID-6421: fix typo in README, testing GitHub i...

2015-02-27 Thread gemmellr
GitHub user gemmellr opened a pull request: https://github.com/apache/qpid/pull/5 QPID-6421: fix typo in README, testing GitHub integration As per subject You can merge this pull request into a Git repository by running: $ git pull https://github.com/gemmellr/qpid trunk

[GitHub] qpid pull request: QPID-6421: fix typo in README, testing GitHub i...

2015-02-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid/pull/5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled

[GitHub] qpid pull request: QPID-6421: fix typo in README, testing GitHub i...

2015-02-27 Thread gemmellr
Github user gemmellr commented on the pull request: https://github.com/apache/qpid/pull/5#issuecomment-76446872 Test comment via GitHub --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Re: [GitHub] qpid pull request: QPID-6421: fix typo in README, testing GitHub i...

2015-02-27 Thread Robbie Gemmell
Test reply via email On 27 February 2015 at 18:34, gemmellr g...@git.apache.org wrote: Github user gemmellr commented on the pull request: https://github.com/apache/qpid/pull/5#issuecomment-76446872 Test comment via GitHub --- If your project is set up for it, you can reply to