Re: Review Request 63870: RANGER-1861:There are errors when the "ranger-kms start" command was executed.

2017-11-17 Thread pengjianhua
> On εδΈ€ζœˆ 16, 2017, 11:47 a.m., Colm O hEigeartaigh wrote: > > How does your change prevent the error? From what I can see the change is > > that it doesn't load the DEFAULT_CONFIG_FILENAME if an argument is > > specified. The EmbeddedServer class is only called by the security admin and KMS.

Re: Review Request 63929: Policy model update to support restricted access-types based on selected resource - bug fix for skipped initialization of isValidLeaf flag

2017-11-17 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63929/#review191415 --- Ship it! Ship It! - Madhan Neethiraj On Nov. 17, 2017,

Review Request 63929: Policy model update to support restricted access-types based on selected resource - bug fix for skipped initialization of isValidLeaf flag

2017-11-17 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63929/ --- Review request for ranger and Madhan Neethiraj. Bugs: RANGER-1781

Re: Review Request 63552: RANGER-1837:Enhance Ranger Audit to HDFS to support ORC file format

2017-11-17 Thread Ramesh Mani
> On Nov. 4, 2017, 9:50 p.m., Don Bosco Durai wrote: > > agents-audit/README.txt > > Lines 40 (patched) > > > > > > We need to check with the ORC team to see what would be the ideal (raw) > > file size. pinged ORC

[jira] [Comment Edited] (RANGER-1837) Enhance Ranger Audit to HDFS to support ORC file format

2017-11-17 Thread Ramesh Mani (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257622#comment-16257622 ] Ramesh Mani edited comment on RANGER-1837 at 11/17/17 11:06 PM:

[jira] [Commented] (RANGER-1837) Enhance Ranger Audit to HDFS to support ORC file format

2017-11-17 Thread Ramesh Mani (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257719#comment-16257719 ] Ramesh Mani commented on RANGER-1837: - [~bosco] regarding the best practice I see this article

[jira] [Assigned] (RANGER-1837) Enhance Ranger Audit to HDFS to support ORC file format

2017-11-17 Thread Ramesh Mani (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ramesh Mani reassigned RANGER-1837: --- Assignee: Ramesh Mani > Enhance Ranger Audit to HDFS to support ORC file format >

[jira] [Updated] (RANGER-1837) Enhance Ranger Audit to HDFS to support ORC file format

2017-11-17 Thread Ramesh Mani (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ramesh Mani updated RANGER-1837: Attachment: 0001-RANGER-1837-Enhance-Ranger-Audit-to-HDFS-to-support_001.patch > Enhance Ranger

Re: Review Request 63552: RANGER-1837:Enhance Ranger Audit to HDFS to support ORC file format

2017-11-17 Thread Ramesh Mani
> On Nov. 4, 2017, 9:50 p.m., Don Bosco Durai wrote: > > agents-audit/README.txt > > Lines 28 (patched) > > > > > > I assume, which this option, memory buffer won't be used. Bosco, memory buffer is not removed,

Re: Review Request 63552: RANGER-1837:Enhance Ranger Audit to HDFS to support ORC file format

2017-11-17 Thread Ramesh Mani
> On Nov. 11, 2017, 6:15 p.m., Kevin Risden wrote: > > agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditFileCacheProvider.java > > Line 62 (original), 62 (patched) > > > > > > Is this a bug regardless

Re: Review Request 63552: RANGER-1837:Enhance Ranger Audit to HDFS to support ORC file format

2017-11-17 Thread Ramesh Mani
> On Nov. 4, 2017, 2:21 a.m., Abhay Kulkarni wrote: > > agents-audit/README.txt > > Lines 44 (patched) > > > > > > Please clarify if this query needs to be run as a part of Audit > > framework set-up. No, this is

Re: Review Request 63552: RANGER-1837:Enhance Ranger Audit to HDFS to support ORC file format

2017-11-17 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63552/ --- (Updated Nov. 17, 2017, 7:38 p.m.) Review request for ranger, Don Bosco Durai

Re: Review Request 63789: RANGER-1887:serviceDef.getResources().get(0).getName(); case IndexOutOfBoundsException in RangerServiceTag.class And print error in RangerServiceStorm

2017-11-17 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63789/#review191374 --- Ship it! Ship It! - Alejandro Fernandez On Nov. 17, 2017,

Re: Review Request 63867: RANGER-1848:Implement getLinkList/getJobList in SqoopClient for Ranger Sqoop2 plugin

2017-11-17 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63867/#review191359 --- I think the Commons Collections 4 dependency should be avoided as

Re: Review Request 63919: RANGER-1895 - Simplify Storm dependencies

2017-11-17 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63919/#review191356 --- Ship it! Makes sense, less dependency is always better. -

[jira] [Commented] (RANGER-1896) Remove deprecated extractedCommonCriterias call from the SearchUtil

2017-11-17 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257207#comment-16257207 ] Zsombor Gegesy commented on RANGER-1896: https://reviews.apache.org/r/63921/ > Remove

Review Request 63921: RANGER-1896 : Remove deprecated extractedCommonCriterias call from the SearchUtil and fix the UserREST controller

2017-11-17 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63921/ --- Review request for ranger. Bugs: RANGER-1896

[jira] [Updated] (RANGER-1896) Remove deprecated extractedCommonCriterias call from the SearchUtil

2017-11-17 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1896: --- Attachment: RANGER-1896.patch > Remove deprecated extractedCommonCriterias call from the

[jira] [Created] (RANGER-1896) Remove deprecated extractedCommonCriterias call from the SearchUtil

2017-11-17 Thread Zsombor Gegesy (JIRA)
Zsombor Gegesy created RANGER-1896: -- Summary: Remove deprecated extractedCommonCriterias call from the SearchUtil Key: RANGER-1896 URL: https://issues.apache.org/jira/browse/RANGER-1896 Project:

Review Request 63919: RANGER-1895 - Simplify Storm dependencies

2017-11-17 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63919/ --- Review request for ranger. Bugs: RANGER-1895

[jira] [Updated] (RANGER-1895) Simplify Storm dependencies

2017-11-17 Thread Colm O hEigeartaigh (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colm O hEigeartaigh updated RANGER-1895: Attachment: 0001-RANGER-1895-Simplify-Storm-dependencies.patch > Simplify Storm

[jira] [Created] (RANGER-1895) Simplify Storm dependencies

2017-11-17 Thread Colm O hEigeartaigh (JIRA)
Colm O hEigeartaigh created RANGER-1895: --- Summary: Simplify Storm dependencies Key: RANGER-1895 URL: https://issues.apache.org/jira/browse/RANGER-1895 Project: Ranger Issue Type:

[jira] [Commented] (RANGER-1894) Fix HDFS tests to work with Hadoop 3.0.0

2017-11-17 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256963#comment-16256963 ] Zsombor Gegesy commented on RANGER-1894: This is a duplicate issue of RANGER-1707 - but that

[jira] [Updated] (RANGER-1894) Fix HDFS tests to work with Hadoop 3.0.0

2017-11-17 Thread Colm O hEigeartaigh (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colm O hEigeartaigh updated RANGER-1894: Attachment: 0001-RANGER-1894-Fix-HDFS-tests-to-work-with-Hadoop-3.0.0.patch > Fix

Review Request 63908: RANGER-1894 - Fix HDFS tests to work with Hadoop 3.0.0

2017-11-17 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63908/ --- Review request for ranger. Bugs: RANGER-1894

[jira] [Created] (RANGER-1894) Fix HDFS tests to work with Hadoop 3.0.0

2017-11-17 Thread Colm O hEigeartaigh (JIRA)
Colm O hEigeartaigh created RANGER-1894: --- Summary: Fix HDFS tests to work with Hadoop 3.0.0 Key: RANGER-1894 URL: https://issues.apache.org/jira/browse/RANGER-1894 Project: Ranger

[jira] [Commented] (RANGER-1892) Latest Hive Plugin Error

2017-11-17 Thread Amithsha (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256763#comment-16256763 ] Amithsha commented on RANGER-1892: -- i got the last two error. 1. Due to miss configuration 2. Due to

Re: Review Request 63789: RANGER-1887:serviceDef.getResources().get(0).getName(); case IndexOutOfBoundsException in RangerServiceTag.class And print error in RangerServiceStorm

2017-11-17 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63789/#review191312 --- The "String tagResourceName = null" definition could be moved