Re: Review Request 63981: RANGER-1903:Simplify the maven dependency management of the Hdfs plugin for Ranger.

2017-11-22 Thread pengjianhua
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63981/ --- (Updated 十一月 23, 2017, 3:19 a.m.) Review request for ranger, Alok Lal, Ankita S

Re: Review Request 63981: RANGER-1903:Simplify the maven dependency management of the Hdfs plugin for Ranger.

2017-11-22 Thread pengjianhua
> On 十一月 22, 2017, 中午, Colm O hEigeartaigh wrote: > > You could also remove the solr dependency - it is picked up anyway from the > > plugins-audit dependency, and shouldn't be listed explicitly in the hdfs > > pom, as there are no solr references in that module. Ok,I have tested solr really n

Re: Review Request 64042: RANGER-1897: tagsync update to replace Atlas V1 API usage with Atlas V2 API for tag-download using REST

2017-11-22 Thread Abhay Kulkarni
> On Nov. 23, 2017, 1:41 a.m., Abhay Kulkarni wrote: > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java > > Line 298 (original), 466 (patched) > > > > > > It appears that th

Re: Review Request 64042: RANGER-1897: tagsync update to replace Atlas V1 API usage with Atlas V2 API for tag-download using REST

2017-11-22 Thread Madhan Neethiraj
> On Nov. 23, 2017, 1:41 a.m., Abhay Kulkarni wrote: > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java > > Line 298 (original), 466 (patched) > > > > > > It appears that th

[jira] [Updated] (RANGER-1887) serviceDef.getResources().get(0).getName(); case IndexOutOfBoundsException in RangerServiceTag.class And print error in RangerServiceStorm

2017-11-22 Thread Qiang Zhang (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang updated RANGER-1887: Attachment: (was: 0001-RANGER-1887-serviceDef.getResources-.get-0-.getName-.patch) > serviceD

[jira] [Updated] (RANGER-1887) serviceDef.getResources().get(0).getName(); case IndexOutOfBoundsException in RangerServiceTag.class And print error in RangerServiceStorm

2017-11-22 Thread Qiang Zhang (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang updated RANGER-1887: Attachment: (was: 0001-RANGER-1887-serviceDef.getResources-.get-0-.getName-.patch) > serviceD

Re: Review Request 64042: RANGER-1897: tagsync update to replace Atlas V1 API usage with Atlas V2 API for tag-download using REST

2017-11-22 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64042/#review191771 --- tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/Atla

[jira] [Commented] (RANGER-1878) The exception infomation print error for RangerPolicyServiceBase.java

2017-11-22 Thread WangYuan (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16263650#comment-16263650 ] WangYuan commented on RANGER-1878: -- [~peng.jianhua] Please see if it need to modify. >

Re: Review Request 63987: RANGER-1905 : fix maven assembly creation

2017-11-22 Thread pengjianhua
> On 十一月 22, 2017, 1:29 a.m., pengjianhua wrote: > > With the latest code, I can not reproduce this issue. The previous version > > had this problem when you set policymgr_http_enabled equal to false in > > install.properties file before installed the security admin. Please refer > > to RANGER

[jira] [Assigned] (RANGER-1897) TagSync should replace use of V1 Atlas APIs with V2 APIs for efficient tag-download from Atlas

2017-11-22 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj reassigned RANGER-1897: Assignee: Madhan Neethiraj > TagSync should replace use of V1 Atlas APIs with V2 A

[jira] [Updated] (RANGER-1897) TagSync should replace use of V1 Atlas APIs with V2 APIs for efficient tag-download from Atlas

2017-11-22 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated RANGER-1897: - Attachment: RANGER-1897.patch Review board URL: https://reviews.apache.org/r/64042/ > Ta

Review Request 64042: RANGER-1897: tagsync update to replace Atlas V1 API usage with Atlas V2 API for tag-download using REST

2017-11-22 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64042/ --- Review request for ranger and Abhay Kulkarni. Bugs: RANGER-1897 https://iss

Re: Review Request 63995: Ranger-1488 Adding GaianDB plugin serviceDef

2017-11-22 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63995/#review191742 --- agents-common/src/main/resources/service-defs/ranger-servicedef-g

Re: Review Request 61062: RANGER-1707 : fix hdfs traverse check

2017-11-22 Thread Abhay Kulkarni
> On Nov. 22, 2017, 2:35 p.m., Colm O hEigeartaigh wrote: > > Ship It! All, Can we please hold on pushing this patch? I am waiting for input from HDFS committers to ensure that this new HDFS authorization (Traverse checking) call sequence is what is intendeded. Thanks! - Abhay --

[jira] [Commented] (RANGER-1707) Traverse check in RangerHdfsAuthorizer works incorrectly

2017-11-22 Thread Velmurugan Periasamy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262719#comment-16262719 ] Velmurugan Periasamy commented on RANGER-1707: -- [~mad...@apache.org]/[~abhay

Re: Build issues - inconsistent

2017-11-22 Thread Nigel Jones
On 2017-11-22 11:45, Colm O hEigeartaigh wrote: > I can't reproduce the test failures in Kafka, HBase or Hive. However, I can > reproduce the build errors in security-admin. It's caused by this bug in > Maven: > > https://issues.apache.org/jira/browse/MNG-6298 > > The solution is to use Apache

Re: Review Request 61062: RANGER-1707 : fix hdfs traverse check

2017-11-22 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61062/#review191736 --- Ship it! Ship It! - Colm O hEigeartaigh On Nov. 22, 2017, 12

[jira] [Commented] (RANGER-1890) The permission of "Kafka Admin" can not support "Select/Deselect All" when add/edit Kafka policy

2017-11-22 Thread Nitin Galave (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262582#comment-16262582 ] Nitin Galave commented on RANGER-1890: -- [~zhangqiang2] All component definition has

[jira] [Updated] (RANGER-1707) Traverse check in RangerHdfsAuthorizer works incorrectly

2017-11-22 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1707: --- Attachment: RANGER-1707-3.patch > Traverse check in RangerHdfsAuthorizer works incorrectly >

Re: Review Request 61062: RANGER-1707 : fix hdfs traverse check

2017-11-22 Thread Zsombor Gegesy
> On Nov. 21, 2017, 4 p.m., Colm O hEigeartaigh wrote: > > You could put some spaces into "for (int i=0;i > There's also an indentation issue on line 201 of RangerHdfsAuthorizerTest. > > Other spacing issue here "ancestorIndex,plugin" > > > > > for (FsAction action : Arrays.asList(FsAction.EXECU

Re: Review Request 61062: RANGER-1707 : fix hdfs traverse check

2017-11-22 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61062/ --- (Updated Nov. 22, 2017, 12:39 p.m.) Review request for ranger. Changes --

Re: Review Request 63987: RANGER-1905 : fix maven assembly creation

2017-11-22 Thread Zsombor Gegesy
> On Nov. 21, 2017, 7:06 p.m., Velmurugan Periasamy wrote: > > agents-audit/pom.xml > > Lines 48 (patched) > > > > > > After this change, atlas plugin does not have guava jar packaged. Can > > you check that? It see

Re: Review Request 63987: RANGER-1905 : fix maven assembly creation

2017-11-22 Thread Zsombor Gegesy
> On Nov. 22, 2017, 1:29 a.m., pengjianhua wrote: > > With the latest code, I can not reproduce this issue. The previous version > > had this problem when you set policymgr_http_enabled equal to false in > > install.properties file before installed the security admin. Please refer > > to RANGE

[jira] [Updated] (RANGER-1905) NoClassDefFoundError from the built zip/tar.gz, created by the maven-assembly-plugin

2017-11-22 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1905: --- Attachment: RANGER-1905-2.patch > NoClassDefFoundError from the built zip/tar.gz, created by

Re: Review Request 63987: RANGER-1905 : fix maven assembly creation

2017-11-22 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63987/ --- (Updated Nov. 22, 2017, 12:23 p.m.) Review request for ranger. Changes --

Re: Review Request 61062: RANGER-1707 : fix hdfs traverse check

2017-11-22 Thread Colm O hEigeartaigh
> On Nov. 21, 2017, 4 p.m., Colm O hEigeartaigh wrote: > > You could put some spaces into "for (int i=0;i > There's also an indentation issue on line 201 of RangerHdfsAuthorizerTest. > > Other spacing issue here "ancestorIndex,plugin" > > > > > for (FsAction action : Arrays.asList(FsAction.EXECU

Re: Review Request 63981: RANGER-1903:Simplify the maven dependency management of the Hdfs plugin for Ranger.

2017-11-22 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63981/#review191718 --- You could also remove the solr dependency - it is picked up anyway

Re: Build issues - inconsistent

2017-11-22 Thread Colm O hEigeartaigh
I can't reproduce the test failures in Kafka, HBase or Hive. However, I can reproduce the build errors in security-admin. It's caused by this bug in Maven: https://issues.apache.org/jira/browse/MNG-6298 The solution is to use Apache Maven 3.5.0 instead of 3.5.2. Colm. On Tue, Nov 21, 2017 at 5:

Re: Review Request 63981: RANGER-1903:Simplify the maven dependency management of the Hdfs plugin for Ranger.

2017-11-22 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63981/#review191715 --- Ship it! Ship It! - Qiang Zhang On Nov. 22, 2017, 2:04 a.m.,

[jira] [Updated] (RANGER-1890) The permission of "Kafka Admin" can not support "Select/Deselect All" when add/edit Kafka policy

2017-11-22 Thread Qiang Zhang (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang updated RANGER-1890: Description: The current logic is as following: 1. Other checkbox will not be selected when the "Ka

Re: Review Request 64022: The permission of "Kafka Admin" can not support "Select/Deselect All" when add/edit Kafka policy

2017-11-22 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64022/ --- (Updated Nov. 22, 2017, 8:51 a.m.) Review request for ranger, Alok Lal, Ankita

[jira] [Comment Edited] (RANGER-1890) The permission of "Kafka Admin" can not support "Select/Deselect All" when add/edit Kafka policy

2017-11-22 Thread Qiang Zhang (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262155#comment-16262155 ] Qiang Zhang edited comment on RANGER-1890 at 11/22/17 8:48 AM:

[jira] [Commented] (RANGER-1890) The permission of "Kafka Admin" can not support "Select/Deselect All" when add/edit Kafka policy

2017-11-22 Thread Qiang Zhang (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262155#comment-16262155 ] Qiang Zhang commented on RANGER-1890: - Hi [~nitin.galave]. The operational logic of t

[jira] [Commented] (RANGER-1837) Enhance Ranger Audit to HDFS to support ORC file format

2017-11-22 Thread Don Bosco Durai (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262125#comment-16262125 ] Don Bosco Durai commented on RANGER-1837: - bq. and send it to AsyncAuditQueue. T