-
>
> (Updated July 28, 2017, 3:32 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, and Qiang
> Zhang.
>
>
> Bugs: RANGER-1669
> https://issues.apache.org/jira/browse/RANGER-1669
>
>
> Repository: ranger
>
>
> D
he Ranger authorizer?
- Colm O hEigeartaigh
On July 31, 2017, 2:15 a.m., pengjianhua wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> ht
> On July 31, 2017, 2:12 p.m., Colm O hEigeartaigh wrote:
> > I'm wondering what the expected output of "show grant user X" is? I would
> > have expected to see the privileges that correspond to policies created in
> > the Ranger admin service, but th
> On July 31, 2017, 2:12 p.m., Colm O hEigeartaigh wrote:
> > I'm wondering what the expected output of "show grant user X" is? I would
> > have expected to see the privileges that correspond to policies created in
> > the Ranger admin service, but th
> On July 31, 2017, 2:12 p.m., Colm O hEigeartaigh wrote:
> > I'm wondering what the expected output of "show grant user X" is? I would
> > have expected to see the privileges that correspond to policies created in
> > the Ranger admin service, but th
fixed. Also,
the indentation of showPrivileges is incorrect, starting with
"List msObjPrivs"
- Colm O hEigeartaigh
On Aug. 2, 2017, 6:59 a.m., pengjianhua wrote:
>
> ---
> This is an automatically generated e-mail. To re
starting line 1473...
- Colm O hEigeartaigh
On Aug. 4, 2017, 9:21 a.m., pengjianhua wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
authWithConfig?
It's not really clear from the bug description. One potential issue is that
setUGIFromJAASConfig requires a KeyTab in JAAS configuration, whereas
authWithConfig looks like it would work with a password.
- Colm O hEigeartaigh
On Aug. 3, 2017, 6:53 p.m., Ramesh Mani
errList.add(excp.getMessage() + ". \n");
}
}
We should just have one if statement here and replace the last two checks with
StringUtils.isNotEmpty(str) - and put it as the first part of the if statement.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61383/#review182197
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Aug. 2, 2017, 8
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61395/#review182198
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Aug. 3, 2017, 2
tion of "objectType" that could be used instead.
- Colm O hEigeartaigh
On Aug. 4, 2017, 1:25 p.m., pengjianhua wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
the "first" case. The
exception message is now changed from:
msgDesc + errMsg
to
getMessage(exp) + DEFAULT_ERROR_MESSAGE
But the exp is null here, and so this is just DEFAULT_ERROR_MESSAGE.
- Colm O hEigeartaigh
On Aug. 4, 2017, 8:22 p.m.,
"getSupportedServiceDef" as well - it's not needed. You could also move the
"supportedServiceDefs" definition down from the static variable declarations
down to the instance variable declarations.
- Colm O hEigeartaigh
On Aug. 7, 2017, 11:3
onfig" method as
part of this patch, as it's not used by any other code.
- Colm O hEigeartaigh
On Aug. 8, 2017, 12:45 a.m., Ramesh Mani wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> h
/
Testing
---
Thanks,
Colm O hEigeartaigh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61384/#review182478
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Aug. 8, 2017, 7
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61452/#review182481
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Aug. 9, 2017, 5
] HIVERangerAuthorizerTest.testShowPrivileges:917 Failure on User has
to specify a user name or role in the show grant
[INFO]
- Colm O hEigeartaigh
On Aug. 9, 2017, 5:35 a.m., pengjianhua wrote:
>
> ---
> This is an automatically ge
--
>
> (Updated Aug. 10, 2017, 2:41 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, and Qiang
> Zhang.
>
>
> Bugs: RANGER-1669
> https://issues.apache.org/jira/browse/RANGER-1669
>
>
> Repository: ranger
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61202/#review182580
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Aug. 10, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59604/#review182683
---
*bump*
- Colm O hEigeartaigh
On May 26, 2017, 10 a.m., Colm O
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59523/#review182682
---
*bump*
- Colm O hEigeartaigh
On May 24, 2017, 11:08 a.m., Colm
me of the other devs
before applying it.
- Colm O hEigeartaigh
On July 22, 2017, 10:31 a.m., Zsombor Gegesy wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
---
Thanks,
Colm O hEigeartaigh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61624/#review182934
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Aug. 14, 2017, 9
/biz/RangerBizUtil.java
a3e9746e
Diff: https://reviews.apache.org/r/61519/diff/2/
Changes: https://reviews.apache.org/r/61519/diff/1-2/
Testing
---
Thanks,
Colm O hEigeartaigh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62010/#review184257
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Aug. 31, 2017, 7
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59604/#review184258
---
Please review...
- Colm O hEigeartaigh
On May 26, 2017, 10 a.m
his working locally? Or should we just remove the link to
the KMS apidocs from the website?
Colm.
--
Colm O hEigeartaigh
Talend Community Coder
http://coders.talend.com
> On March 29, 2017, 4:06 p.m., Colm O hEigeartaigh wrote:
> > Pretty cool to see new plugins being submitted! What is the scenario for
> > supporting "unsecure" mode (should be "insecure" IMO btw)? Some
> > documentation would be nice as to
the connection
to a Hive server with the latest code. What is the underlying cause of the
exception?
- Colm O hEigeartaigh
On Sept. 6, 2017, 7:24 a.m., pengjianhua wrote:
>
> ---
> This is an automatically generated e-mail. To rep
following two if statements should have a space after "if" and before
the opening curly brackets:
if(hiveObj.getType() == null){
if(databaseorUrl == null){
- Colm O hEigeartaigh
On Sept. 6, 2017, 6:34 a.m., pengjianhua wrote:
>
> --
/ranger/services/hive/HIVERangerAuthorizerTest.java
17eb1e71
Diff: https://reviews.apache.org/r/62124/diff/1/
Testing
---
Thanks,
Colm O hEigeartaigh
Hi all,
Is there any point in keeping the ranger-hive-utils module, given that it
appears not to be used anymore in the Ranger code-base?
Colm.
--
Colm O hEigeartaigh
Talend Community Coder
http://coders.talend.com
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62076/#review184802
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Sept. 7, 2017, 1
it once all
> docs are getting populated for Ranger KMS?
>
>
>
>
> On Sat, Sep 2, 2017 at 12:55 PM, Mehul Parikh wrote:
>
> > Hi Colm,
> >
> > I will check for the same and provide a updated patch if needed.
> >
> > On Sep 1, 2017 4:15 PM, &quo
Diff: https://reviews.apache.org/r/62188/diff/1/
Testing
---
Thanks,
Colm O hEigeartaigh
Mehul Parikh wrote:
> Hi Colm,
>
> Please run : "mvn enunciate:docs" and then from docs directory run: "mvn
> site".
>
>
> On Sep 8, 2017 8:00 PM, "Colm O hEigeartaigh" wrote:
>
> > Hi Mehul,
> >
> > How are you generating the w
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62233/#review185167
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Sept. 12, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62269/#review185387
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Sept. 13, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62264/#review185388
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Sept. 13, 2017
ation/hive/udf/RangerUdfMaskShowFirstN.java
24929b7d
ranger-hive-utils/src/main/java/org/apache/ranger/authorization/hive/udf/RangerUdfMaskShowLastN.java
d3db2af5
Diff: https://reviews.apache.org/r/62349/diff/1/
Testing
---
Thanks,
Colm O hEigeartaigh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62400/#review185672
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Sept. 19, 2017
audit
install.properties? Why not just take it from the environment like all of the
other plugins?
- Colm O hEigeartaigh
On Sept. 18, 2017, 7:01 a.m., pengjianhua wrote:
>
> ---
> This is an automatically generated e-mail. To rep
> On Sept. 19, 2017, 11:43 a.m., Colm O hEigeartaigh wrote:
> > I wonder if we need to support JAVA_HOME at all here in the solr audit
> > install.properties? Why not just take it from the environment like all of
> > the other plugins?
>
> pengjianhua wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62372/#review185683
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Sept. 18, 2017
> On Sept. 19, 2017, 11:43 a.m., Colm O hEigeartaigh wrote:
> > I wonder if we need to support JAVA_HOME at all here in the solr audit
> > install.properties? Why not just take it from the environment like all of
> > the other plugins?
>
> pengjianhua wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62376/#review185795
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Sept. 19, 2017
. Something like
"could not find the service-def for the service-type '" + serviceType + "'"
Secondly, I don't understand the need for the second change, the ServiceType is
empty here so why do we need to log it?
- Colm O hEigeartaigh
On Sept. 20,
em is, can you update
the description with more information please?
- Colm O hEigeartaigh
On Sept. 19, 2017, 2:15 a.m., pengjianhua wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
gt; >263 System.exit(1);
> > >264 }
> > >265 } else {
> > >266 System.out.println("User does not exist
> > >in DB!!");
> > >267
/RangerAdminClientImpl.java
6ce6979f
Diff: https://reviews.apache.org/r/62503/diff/1/
Testing
---
Thanks,
Colm O hEigeartaigh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62498/#review185974
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Sept. 22, 2017
x-www-form-urlencoded" as it is referenced in both the call and
the exception message.
- Colm O hEigeartaigh
On Sept. 25, 2017, 3:26 a.m., pengjianhua wrote:
>
> ---
> This is an automatically generated e-mail. To re
"roleSysAdminMap.entrySet()"
instead of adding an Iterator?
- Colm O hEigeartaigh
On Sept. 25, 2017, 10:44 a.m., Fatima Khan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62539/#review186120
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Sept. 25, 2017
e.g. "The Master Key Password
is empty or not a valid password"
- Colm O hEigeartaigh
On Sept. 25, 2017, 5:47 a.m., wang yuan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> ht
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62430/#review186124
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Sept. 25, 2017
<< ERROR!
> > org.apache.kafka.common.errors.TopicAuthorizationException: Not
> > authorized to access topics: [test]
> >
> > [INFO]
> > [INFO] Results:
> > [INFO]
> > [ERROR] Errors:
> > [ERROR] KafkaRangerAuthorizerGSSTest.testAuthorizedRead ยป
> > TopicAuthorization Not autho...
> > [INFO]
> > [ERROR] Tests run: 6, Failures: 0, Errors: 1, Skipped: 0
> >
> > How to resolve this problem ?
> >
> > Thanks.
> >
> >
> >
> >
>
--
Colm O hEigeartaigh
Talend Community Coder
http://coders.talend.com
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62521/#review186230
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Sept. 25, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62522/#review186231
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Sept. 26, 2017
> On Sept. 25, 2017, 2:08 p.m., Colm O hEigeartaigh wrote:
> > Why not just change the existing for loops to use
> > "roleSysAdminMap.entrySet()" instead of adding an Iterator?
>
> Fatima Khan wrote:
> In coverity scan, we had got FB.WMI_WRONG_MAP_ITERA
-
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61021/
> ---
>
> (Updated Sept. 27, 2017, 9:19 a.m.)
>
>
> Review request for ranger,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62520/#review186395
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Sept. 27, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62650/#review186544
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Sept. 28, 2017
d not implicitly
call toString(), e.g. logger.error("Get transaction log failure.", illegalAcc);
Also change "Get transaction log failure" to just "Transaction log failure"
- Colm O hEigeartaigh
On Sept. 29,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62659/#review186667
---
Can you fix the whitespace errors in the patch?
- Colm O
> On Aug. 11, 2017, 11:55 a.m., Colm O hEigeartaigh wrote:
> > *bump*
Requesting review, please.
- Colm
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59523/#rev
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62659/#review186832
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Oct. 2, 2017, 9
request in doFilter.
Diffs
-
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java
481fe8e7
Diff: https://reviews.apache.org/r/62724/diff/1/
Testing
---
Tested with Knox.
Thanks,
Colm O hEigeartaigh
etc.
Thanks,
Colm O hEigeartaigh
Colm O hEigeartaigh
On Oct. 2, 2017, 2:11 p.m., Colm O hEigeartaigh wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
/conf).
- Colm O hEigeartaigh
On Oct. 12, 2017, 9:02 a.m., Qiang Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
contributor will
> > soon use this feature.
>
> Colm O hEigeartaigh wrote:
> When will Kylin 2.2.0 be released? If we merge a dependency on a SNAPSHOT
> version in Ranger, we can't release Ranger until Kylin is released. Do you
> have any documentation on how to s
py ranger-sqoop-security.xml to the root directory
of the Sqoop installation. Any idea why this is?
e) After changing the policy in Ranger and having it synced down, it only
"applies" once I exited the sqoop shell and restarted it. Any idea why this is?
I guess it is caching the old po
g/apache/ranger/security/web/filter/SSOAuthenticationProperties.java
7706d9bf
Diff: https://reviews.apache.org/r/63030/diff/1/
Testing
---
Tested that audience validation works correctly with KNOXSSO.
Thanks,
Colm O hEigeartaigh
/RangerMasterKeyTest.java
cac22502
storm-agent/src/test/java/org/apache/ranger/authorization/storm/StormRangerAuthorizerTest.java
53173078
Diff: https://reviews.apache.org/r/63068/diff/1/
Testing
---
Thanks,
Colm O hEigeartaigh
contributor will
> > soon use this feature.
>
> Colm O hEigeartaigh wrote:
> When will Kylin 2.2.0 be released? If we merge a dependency on a SNAPSHOT
> version in Ranger, we can't release Ranger until Kylin is released. Do you
> have any documentation on how to s
contributor will
> > soon use this feature.
>
> Colm O hEigeartaigh wrote:
> When will Kylin 2.2.0 be released? If we merge a dependency on a SNAPSHOT
> version in Ranger, we can't release Ranger until Kylin is released. Do you
> have any documentation on how to s
/security/web/filter/SSOAuthenticationProperties.java
b8246a9a
Diff: https://reviews.apache.org/r/63147/diff/1/
Testing
---
Tested it with Knox.
Thanks,
Colm O hEigeartaigh
over" hint for "Sqoop URL" in the Admin Console (e.g. should be
"http://localhost:12000";)
b) Remove "password" from the UI as it's not used
c) Remove "password" from SqoopClient as it's not used.
- Colm O h
/diff/1/
Testing
---
Thanks,
Colm O hEigeartaigh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62710/#review188931
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Oct. 23, 2017, 9
---
On Oct. 24, 2017, 9:02 a.m., Qiang Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62710/
> -
different
version String...
- Colm O hEigeartaigh
On Oct. 24, 2017, 8:39 a.m., pengjianhua wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63145/#review189299
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Oct. 24, 2017, 8
xtFieldWithIcon" when making
this change.
- Colm O hEigeartaigh
On Oct. 27, 2017, 7:46 a.m., Qiang Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> ht
StringBuilder
instead of StringBuffer.
- Colm O hEigeartaigh
On Oct. 27, 2017, 7:09 a.m., Qiang Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63351/#review189408
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Oct. 27, 2017, 9
t;
> (Updated Oct. 30, 2017, 3:22 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani,
> Selvamohan Neethiraj, sam rome, and Velmurugan Periasamy.
>
>
> Bugs: RAN
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63404/#review189706
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Oct. 30, 2017, 6
/diff/1/
Testing
---
Tested with Knox 0.14-SNAPSHOT.
Thanks,
Colm O hEigeartaigh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63403/#review189789
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Nov. 1, 2017, 8
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63534/#review190018
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Nov. 3, 2017, 8
uot;need" (also change this
for the Yarn plugin).
- Colm O hEigeartaigh
On Nov. 6, 2017, 12:11 p.m., wang yuan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> ht
spaces
- Colm O hEigeartaigh
On Nov. 7, 2017, 1:26 a.m., wang yuan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
getRandomLinkName and getRandomJobName there is no need to store the
variable - just return it directly, e.g. return
RandomStringUtils.randomAlphanumeric(10) + "-link";
b) Change new ArrayList() to new ArrayList<>()
- Colm O hEigeartaigh
On Nov. 7, 2017, 6:56 a.m., Q
correctly.
Thanks,
Colm O hEigeartaigh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63578/#review190320
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Nov. 7, 2017, 11
401 - 500 of 1156 matches
Mail list logo
