Re: LookupLocator

2012-11-14 Thread Simon IJskes - QCG
On 14-11-12 03:57, Gregg Wonderly wrote: Of course, the practical matter, is that in this day and age, server port numbers indicate specific types of services for the things in /etc/services. But, really, we should move the whole discovery business away from socket creation parameters and into

Re: LookupLocator

2012-11-14 Thread Dan Creswell
Indeed, I feel there's something slightly broken design-wise in adding a SocketFactory parameter to LookupLocator. See the URL basically defines the kind of connectivity (consider http versus https) and thus the kind of socket used. It would be possible, for example, to pass a socket factory that

Re: LookupLocator

2012-11-14 Thread Simon IJskes - QCG
On 14-11-12 10:49, Dan Creswell wrote: Which implies a socket factory isn't required because there's only one way to do unicast and it's all taken care of under the covers. A socketfactory is also the place to post process Sockets [1]. So if you want to keep Socket, there is no reason to do

Re: LookupLocator

2012-11-14 Thread Peter Firmstone
Reading over the comments, we all appear to be agreeing on Gregg's approach, in that case I'll clean up LookupLocator before release, then we can look at how we can implement a configurable deployment mechanism. Regards, Peter. On 14/11/2012 8:28 PM, Dan Creswell wrote: ... On 14 November

Re: LookupLocator

2012-11-14 Thread Simon IJskes - QCG
On 14-11-12 11:50, Peter Firmstone wrote: Reading over the comments, we all appear to be agreeing on Gregg's approach, in that case I'll clean up LookupLocator before release, then we can look at how we can implement a configurable deployment mechanism. I was against removing the

Re: LookupLocator

2012-11-14 Thread Peter Firmstone
Is it possible for you to subclass LookupLocator and override the getRegistrar method? Alternatively you could subclass ConstrainableLookupLocator and subclass com.sun.jini.discovery.internal.MultiIPDiscovery, this is far simpler to implement and would allow you to inject a socket into

Re: LookupLocator

2012-11-14 Thread Simon IJskes - QCG
On 14-11-12 13:52, Peter Firmstone wrote: I'm familiar with the ConstrainableLookupLocator code, I could knock it up for you in about 10 min, I actually did this when I realised the SocketFactory in LookupLocator wasn't being used by LookupLocatorDiscovery or ConstrainableLookupLocator, then I

Re: LookupLocator

2012-11-14 Thread Peter Firmstone
On 14/11/2012 11:00 PM, Simon IJskes - QCG wrote: On 14-11-12 13:52, Peter Firmstone wrote: I'm familiar with the ConstrainableLookupLocator code, I could knock it up for you in about 10 min, I actually did this when I realised the SocketFactory in LookupLocator wasn't being used by

Re: LookupLocator

2012-11-14 Thread Gerard Fulton
Agreed. On Tue, Nov 13, 2012 at 6:57 PM, Gregg Wonderly ge...@cox.net wrote: Of course, the practical matter, is that in this day and age, server port numbers indicate specific types of services for the things in /etc/services. But, really, we should move the whole discovery business away