Re: Problems dealing with bead substitution in Royale

Hi Yishay, you're right. Jewel has NullLayout in some places since the component use to do things vía CSS, I need to refactor that to a layout bead to make it more decoupled. I announced that was temporal. But don't think the problem exposed in this thread is about setting null for a bead. Is mor

RE: Problems dealing with bead substitution in Royale

Sorry, meant this [1] one [1] https://github.com/yishayw/Examples/tree/RunTimeLayout From: Carlos Rovira Sent: Monday, January 28, 2019 10:29:11 AM To: dev@royale.apache.org Subject: Re: Problems dealing with bead substitution in Royale Hi Yishay, you're ri

Re: Problems dealing with bead substitution in Royale

HI Alex mostly agree with your thoughts. Just some points: * While I think beads should be "instantiation time", don't agree with wanting to remove the "removeBead" method. We're a framework, and people will find this problem. So is difficult to explain the we don't have any way to do this * In t

Re: Problems dealing with bead substitution in Royale

I mentioned a long time ago that I really want to implement a notification system for strands and beads. I’ve always felt that events are kind of hacky. I would require a little bit of scaffolding for the notifications so it’s not truly PAYG, but the notifications could really be plug and play.

Re: Problems dealing with bead substitution in Royale

I just added a utility function for this. I thought of checking to see if the bead has a beadRemoved() method and conditionally calling that, but it seemed not PAYG and hacky. My thoughts are to use this like so: var removedBead:MyBeadThatKnowsHowToCleaupAfterItself = replaceBead(strand, newBe

Re: Problems dealing with bead substitution in Royale

Hi Harbs this seems to me the right way to go. In the current case, I think Jewel should not know about how to clean itself since is not PAYG. So Piotr should subclass the bead and add the clean up functionality an configure as default in this project. Then use your replaceBead to do the change

Build failed in Jenkins: royale-asjs_MXTests #413

See Changes: [harbs] Added replaceBead utility function [yishayjobs] Added DarkenedBevelFilter -- [...truncated 2.01 MB...] [mxmlc] usin

Jenkins build is back to normal : royale-asjs_MXTests #414

See

Re: Problems dealing with bead substitution in Royale

It is fine to have a utility function such as this, but IMO, it doesn't actually solve the problem. If the original bead does not know how to remove itself, then a version of that bead needs to be created that does know how to remove itself. While we could add replaceable versions of every bea

Re: Problems dealing with bead substitution in Royale

Good point. If we would implement my idea of notifications, we could use utility functions to clean out beads. If anyone is interested in this direction, I can write an implementation in a branch to show what I’m talking about… Harbs > On Jan 28, 2019, at 6:22 PM, Alex Harui wrote: > > It i

Re: Problems dealing with bead substitution in Royale

IMO, either use a few more words to describe it here, or show the code in a branch. I don't think the generic problem of cleaning up an instance from an external instance is solvable, but maybe there are sweet spots along the way. -Alex On 1/28/19, 8:26 AM, "Harbs" wrote: Good point.

Re: Problems dealing with bead substitution in Royale

Guys, Many thanks for all your thoughts. Harbs thank you for this utility it will be very useful. I think I'm ok with having some specialized stuff which is doing things like removing bead etc. I did small clean up of FormItemView and put it in other thread. I wrote also StackedFormView but I did

FormItemView changes

Hi Guys, I just make changes which I have mention in other thread. 1. I have removed code which transfers beads through the components. [1] In the results: IBeadLayout - Is responsible for general layout of FormItem (default: HorizontalLayout) IFormItemContentArea - Is responsible for content (de

Re: [royale-asjs] branch develop updated: Jewel Group: Fix dynamic adding Horizontal/Vertical layout

Hi Carlos, Ok I will revert changes soon. Thanks, Piotr niedz., 27 sty 2019 o 18:04 Carlos Rovira napisał(a): > Hi Piotr, > > thinking on it better, I prefer your proposal or revert the change of the > removal of basic layout css and manage as part of your app code for now, > since I think it

Re: Problems dealing with bead substitution in Royale

Just give your version a different name that describes what it is and commit it to Royale. Royale gives folks choices. My 2 cents, -Alex On 1/28/19, 12:01 PM, "Piotr Zarzycki" wrote: Guys, Many thanks for all your thoughts. Harbs thank you for this utility it will be very us

FormItem and center align

Hi Carlos, FormItem default has after build: .layout.itemsCentered { 1. align-items: center !important; } Cause of this one [1] - How can I override it ? I have tried several things in css but I'm hitting the wall. Maybe we shouldn't provide such default value there at all ? [1] https://g

Border-box globals redux

I ran into a problem with the Royale setting of .royale *{box-sizing:border-box}[1] I wonder how common it is to a have a Royale app embedded in a page that relies on the global content-box. Setting less specific *{box-sizing:border-box} might be a better solution. Harbs [1]https://github.com

Build failed in Jenkins: royale-asjs_jsonly #2362

See -- [...truncated 1.89 MB...] [mxmlc]

Build failed in Jenkins: royale-asjs_jsonly #2363

See -- [...truncated 1.89 MB...] [mxmlc]

Re: FormItem and center align

Never mind with that - I figure out how to do that. However question with whether that should be part of framework or not stands. pon., 28 sty 2019 o 22:48 Piotr Zarzycki napisał(a): > Hi Carlos, > > FormItem default has after build: > > .layout.itemsCentered { > >1. align-items: center !imp

Build failed in Jenkins: royale-asjs #1867

See -- [...truncated 2.39 MB...] [mxmlc] org.apache.royale.core.SimpleStatesImpl depends on org.apache.royale.core.IBead [mxmlc] Dependencies calculated f