Review Request 47283: SamzaCoordinator Refactor Part 2: UI related changes, dead code removal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47283/ --- Review request for samza, Boris Shkolnik and Yi Pan (Data Infrastructure). Repo

Re: Review Request 47197: SAMZA-948 CoordinatorSystemStreamConsumer is not threadsafe

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47197/ --- (Updated May 12, 2016, 12:32 a.m.) Review request for samza, Boris Shkolnik, Ch

Re: Review Request 47251: SAMZA-852 - Better logging when system can not be created Always log the exception when we cant instantiate a producer or consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47251/#review132796 --- Ship it! Ship It! - Yi Pan (Data Infrastructure) On May 11,

Re: Review Request 47197: SAMZA-948 CoordinatorSystemStreamConsumer is not threadsafe

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47197/ --- (Updated May 11, 2016, 11:55 p.m.) Review request for samza, Boris Shkolnik, Ch

Re: Review Request 47197: SAMZA-948 CoordinatorSystemStreamConsumer is not threadsafe

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47197/ --- (Updated May 11, 2016, 11:49 p.m.) Review request for samza, Boris Shkolnik, Ch

Re: Review Request 47247: SAMZA-947 - TaskAssignmentManager registration exception when partition count changes.

> On May 11, 2016, 9:18 p.m., Yi Pan (Data Infrastructure) wrote: > > samza-core/src/main/java/org/apache/samza/container/grouper/task/TaskAssignmentManager.java, > > line 42 > > > > > > I guess that currently TaskAs

Re: Review Request 47197: SAMZA-948 CoordinatorSystemStreamConsumer is not threadsafe

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47197/#review132785 --- Ship it! samza-core/src/main/java/org/apache/samza/coordinator

Re: Review Request 47247: SAMZA-947 - TaskAssignmentManager registration exception when partition count changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47247/#review132749 --- Ship it! lgtm. +1. samza-core/src/main/java/org/apache/samza/

Re: Review Request 47247: SAMZA-947 - TaskAssignmentManager registration exception when partition count changes.

> On May 11, 2016, 8:07 p.m., Yi Pan (Data Infrastructure) wrote: > > It seems that all we needed to fix the issue is to remove the line to > > register the coordinator stream consumer? Did I miss any other things? > > Jake Maes wrote: > The key change is to remove the register() call from

Re: Review Request 47247: SAMZA-947 - TaskAssignmentManager registration exception when partition count changes.

> On May 11, 2016, 8:07 p.m., Yi Pan (Data Infrastructure) wrote: > > It seems that all we needed to fix the issue is to remove the line to > > register the coordinator stream consumer? Did I miss any other things? The key change is to remove the register() call from GroupByContainerCount.save

Re: Review Request 47247: SAMZA-947 - TaskAssignmentManager registration exception when partition count changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47247/ --- (Updated May 11, 2016, 8:26 p.m.) Review request for samza, Boris Shkolnik, Chr

Re: Review Request 47247: SAMZA-947 - TaskAssignmentManager registration exception when partition count changes.

> On May 11, 2016, 8:07 p.m., Yi Pan (Data Infrastructure) wrote: > > samza-core/src/main/java/org/apache/samza/container/grouper/task/TaskAssignmentManager.java, > > line 58 > > > > > > There is no place that we cha

Re: Review Request 47197: SAMZA-948 CoordinatorSystemStreamConsumer is not threadsafe

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47197/#review132742 --- Ship it! lgtm. samza-core/src/main/java/org/apache/samza/coor

Re: Review Request 47197: SAMZA-948 CoordinatorSystemStreamConsumer is not threadsafe

> On May 11, 2016, 6:28 p.m., Chris Pettitt wrote: > > Yes, and yes. Thanks! - Jake --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47197/#review132710 ---

Re: Review Request 47197: SAMZA-948 CoordinatorSystemStreamConsumer is not threadsafe

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47197/ --- (Updated May 11, 2016, 8:13 p.m.) Review request for samza, Boris Shkolnik, Chr

Re: Review Request 47247: SAMZA-947 - TaskAssignmentManager registration exception when partition count changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47247/#review132737 --- It seems that all we needed to fix the issue is to remove the line

Re: Review Request 47251: SAMZA-852 - Better logging when system can not be created Always log the exception when we cant instantiate a producer or consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47251/#review132730 --- Ship it! Thanks for getting the fix in! lgtm - Jagadish - Jag

Re: help me about samza metrics

Hi, Shaodong, Could you clarify what's your specific question? I can see that you configured your job to use snapshot metrics reporter and you are getting the JSON format snapshot report as expected. What's wrong here? On Tue, May 10, 2016 at 1:25 AM, SSHOU wrote: > Sorry, forget Task config fi

Review Request 47251: SAMZA-852 - Better logging when system can not be created Always log the exception when we cant instantiate a producer or consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47251/ --- Review request for samza, Boris Shkolnik, Chris Pettitt, Jake Maes, Navina Rames

Re: Review Request 47197: SAMZA-948 CoordinatorSystemStreamConsumer is not threadsafe

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47197/#review132710 --- Fix it, then Ship it! samza-core/src/main/java/org/apache/samz

Re: Review Request 40934: SAMZA-827: null offsets when writing state store OFFSET file cause container stalls

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40934/ --- (Updated May 11, 2016, 6:25 p.m.) Review request for samza. Summary (updated)

Re: Review Request 40934: SAMZA-827: Handle null offsets when writing state store OFFSET file

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40934/ --- (Updated May 11, 2016, 6:21 p.m.) Review request for samza. Repository: samza

Review Request 47247: SAMZA-947 - TaskAssignmentManager registration exception when partition count changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47247/ --- Review request for samza, Boris Shkolnik, Chris Pettitt, Jake Maes, Navina Rames

Re: Review Request 45258: Abandon producer retry after a certain # of errors : SAMZA-911

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45258/ --- (Updated May 11, 2016, 5:51 p.m.) Review request for samza, Jake Maes, Navina R

Re: Review Request 46287: Add a double serde.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46287/#review132689 --- @Jon, forgot to mention: it would be good to add this new build-in