Re: [PR] Implementation of the HKDF derivation function [santuario-xml-security-java]

2024-05-08 Thread via GitHub
coheigea commented on PR #271: URL: https://github.com/apache/santuario-xml-security-java/pull/271#issuecomment-2100369954 @seanjmullan Is it ready to be merged from your PoV? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] Implementation of the HKDF derivation function [santuario-xml-security-java]

2024-05-07 Thread via GitHub
jrihtarsic commented on code in PR #271: URL: https://github.com/apache/santuario-xml-security-java/pull/271#discussion_r1593378838 ## src/main/java/org/apache/xml/security/encryption/XMLCipherUtil.java: ## @@ -274,13 +274,18 @@ public static KeyAgreementParameters constructAg

Re: [PR] [SANTUARIO-614] Tests for the EC Brainpool key types [santuario-xml-security-java]

2024-05-07 Thread via GitHub
coheigea merged PR #298: URL: https://github.com/apache/santuario-xml-security-java/pull/298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

Re: [PR] Bump advanced-security/maven-dependency-submission-action from 4.0.2 to 4.0.3 [santuario-xml-security-java]

2024-05-07 Thread via GitHub
coheigea merged PR #319: URL: https://github.com/apache/santuario-xml-security-java/pull/319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

Re: [PR] Bump com.google.errorprone:error_prone_core from 2.27.0 to 2.27.1 [santuario-xml-security-java]

2024-05-07 Thread via GitHub
coheigea merged PR #318: URL: https://github.com/apache/santuario-xml-security-java/pull/318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

Re: [PR] Implementation of the HKDF derivation function [santuario-xml-security-java]

2024-05-07 Thread via GitHub
seanjmullan commented on code in PR #271: URL: https://github.com/apache/santuario-xml-security-java/pull/271#discussion_r1592394464 ## src/main/java/org/apache/xml/security/encryption/XMLCipherUtil.java: ## @@ -274,13 +274,18 @@ public static KeyAgreementParameters constructA

Re: [PR] Implementation of the HKDF derivation function [santuario-xml-security-java]

2024-05-07 Thread via GitHub
jrihtarsic commented on code in PR #271: URL: https://github.com/apache/santuario-xml-security-java/pull/271#discussion_r1592359981 ## src/main/java/org/apache/xml/security/encryption/XMLCipherUtil.java: ## @@ -271,93 +272,42 @@ public static KeyAgreementParameters constructAg

Re: [PR] Implementation of the HKDF derivation function [santuario-xml-security-java]

2024-05-06 Thread via GitHub
seanjmullan commented on code in PR #271: URL: https://github.com/apache/santuario-xml-security-java/pull/271#discussion_r1583144930 ## src/main/java/org/apache/xml/security/encryption/XMLCipherUtil.java: ## @@ -271,93 +272,42 @@ public static KeyAgreementParameters constructA

[PR] Bump advanced-security/maven-dependency-submission-action from 4.0.2 to 4.0.3 [santuario-xml-security-java]

2024-05-05 Thread via GitHub
dependabot[bot] opened a new pull request, #319: URL: https://github.com/apache/santuario-xml-security-java/pull/319 Bumps [advanced-security/maven-dependency-submission-action](https://github.com/advanced-security/maven-dependency-submission-action) from 4.0.2 to 4.0.3. Release note

Re: [PR] [SANTUIARIO-614] Tests for the EC Brainpool key types [santuario-xml-security-java]

2024-05-03 Thread via GitHub
seanjmullan commented on code in PR #298: URL: https://github.com/apache/santuario-xml-security-java/pull/298#discussion_r1589580667 ## src/test/resources/org/apache/xml/security/samples/input/README.txt: ## Review Comment: I think we should work towards a guideline where

Re: [PR] [SANTUARIO-616] enable manual decryption of the EncryptedKey with KeyAgreement [santuario-xml-security-java]

2024-05-03 Thread via GitHub
coheigea merged PR #305: URL: https://github.com/apache/santuario-xml-security-java/pull/305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

Re: [PR] [SANTUARIO-616] enable manual decryption of the EncryptedKey with KeyAgreement [santuario-xml-security-java]

2024-05-02 Thread via GitHub
seanjmullan commented on PR #305: URL: https://github.com/apache/santuario-xml-security-java/pull/305#issuecomment-2091198896 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[PR] Bump com.google.errorprone:error_prone_core from 2.27.0 to 2.27.1 [santuario-xml-security-java]

2024-05-01 Thread via GitHub
dependabot[bot] opened a new pull request, #318: URL: https://github.com/apache/santuario-xml-security-java/pull/318 Bumps [com.google.errorprone:error_prone_core](https://github.com/google/error-prone) from 2.27.0 to 2.27.1. Release notes Sourced from https://github.com/google/er

Re: [PR] Bump actions/upload-artifact from 4.3.2 to 4.3.3 [santuario-xml-security-java]

2024-04-29 Thread via GitHub
coheigea merged PR #314: URL: https://github.com/apache/santuario-xml-security-java/pull/314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

Re: [PR] Bump com.google.errorprone:error_prone_core from 2.26.1 to 2.27.0 [santuario-xml-security-java]

2024-04-29 Thread via GitHub
coheigea merged PR #315: URL: https://github.com/apache/santuario-xml-security-java/pull/315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

Re: [PR] Bump actions/checkout from 4.1.3 to 4.1.4 [santuario-xml-security-java]

2024-04-29 Thread via GitHub
coheigea merged PR #313: URL: https://github.com/apache/santuario-xml-security-java/pull/313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

Re: [PR] Bump commons-codec:commons-codec from 1.16.1 to 1.17.0 [santuario-xml-security-java]

2024-04-29 Thread via GitHub
coheigea merged PR #316: URL: https://github.com/apache/santuario-xml-security-java/pull/316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

Re: [PR] Bump xmlunit.version from 2.9.1 to 2.10.0 [santuario-xml-security-java]

2024-04-29 Thread via GitHub
coheigea merged PR #317: URL: https://github.com/apache/santuario-xml-security-java/pull/317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

[PR] Bump xmlunit.version from 2.9.1 to 2.10.0 [santuario-xml-security-java]

2024-04-28 Thread via GitHub
dependabot[bot] opened a new pull request, #317: URL: https://github.com/apache/santuario-xml-security-java/pull/317 Bumps `xmlunit.version` from 2.9.1 to 2.10.0. Updates `org.xmlunit:xmlunit-core` from 2.9.1 to 2.10.0 Release notes Sourced from https://github.com/xmlunit/xmlunit

[PR] Bump commons-codec:commons-codec from 1.16.1 to 1.17.0 [santuario-xml-security-java]

2024-04-28 Thread via GitHub
dependabot[bot] opened a new pull request, #316: URL: https://github.com/apache/santuario-xml-security-java/pull/316 Bumps [commons-codec:commons-codec](https://github.com/apache/commons-codec) from 1.16.1 to 1.17.0. Changelog Sourced from https://github.com/apache/commons-codec/bl

[PR] Bump com.google.errorprone:error_prone_core from 2.26.1 to 2.27.0 [santuario-xml-security-java]

2024-04-28 Thread via GitHub
dependabot[bot] opened a new pull request, #315: URL: https://github.com/apache/santuario-xml-security-java/pull/315 Bumps [com.google.errorprone:error_prone_core](https://github.com/google/error-prone) from 2.26.1 to 2.27.0. Release notes Sourced from https://github.com/google/er

[PR] Bump actions/upload-artifact from 4.3.2 to 4.3.3 [santuario-xml-security-java]

2024-04-28 Thread via GitHub
dependabot[bot] opened a new pull request, #314: URL: https://github.com/apache/santuario-xml-security-java/pull/314 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.2 to 4.3.3. Release notes Sourced from https://github.com/actions/upload-artifac

[PR] Bump actions/checkout from 4.1.3 to 4.1.4 [santuario-xml-security-java]

2024-04-28 Thread via GitHub
dependabot[bot] opened a new pull request, #313: URL: https://github.com/apache/santuario-xml-security-java/pull/313 Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.3 to 4.1.4. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/

Re: [PR] Implementation of the HKDF derivation function [santuario-xml-security-java]

2024-04-27 Thread via GitHub
jrihtarsic commented on code in PR #271: URL: https://github.com/apache/santuario-xml-security-java/pull/271#discussion_r1581874128 ## src/main/java/org/apache/xml/security/encryption/keys/content/derivedKey/KeyDerivationMethodImpl.java: ## @@ -71,29 +73,43 @@ public String get

Re: [PR] Implementation of the HKDF derivation function [santuario-xml-security-java]

2024-04-27 Thread via GitHub
jrihtarsic commented on code in PR #271: URL: https://github.com/apache/santuario-xml-security-java/pull/271#discussion_r1581874128 ## src/main/java/org/apache/xml/security/encryption/keys/content/derivedKey/KeyDerivationMethodImpl.java: ## @@ -71,29 +73,43 @@ public String get

Re: [PR] Implementation of the HKDF derivation function [santuario-xml-security-java]

2024-04-27 Thread via GitHub
jrihtarsic commented on code in PR #271: URL: https://github.com/apache/santuario-xml-security-java/pull/271#discussion_r1581872323 ## src/main/java/org/apache/xml/security/encryption/keys/content/derivedKey/HKDF.java: ## @@ -0,0 +1,177 @@ +/** + * Licensed to the Apache Softwa

Re: [PR] Implementation of the HKDF derivation function [santuario-xml-security-java]

2024-04-27 Thread via GitHub
jrihtarsic commented on code in PR #271: URL: https://github.com/apache/santuario-xml-security-java/pull/271#discussion_r1581872304 ## src/main/java/org/apache/xml/security/encryption/keys/content/derivedKey/HKDF.java: ## @@ -0,0 +1,177 @@ +/** + * Licensed to the Apache Softwa

Re: [PR] Implementation of the HKDF derivation function [santuario-xml-security-java]

2024-04-27 Thread via GitHub
jrihtarsic commented on code in PR #271: URL: https://github.com/apache/santuario-xml-security-java/pull/271#discussion_r1581872000 ## src/main/java/org/apache/xml/security/encryption/params/HKDFParams.java: ## @@ -0,0 +1,76 @@ +/** + * Licensed to the Apache Software Foundatio

Re: [PR] Implementation of the HKDF derivation function [santuario-xml-security-java]

2024-04-27 Thread via GitHub
jrihtarsic commented on code in PR #271: URL: https://github.com/apache/santuario-xml-security-java/pull/271#discussion_r1581871542 ## src/main/java/org/apache/xml/security/utils/KeyUtils.java: ## @@ -248,7 +246,6 @@ public static int getAESKeyBitSizeForWrapAlgorithm(String ke

Re: [PR] Implementation of the HKDF derivation function [santuario-xml-security-java]

2024-04-27 Thread via GitHub
jrihtarsic commented on code in PR #271: URL: https://github.com/apache/santuario-xml-security-java/pull/271#discussion_r1581871338 ## src/main/java/org/apache/xml/security/encryption/keys/content/derivedKey/KeyDerivationMethodImpl.java: ## @@ -71,29 +73,43 @@ public String get

Re: [PR] Implementation of the HKDF derivation function [santuario-xml-security-java]

2024-04-27 Thread via GitHub
jrihtarsic commented on code in PR #271: URL: https://github.com/apache/santuario-xml-security-java/pull/271#discussion_r1581870899 ## src/main/java/org/apache/xml/security/encryption/KeyDerivationMethod.java: ## @@ -19,10 +19,15 @@ package org.apache.xml.security.encryption

Re: [PR] Add brainpool curves for EC key generation/cypher (main branch) [santuario-xml-security-java]

2024-04-25 Thread via GitHub
seanjmullan commented on code in PR #293: URL: https://github.com/apache/santuario-xml-security-java/pull/293#discussion_r1579643152 ## src/test/java/org/apache/xml/security/test/dom/encryption/XMLCipherBrainpoolTest.java: ## @@ -0,0 +1,247 @@ +/** + * Licensed to the Apache So

Re: [PR] Add brainpool curves for EC key generation/cypher (main branch) [santuario-xml-security-java]

2024-04-25 Thread via GitHub
seanjmullan commented on PR #293: URL: https://github.com/apache/santuario-xml-security-java/pull/293#issuecomment-2077122293 It would be nice to define the curves in one place. Right now they are duplicated in both DOMKeyValue and ECDSAUtils. If you have time, please consider it. -- Th

Re: [PR] Implementation of the HKDF derivation function [santuario-xml-security-java]

2024-04-23 Thread via GitHub
jrihtarsic commented on code in PR #271: URL: https://github.com/apache/santuario-xml-security-java/pull/271#discussion_r1576280611 ## src/main/java/org/apache/xml/security/encryption/XMLCipherUtil.java: ## @@ -140,7 +140,7 @@ public static OAEPParameterSpec constructOAEPParame

Re: [PR] Bump org.bouncycastle:bcprov-jdk18on from 1.78 to 1.78.1 [santuario-xml-security-java]

2024-04-23 Thread via GitHub
coheigea merged PR #310: URL: https://github.com/apache/santuario-xml-security-java/pull/310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

Re: [PR] Bump actions/checkout from 4.1.2 to 4.1.3 [santuario-xml-security-java]

2024-04-23 Thread via GitHub
coheigea merged PR #311: URL: https://github.com/apache/santuario-xml-security-java/pull/311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

Re: [PR] Bump actions/upload-artifact from 4.3.1 to 4.3.2 [santuario-xml-security-java]

2024-04-23 Thread via GitHub
coheigea merged PR #312: URL: https://github.com/apache/santuario-xml-security-java/pull/312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

Re: [PR] Implementation of the HKDF derivation function [santuario-xml-security-java]

2024-04-23 Thread via GitHub
jrihtarsic commented on code in PR #271: URL: https://github.com/apache/santuario-xml-security-java/pull/271#discussion_r1576234627 ## src/main/java/org/apache/xml/security/encryption/keys/content/derivedKey/HKDF.java: ## @@ -0,0 +1,177 @@ +/** + * Licensed to the Apache Softwa

Re: [PR] Implementation of the HKDF derivation function [santuario-xml-security-java]

2024-04-23 Thread via GitHub
seanjmullan commented on code in PR #271: URL: https://github.com/apache/santuario-xml-security-java/pull/271#discussion_r1576208433 ## src/main/java/org/apache/xml/security/encryption/XMLCipherUtil.java: ## @@ -140,7 +140,7 @@ public static OAEPParameterSpec constructOAEPParam

Re: [PR] Implementation of the HKDF derivation function [santuario-xml-security-java]

2024-04-23 Thread via GitHub
seanjmullan commented on code in PR #271: URL: https://github.com/apache/santuario-xml-security-java/pull/271#discussion_r1576158626 ## src/main/java/org/apache/xml/security/encryption/keys/content/derivedKey/HKDF.java: ## @@ -0,0 +1,177 @@ +/** + * Licensed to the Apache Softw

Re: [PR] Implementation of the HKDF derivation function [santuario-xml-security-java]

2024-04-22 Thread via GitHub
jrihtarsic commented on code in PR #271: URL: https://github.com/apache/santuario-xml-security-java/pull/271#discussion_r1575668885 ## src/main/java/org/apache/xml/security/encryption/XMLCipherUtil.java: ## @@ -140,7 +140,7 @@ public static OAEPParameterSpec constructOAEPParame

Re: [PR] Implementation of the HKDF derivation function [santuario-xml-security-java]

2024-04-22 Thread via GitHub
seanjmullan commented on code in PR #271: URL: https://github.com/apache/santuario-xml-security-java/pull/271#discussion_r1575198060 ## src/main/java/org/apache/xml/security/encryption/KeyDerivationMethod.java: ## @@ -38,9 +43,21 @@ public interface KeyDerivationMethod {

[PR] Bump actions/upload-artifact from 4.3.1 to 4.3.2 [santuario-xml-security-java]

2024-04-21 Thread via GitHub
dependabot[bot] opened a new pull request, #312: URL: https://github.com/apache/santuario-xml-security-java/pull/312 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.1 to 4.3.2. Release notes Sourced from https://github.com/actions/upload-artifac

[PR] Bump actions/checkout from 4.1.2 to 4.1.3 [santuario-xml-security-java]

2024-04-21 Thread via GitHub
dependabot[bot] opened a new pull request, #311: URL: https://github.com/apache/santuario-xml-security-java/pull/311 Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.2 to 4.1.3. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/

[PR] Bump org.bouncycastle:bcprov-jdk18on from 1.78 to 1.78.1 [santuario-xml-security-java]

2024-04-18 Thread via GitHub
dependabot[bot] opened a new pull request, #310: URL: https://github.com/apache/santuario-xml-security-java/pull/310 Bumps [org.bouncycastle:bcprov-jdk18on](https://github.com/bcgit/bc-java) from 1.78 to 1.78.1. Commits See full diff in https://github.com/bcgit/bc-java/commits"

Re: [PR] Bump org.apache:apache from 31 to 32 [santuario-xml-security-java]

2024-04-17 Thread via GitHub
coheigea merged PR #309: URL: https://github.com/apache/santuario-xml-security-java/pull/309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

Re: [PR] [SANTUIARIO-614] Tests for the EC Brainpool key types [santuario-xml-security-java]

2024-04-17 Thread via GitHub
jrihtarsic commented on PR #298: URL: https://github.com/apache/santuario-xml-security-java/pull/298#issuecomment-2060774819 @coheigea, I am not sure if this helps, but I updated the instructions for generating certificates, now "the instruction" is using openssl because java/keytool doesn

[PR] Bump org.apache:apache from 31 to 32 [santuario-xml-security-java]

2024-04-16 Thread via GitHub
dependabot[bot] opened a new pull request, #309: URL: https://github.com/apache/santuario-xml-security-java/pull/309 Bumps [org.apache:apache](https://github.com/apache/maven-apache-parent) from 31 to 32. Release notes Sourced from https://github.com/apache/maven-apache-parent/rele

Re: [PR] Bump org.slf4j:slf4j-jdk14 from 2.0.12 to 2.0.13 [santuario-xml-security-java]

2024-04-15 Thread via GitHub
coheigea merged PR #308: URL: https://github.com/apache/santuario-xml-security-java/pull/308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

[PR] Bump org.slf4j:slf4j-jdk14 from 2.0.12 to 2.0.13 [santuario-xml-security-java]

2024-04-14 Thread via GitHub
dependabot[bot] opened a new pull request, #308: URL: https://github.com/apache/santuario-xml-security-java/pull/308 Bumps org.slf4j:slf4j-jdk14 from 2.0.12 to 2.0.13. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-

Re: [PR] [SANTUARIO-616] enable manual decryption of the EncryptedKey with KeyAgreement [santuario-xml-security-java]

2024-04-12 Thread via GitHub
seanjmullan commented on PR #305: URL: https://github.com/apache/santuario-xml-security-java/pull/305#issuecomment-2052516342 > LGTM. @seanjmullan please take a look Sorry been busy with work, etc so the *earliest* I can get to this and other reviews that are pending my review is end

Re: [PR] [SANTUARIO-616] enable manual decryption of the EncryptedKey with KeyAgreement [santuario-xml-security-java]

2024-04-12 Thread via GitHub
jrihtarsic commented on PR #305: URL: https://github.com/apache/santuario-xml-security-java/pull/305#issuecomment-2051938393 The conflicts are resolved now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] [SANTUIARIO-614] Tests for the EC Brainpool key types [santuario-xml-security-java]

2024-04-12 Thread via GitHub
jrihtarsic commented on PR #298: URL: https://github.com/apache/santuario-xml-security-java/pull/298#issuecomment-2051892186 @coheigea The new tests are carried out using the identical "test pattern" employed for other key types". And these tests uses the certificates, not just the keys .

Re: [PR] [SANTUARIO-617] remove mgf element in case of rsa-oaep-mgf1p [santuario-xml-security-java]

2024-04-11 Thread via GitHub
coheigea merged PR #306: URL: https://github.com/apache/santuario-xml-security-java/pull/306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

Re: [PR] Bump org.bouncycastle:bcprov-jdk18on from 1.77 to 1.78 [santuario-xml-security-java]

2024-04-08 Thread via GitHub
coheigea merged PR #307: URL: https://github.com/apache/santuario-xml-security-java/pull/307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

Re: [PR] [SANTUARIO-611] Add support of ECDSA with SHA3 algorithms [santuario-xml-security-java]

2024-04-08 Thread via GitHub
coheigea merged PR #302: URL: https://github.com/apache/santuario-xml-security-java/pull/302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

[PR] Bump org.bouncycastle:bcprov-jdk18on from 1.77 to 1.78 [santuario-xml-security-java]

2024-04-07 Thread via GitHub
dependabot[bot] opened a new pull request, #307: URL: https://github.com/apache/santuario-xml-security-java/pull/307 Bumps [org.bouncycastle:bcprov-jdk18on](https://github.com/bcgit/bc-java) from 1.77 to 1.78. Changelog Sourced from https://github.com/bcgit/bc-java/blob/main/docs/r

[PR] [SANTUARIO-617] remove mgf element in case of rsa-oaep-mgf1p [santuario-xml-security-java]

2024-04-06 Thread via GitHub
jrihtarsic opened a new pull request, #306: URL: https://github.com/apache/santuario-xml-security-java/pull/306 sanuario/xml library have several option to created DOM structure or to serialize EncryptionMethod as example: XMLCipher.newEncryptionMethod(Element element) { XMLCipher.

Re: [PR] Bump com.fasterxml.woodstox:woodstox-core from 6.6.1 to 6.6.2 [santuario-xml-security-java]

2024-04-04 Thread via GitHub
coheigea merged PR #303: URL: https://github.com/apache/santuario-xml-security-java/pull/303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

Re: [PR] Bump org.jacoco:jacoco-maven-plugin from 0.8.11 to 0.8.12 [santuario-xml-security-java]

2024-04-04 Thread via GitHub
coheigea merged PR #304: URL: https://github.com/apache/santuario-xml-security-java/pull/304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

[PR] Bump org.jacoco:jacoco-maven-plugin from 0.8.11 to 0.8.12 [santuario-xml-security-java]

2024-04-02 Thread via GitHub
dependabot[bot] opened a new pull request, #304: URL: https://github.com/apache/santuario-xml-security-java/pull/304 Bumps [org.jacoco:jacoco-maven-plugin](https://github.com/jacoco/jacoco) from 0.8.11 to 0.8.12. Release notes Sourced from https://github.com/jacoco/jacoco/releases"

Re: [PR] [SANTUARIO-611] Add support of ECDSA with SHA3 algorithms [santuario-xml-security-java]

2024-03-28 Thread via GitHub
jrihtarsic commented on PR #302: URL: https://github.com/apache/santuario-xml-security-java/pull/302#issuecomment-2024985746 Sure, I added them now (I should already know this by now :) ) For the future tests I created an abstract class `XMLSignatureAbstract` with methods ``` doSi

[PR] Bump com.fasterxml.woodstox:woodstox-core from 6.6.1 to 6.6.2 [santuario-xml-security-java]

2024-03-27 Thread via GitHub
dependabot[bot] opened a new pull request, #303: URL: https://github.com/apache/santuario-xml-security-java/pull/303 Bumps [com.fasterxml.woodstox:woodstox-core](https://github.com/FasterXML/woodstox) from 6.6.1 to 6.6.2. Commits https://github.com/FasterXML/woodstox/commit/3b

Re: [PR] Implementation of the HKDF derivation function [santuario-xml-security-java]

2024-03-25 Thread via GitHub
jrihtarsic commented on code in PR #271: URL: https://github.com/apache/santuario-xml-security-java/pull/271#discussion_r1537411909 ## src/main/java/org/apache/xml/security/resource/xmlsecurity_en.properties: ## @@ -111,7 +111,9 @@ KeyStore.registerStore.register = Registration

[PR] [SANTUARIO-611] Add support of ECDSA with SHA3 algorithms [santuario-xml-security-java]

2024-03-25 Thread via GitHub
jrihtarsic opened a new pull request, #302: URL: https://github.com/apache/santuario-xml-security-java/pull/302 Added support for ECDSA SHA3 signatures: For details see the ticker: [SANTUARIO-611](https://issues.apache.org/jira/browse/SANTUARIO-611) -- This is an automated

Re: [PR] Bump org.cyclonedx:cyclonedx-maven-plugin from 2.7.11 to 2.8.0 [santuario-xml-security-java]

2024-03-25 Thread via GitHub
coheigea merged PR #301: URL: https://github.com/apache/santuario-xml-security-java/pull/301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

Re: [PR] Bump actions/cache from 4.0.1 to 4.0.2 [santuario-xml-security-java]

2024-03-25 Thread via GitHub
coheigea merged PR #300: URL: https://github.com/apache/santuario-xml-security-java/pull/300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

[PR] Bump org.cyclonedx:cyclonedx-maven-plugin from 2.7.11 to 2.8.0 [santuario-xml-security-java]

2024-03-24 Thread via GitHub
dependabot[bot] opened a new pull request, #301: URL: https://github.com/apache/santuario-xml-security-java/pull/301 Bumps [org.cyclonedx:cyclonedx-maven-plugin](https://github.com/CycloneDX/cyclonedx-maven-plugin) from 2.7.11 to 2.8.0. Release notes Sourced from https://github.co

[PR] Bump actions/cache from 4.0.1 to 4.0.2 [santuario-xml-security-java]

2024-03-24 Thread via GitHub
dependabot[bot] opened a new pull request, #300: URL: https://github.com/apache/santuario-xml-security-java/pull/300 Bumps [actions/cache](https://github.com/actions/cache) from 4.0.1 to 4.0.2. Release notes Sourced from https://github.com/actions/cache/releases";>actions/cache's r

[PR] [SANTUARIO-615] Implementation pre-post processing extension with xades (basic) example. [santuario-xml-security-java]

2024-03-24 Thread via GitHub
jrihtarsic opened a new pull request, #299: URL: https://github.com/apache/santuario-xml-security-java/pull/299 The purpose of this PR is to present the proposals [SANTUARIO-615] for the pre/post processor for the signatures. The use case is the request for XAdES support as requested i

[PR] [SANTUIARIO-614] Tests for the EC Brainpool key types [santuario-xml-security-java]

2024-03-22 Thread via GitHub
jrihtarsic opened a new pull request, #298: URL: https://github.com/apache/santuario-xml-security-java/pull/298 The purpose of the contributions is to verify (and implement unit tests) for signing and encryption with the EC Brainpool key types. For details see the PR #293 and [SAN

Re: [PR] Add brainpool curves for EC key generation/cypher (main branch) [santuario-xml-security-java]

2024-03-21 Thread via GitHub
jrihtarsic commented on PR #293: URL: https://github.com/apache/santuario-xml-security-java/pull/293#issuecomment-2014462177 @yklymenko @seanjmullan I can do that. I have already internal task to do verify it for eDelivery AS4 profile and I can implement also the required tests to s

Re: [PR] Implementation of the HKDF derivation function [santuario-xml-security-java]

2024-03-21 Thread via GitHub
jrihtarsic commented on PR #271: URL: https://github.com/apache/santuario-xml-security-java/pull/271#issuecomment-2014385650 @seanjmullan Thank you for checking it. And no worries about time. I'd rather see my code thoroughly vetted by a security expert than to skip/miss some security iss

Re: [PR] Implementation of the HKDF derivation function [santuario-xml-security-java]

2024-03-21 Thread via GitHub
seanjmullan commented on code in PR #271: URL: https://github.com/apache/santuario-xml-security-java/pull/271#discussion_r1534523455 ## src/main/java/org/apache/xml/security/resource/xmlsecurity_en.properties: ## @@ -111,7 +111,9 @@ KeyStore.registerStore.register = Registratio

Re: [PR] Implementation of the HKDF derivation function [santuario-xml-security-java]

2024-03-21 Thread via GitHub
seanjmullan commented on code in PR #271: URL: https://github.com/apache/santuario-xml-security-java/pull/271#discussion_r1534523455 ## src/main/java/org/apache/xml/security/resource/xmlsecurity_en.properties: ## @@ -111,7 +111,9 @@ KeyStore.registerStore.register = Registratio

Re: [PR] Add brainpool curves for EC key generation/cypher (main branch) [santuario-xml-security-java]

2024-03-21 Thread via GitHub
seanjmullan commented on PR #293: URL: https://github.com/apache/santuario-xml-security-java/pull/293#issuecomment-2013323175 > > > > Looks fine. It would be nice if there was also a test using the `javax.xml.crypto.dsig` API. > > > > > > > > > @seanjmullan you mean, something li

Re: [PR] Add brainpool curves for EC key generation/cypher (main branch) [santuario-xml-security-java]

2024-03-21 Thread via GitHub
coheigea merged PR #293: URL: https://github.com/apache/santuario-xml-security-java/pull/293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

Re: [PR] [SANTUARIO-613] Remove DH KeyType from the KeyUtils.KeyType enumeration [santuario-xml-security-java]

2024-03-21 Thread via GitHub
coheigea merged PR #297: URL: https://github.com/apache/santuario-xml-security-java/pull/297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

Re: [PR] Implementation of the HKDF derivation function [santuario-xml-security-java]

2024-03-21 Thread via GitHub
jrihtarsic commented on PR #271: URL: https://github.com/apache/santuario-xml-security-java/pull/271#issuecomment-2011501924 I reverted the "cleaning of the code" (empty lines) from commit [PR updates (docs and clean empty lines)](https://github.com/apache/santuario-xml-security-java/pull/

Re: [PR] Implementation of the HKDF derivation function [santuario-xml-security-java]

2024-03-21 Thread via GitHub
coheigea commented on PR #271: URL: https://github.com/apache/santuario-xml-security-java/pull/271#issuecomment-2011343108 @jrihtarsic Can you remove the whitespace changes in this PR? It makes it difficult to get to the actual changes -- This is an automated message from the Apache Git

Re: [PR] Implementation of the HKDF derivation function [santuario-xml-security-java]

2024-03-21 Thread via GitHub
coheigea commented on PR #271: URL: https://github.com/apache/santuario-xml-security-java/pull/271#issuecomment-2011342439 @seanjmullan Just a reminder please, as this PR blocks another Pr in WSS4J -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] Add brainpool curves for EC key generation/cypher (main branch) [santuario-xml-security-java]

2024-03-20 Thread via GitHub
jrihtarsic commented on PR #293: URL: https://github.com/apache/santuario-xml-security-java/pull/293#issuecomment-2011273409 @yklymenko, you have a good point. To make it transparent I created now the SANTUARIO-613 and the PR #297 -- This is an automated message from the Apache Git S

[PR] [SANTUARIO-613] Remove DH KeyType from the KeyUtils.KeyType enumeration [santuario-xml-security-java]

2024-03-20 Thread via GitHub
jrihtarsic opened a new pull request, #297: URL: https://github.com/apache/santuario-xml-security-java/pull/297 Remove DH KeyType from the KeyUtils.KeyType enumeration. For details see the: https://issues.apache.org/jira/browse/SANTUARIO-613 and https://github.com/apache/santuario-x

Re: [PR] Add brainpool curves for EC key generation/cypher [santuario-xml-security-java]

2024-03-20 Thread via GitHub
yklymenko closed pull request #292: Add brainpool curves for EC key generation/cypher URL: https://github.com/apache/santuario-xml-security-java/pull/292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Add brainpool curves for EC key generation/cypher (main branch) [santuario-xml-security-java]

2024-03-20 Thread via GitHub
yklymenko commented on PR #293: URL: https://github.com/apache/santuario-xml-security-java/pull/293#issuecomment-2010377978 > My suggestion is To remove DH("DH", "PKCS #3", KeyAlgorithmType.DH, "1.2.840.113549.1.3.1"), From KeyType > > The Diffie-Hellman key agreement using RSA keys

Re: [PR] Add brainpool curves for EC key generation/cypher (main branch) [santuario-xml-security-java]

2024-03-20 Thread via GitHub
jrihtarsic commented on PR #293: URL: https://github.com/apache/santuario-xml-security-java/pull/293#issuecomment-2009015198 My suggestion is To remove DH("DH", "PKCS #3", KeyAlgorithmType.DH, "1.2.840.113549.1.3.1"), From KeyType The Diffie-Hellman key agreement using RSA

Re: [PR] Add brainpool curves for EC key generation/cypher (main branch) [santuario-xml-security-java]

2024-03-19 Thread via GitHub
jrihtarsic commented on PR #293: URL: https://github.com/apache/santuario-xml-security-java/pull/293#issuecomment-2008715237 @yklymenko good catch: Looks like SunJCE returns different OID for generated (and then encoded) keys with algorithm name 'DH' than the BouncyCastle: The r

Re: [PR] Add brainpool curves for EC key generation/cypher (main branch) [santuario-xml-security-java]

2024-03-19 Thread via GitHub
yklymenko commented on PR #293: URL: https://github.com/apache/santuario-xml-security-java/pull/293#issuecomment-2008161675 > > > Looks fine. It would be nice if there was also a test using the `javax.xml.crypto.dsig` API. > > > > > > @seanjmullan you mean, something like org.ap

Re: [PR] Add brainpool curves for EC key generation/cypher (main branch) [santuario-xml-security-java]

2024-03-19 Thread via GitHub
seanjmullan commented on PR #293: URL: https://github.com/apache/santuario-xml-security-java/pull/293#issuecomment-2008003341 > > Looks fine. It would be nice if there was also a test using the `javax.xml.crypto.dsig` API. > > @seanjmullan you mean, something like org.apache.xml.sec

Re: [PR] Add brainpool curves for EC key generation/cypher (main branch) [santuario-xml-security-java]

2024-03-19 Thread via GitHub
yklymenko commented on PR #293: URL: https://github.com/apache/santuario-xml-security-java/pull/293#issuecomment-2007995796 > Looks fine. It would be nice if there was also a test using the `javax.xml.crypto.dsig` API. @seanjmullan you mean, something like org.apache.xml.security.te

Re: [PR] Add brainpool curves for EC key generation/cypher (main branch) [santuario-xml-security-java]

2024-03-19 Thread via GitHub
seanjmullan commented on PR #293: URL: https://github.com/apache/santuario-xml-security-java/pull/293#issuecomment-2007103696 Looks fine. It would be nice if there was also a test using the `javax.xml.crypto.dsig` API. -- This is an automated message from the Apache Git Service. To respo

Re: [PR] Add brainpool curves for EC key generation/cypher (main branch) [santuario-xml-security-java]

2024-03-19 Thread via GitHub
coheigea commented on PR #293: URL: https://github.com/apache/santuario-xml-security-java/pull/293#issuecomment-2006565953 Looks fine to me. @seanjmullan can you review please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Bump actions/setup-java from 4.1.0 to 4.2.1 [santuario-xml-security-java]

2024-03-19 Thread via GitHub
coheigea merged PR #294: URL: https://github.com/apache/santuario-xml-security-java/pull/294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

Re: [PR] Bump actions/checkout from 4.1.1 to 4.1.2 [santuario-xml-security-java]

2024-03-19 Thread via GitHub
coheigea merged PR #295: URL: https://github.com/apache/santuario-xml-security-java/pull/295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

Re: [PR] Bump com.google.errorprone:error_prone_core from 2.25.0 to 2.26.1 [santuario-xml-security-java]

2024-03-19 Thread via GitHub
coheigea merged PR #291: URL: https://github.com/apache/santuario-xml-security-java/pull/291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

Re: [PR] Bump org.apache.maven.plugins:maven-compiler-plugin from 3.12.1 to 3.13.0 [santuario-xml-security-java]

2024-03-19 Thread via GitHub
coheigea merged PR #296: URL: https://github.com/apache/santuario-xml-security-java/pull/296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

[PR] Bump org.apache.maven.plugins:maven-compiler-plugin from 3.12.1 to 3.13.0 [santuario-xml-security-java]

2024-03-18 Thread via GitHub
dependabot[bot] opened a new pull request, #296: URL: https://github.com/apache/santuario-xml-security-java/pull/296 Bumps [org.apache.maven.plugins:maven-compiler-plugin](https://github.com/apache/maven-compiler-plugin) from 3.12.1 to 3.13.0. Release notes Sourced from https://gi

[PR] Bump actions/checkout from 4.1.1 to 4.1.2 [santuario-xml-security-java]

2024-03-17 Thread via GitHub
dependabot[bot] opened a new pull request, #295: URL: https://github.com/apache/santuario-xml-security-java/pull/295 Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.1 to 4.1.2. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/

[PR] Bump actions/setup-java from 4.1.0 to 4.2.1 [santuario-xml-security-java]

2024-03-17 Thread via GitHub
dependabot[bot] opened a new pull request, #294: URL: https://github.com/apache/santuario-xml-security-java/pull/294 Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4.1.0 to 4.2.1. Release notes Sourced from https://github.com/actions/setup-java/releases";>ac

[PR] Add brainpool curves [santuario-xml-security-java]

2024-03-15 Thread via GitHub
yklymenko opened a new pull request, #293: URL: https://github.com/apache/santuario-xml-security-java/pull/293 The protocol for the communication between energy market participants in Germany enforce to use Brainpool P256r1 elliptic curve for signing and encryption of the soap parts (header

<    1   2   3   4   5   6   7   8   9   10   >