Re: Review Request 50474: SENTRY-1404: Use the new INodeAttributesProvider API in sentry-hdfs

2016-07-29 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50474/#review144171 --- Ship it! Ship It! - Anne Yu On July 29, 2016, 7:41 p.m., Hao

Re: Review Request 50474: SENTRY-1404: Use the new INodeAttributesProvider API in sentry-hdfs

2016-07-29 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50474/#review144170 --- sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/

Re: Review Request 50611: Sentry HA Test: programmatic failover, validate privileges before and afterwards.

2016-07-29 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50611/ --- (Updated July 29, 2016, 8:03 p.m.) Review request for sentry, Hao Hao and Sravy

Re: Review Request 50182: Sentry-1371: Rework Sentry start up and Hive state fetch

2016-07-29 Thread Sravya Tirukkovalur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50182/#review144165 --- Seems like we need to not block Sentry startup for the sake of HMS

Re: Review Request 50578: Sentry-1411: The sentry client should retry RPCs if it gets a SentryStandbyException

2016-07-29 Thread Hao Hao
> On July 28, 2016, 10:18 p.m., Sravya Tirukkovalur wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/PoolClientInvocationHandler.java, > > lines 273-278 > > > > > > It is

Re: Review Request 50474: SENTRY-1404: Use the new INodeAttributesProvider API in sentry-hdfs

2016-07-29 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50474/ --- (Updated July 29, 2016, 7:41 p.m.) Review request for sentry and Sravya Tirukko

Re: Review Request 50474: SENTRY-1404: Use the new INodeAttributesProvider API in sentry-hdfs

2016-07-29 Thread Hao Hao
> On July 29, 2016, 5:56 p.m., Anne Yu wrote: > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryINodeAttributesProvider.java, > > line 156 > > > > > > Will it be possible prefixP

Re: Review Request 50182: Sentry-1371: Rework Sentry start up and Hive state fetch

2016-07-29 Thread Sravya Tirukkovalur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50182/#review144152 --- sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hd

Re: Review Request 50578: Sentry-1411: The sentry client should retry RPCs if it gets a SentryStandbyException

2016-07-29 Thread Sravya Tirukkovalur
> On July 28, 2016, 10:18 p.m., Sravya Tirukkovalur wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/PoolClientInvocationHandler.java, > > lines 273-278 > > > > > > It is

Re: Review Request 50578: Sentry-1411: The sentry client should retry RPCs if it gets a SentryStandbyException

2016-07-29 Thread Hao Hao
> On July 29, 2016, 5:17 p.m., Rahul Sharma wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestPoolClientInvocationHandler.java, > > line 26 > > > > > > Can check out if

Re: Review Request 50611: Sentry HA Test: programmatic failover, validate privileges before and afterwards.

2016-07-29 Thread Anne Yu
> On July 29, 2016, 6:26 p.m., Rahul Sharma wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestProgrammaticFailover.java, > > lines 117-120 > > > > > > how is the boolean retu

Re: Review Request 50611: Sentry HA Test: programmatic failover, validate privileges before and afterwards.

2016-07-29 Thread Rahul Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50611/#review144144 --- sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/te

Re: Review Request 50474: SENTRY-1404: Use the new INodeAttributesProvider API in sentry-hdfs

2016-07-29 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50474/#review144051 --- Thanks Haohao. Left some minor comments here. sentry-hdfs/sentry

Review Request 50611: Sentry HA Test: programmatic failover, validate privileges before and afterwards.

2016-07-29 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50611/ --- Review request for sentry, Hao Hao and Sravya Tirukkovalur. Bugs: SENTRY-1423

Re: Review Request 50578: Sentry-1411: The sentry client should retry RPCs if it gets a SentryStandbyException

2016-07-29 Thread Rahul Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50578/#review144126 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr