Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

2016-10-25 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51449/#review153848 --- This is pretty big patch, it would be better to avoid unrelated

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

2016-10-25 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51449/#review153841 ---

Re: Review Request 53175: SENTRY-1501: Add option to use non pool model for sentry client

2016-10-25 Thread Li Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53175/ --- (Updated Oct. 25, 2016, 10:25 p.m.) Review request for sentry, Alexander

Re: Review Request 53175: SENTRY-1501: Add option to use non pool model for sentry client

2016-10-25 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53175/#review153827 --- Thanks Li! The patch looks good. Could you please comment why

Re: Apache Sentry in Maven Central

2016-10-25 Thread Alexander Kolbasov
Thanks Colm! On Tue, Oct 25, 2016 at 9:46 AM Lenni Kuff wrote: > Excellent, thanks Colm. > > On Tue, Oct 25, 2016 at 9:13 AM, Colm O hEigeartaigh > wrote: > > > Hi all, > > > > I've uploaded the Sentry artifacts for 1.7.0 to the Maven staging repo >

Re: Review Request 53175: SENTRY-1501: Add option to use non pool model for sentry client

2016-10-25 Thread Li Li
> On Oct. 25, 2016, 10:06 p.m., Hao Hao wrote: > > Thanks Li! The patch looks good. Could you please comment why current pool > > model does not manage the opening connections very well. sure. I will add a comment - Li --- This is an

Re: Review Request 53175: SENTRY-1501: Add option to use non pool model for sentry client

2016-10-25 Thread Anne Yu
> On Oct. 25, 2016, 9:07 p.m., Anne Yu wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientFactory.java, > > line 35 > > > > > > This is very nice. Maybe

Re: Review Request 53175: SENTRY-1501: Add option to use non pool model for sentry client

2016-10-25 Thread Li Li
> On Oct. 25, 2016, 9:07 p.m., Anne Yu wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientFactory.java, > > line 35 > > > > > > This is very nice. Maybe

Re: Review Request 53175: SENTRY-1501: Add option to use non pool model for sentry client

2016-10-25 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53175/#review153822 ---

Review Request 53175: SENTRY-1501: Add option to use non pool model for sentry client

2016-10-25 Thread Li Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53175/ --- Review request for sentry, Alexander Kolbasov, Anne Yu, Hao Hao, Lenni Kuff,

Apache Sentry in Maven Central

2016-10-25 Thread Colm O hEigeartaigh
Hi all, I've uploaded the Sentry artifacts for 1.7.0 to the Maven staging repo and will promote them to Maven Central unless I hear any objections: https://repository.apache.org/content/repositories/orgapachesentry-1001/ I'll submit the pom changes I had to make as a patch soon. Colm. --