Re: Review Request 54464: SENTRY-1557: getRolesForGroups(), getRolesForUsers() does too many trips to the the DB

2016-12-07 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54464/ --- (Updated Dec. 8, 2016, 7:47 a.m.) Review request for sentry, Alexander Kolbasov

Re: Review Request 54464: SENTRY-1557: getRolesForGroups(), getRolesForUsers() does too many trips to the the DB

2016-12-07 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54464/ --- (Updated Dec. 8, 2016, 7:44 a.m.) Review request for sentry, Alexander Kolbasov

Re: Review Request 54464: SENTRY-1557: getRolesForGroups(), getRolesForUsers() does too many trips to the the DB

2016-12-07 Thread Vamsee Yarlagadda
> On Dec. 7, 2016, 9:15 p.m., kalyan kumar kalvagadda wrote: > > It's better to add some unit test each function that changes. Added a new test. - Vamsee --- This is an automatically generated e-mail. To reply, visit: https://reviews.ap

Sentry-jdk-1.7 - Build # 742 - Fixed

2016-12-07 Thread Apache Jenkins Server
The Apache Jenkins build system has built Sentry-jdk-1.7 (build #742) Status: Fixed Check console output at https://builds.apache.org/job/Sentry-jdk-1.7/742/ to view the results.

Re: Review Request 54464: SENTRY-1557: getRolesForGroups(), getRolesForUsers() does too many trips to the the DB

2016-12-07 Thread Vamsee Yarlagadda
> On Dec. 7, 2016, 9:46 p.m., Alexander Kolbasov wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > line 1258 > > > > > > It is neat

Re: Review Request 54338: SENTRY-1515: Cleanup exception handling in SentryStore

2016-12-07 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54338/ --- (Updated Dec. 7, 2016, 11:42 p.m.) Review request for sentry, Colin Ma, Hao Hao

Re: Review Request 54338: SENTRY-1515: Cleanup exception handling in SentryStore

2016-12-07 Thread Alexander Kolbasov
> On Dec. 5, 2016, 8:24 p.m., Vamsee Yarlagadda wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/UpdateForwarder.java, > > lines 188-194 > > > > > > A general question outside of this

Re: Review Request 54338: SENTRY-1515: Cleanup exception handling in SentryStore

2016-12-07 Thread Alexander Kolbasov
> On Dec. 5, 2016, 9:25 p.m., Vadim Spector wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/UpdateForwarder.java, > > line 79 > > > > > > do we still need ctors to be public, if we hav

Re: Review Request 54464: SENTRY-1557: getRolesForGroups(), getRolesForUsers() does too many trips to the the DB

2016-12-07 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54464/#review158405 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 54464: SENTRY-1557: getRolesForGroups(), getRolesForUsers() does too many trips to the the DB

2016-12-07 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54464/#review158397 --- It's better to add some unit test each function that changes. - k

Re: Show groups for a given role

2016-12-07 Thread Jan Hentschel
@Alex Thanks for the information. Unfortunately, we have several clusters running Kerberos. I opened SENTRY-1558 for this and will work on it with a colleague of mine. Best, Jan From: Alexander Kolbasov Reply-To: Date: Saturday, December 3, 2016 at 7:46 PM To: Subject: Re: Show groups