Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

2017-03-22 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57232/#review169817 ---

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

2017-03-22 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57232/ --- (Updated March 22, 2017, 11:08 p.m.) Review request for sentry. Repository:

Re: Review Request 56954: SENTRY-1639 Refactor the usage of configuration constants related to transport

2017-03-22 Thread kalyan kumar kalvagadda
> On March 11, 2017, 12:12 a.m., Alexander Kolbasov wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/exception/MissingConfigurationException.java > > Lines 24 (patched) > > > > > >

Re: Review Request 56954: SENTRY-1639 Refactor the usage of configuration constants related to transport

2017-03-22 Thread kalyan kumar kalvagadda
> On March 14, 2017, 3:10 a.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceClientDefaultImpl.java > > Line 118 (original), 125 (patched) > > > > >

Re: Review Request 56954: SENTRY-1639 Refactor the usage of configuration constants related to transport

2017-03-22 Thread kalyan kumar kalvagadda
> On March 13, 2017, 8:25 p.m., Vadim Spector wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceClientDefaultImpl.java > > Line 53 (original), 57 (patched) > > > > > >

Re: [DISCUSS] Merging Sentry HA branch with master

2017-03-22 Thread Sergio Pena
The usual way we do this in other projects is the 1st option. We can create a new JIRA for the merge, then submit the patch with the conflicts resolved, wait for tests, then commit it. Although the 2nd option looks easier if we only missing one commit, but I think we should avoid it just in case

Re: Review Request 57570: SENTRY-1644. Partition ACLs disappear after renaming Hive table with partitions

2017-03-22 Thread Lei Xu
> On March 14, 2017, 1:49 p.m., Hao Hao wrote: > > Can you add test cases in the intergation test as well, > > TestHDFSIntegrationAdvanced. To ensure cases such as for managed/unmanaged > > table we get expected output. > > Also, it looks like the tests are not all green. Would you mind take a

Re: Review Request 57570: SENTRY-1644. Partition ACLs disappear after renaming Hive table with partitions

2017-03-22 Thread Lei Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57570/ --- (Updated March 22, 2017, 2:27 p.m.) Review request for sentry, Alexander

[DISCUSS] Merging Sentry HA branch with master

2017-03-22 Thread Alexander Kolbasov
Hello, I would like to start the discussion on merging sentry-ha-redesign branch with master. As of now most of the changes from master are merged into sentry-ha-redesign. The major missing part is SENTRY-1205 (Refactor the code for sentry-provider-db and create sentry-service module) and