Re: Review Request 59031: SENTRY-1714 MetastorePlugin.java should quetly return from renameAuthzObject() when both paths are null

2017-05-08 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59031/#review174262 ---

Re: SQL changes for SENTRY-1726

2017-05-08 Thread Kalyan Cloudera
I see there is an issue. Let me think and get back. -kalyan > On May 8, 2017, at 7:11 PM, Kalyan Kumar Kalvagadda > wrote: > > > Even if HMSFollower is running in both the nodes, we can have simple logic in > HMSFollower to avoid processing duplicate notifications. >

Re: SQL changes for SENTRY-1726

2017-05-08 Thread Kalyan Kumar Kalvagadda
Even if HMSFollower is running in both the nodes, we can have simple logic in HMSFollower to avoid processing duplicate notifications. Before processing the notification, if a check is added to see if the new notification id is greater than the one stored in database. If not, we ignore the

Re: Review Request 58975: SENTRY-1669 HMSFollower should read current processed notification ID from database every time it runs

2017-05-08 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58975/#review174243 ---

Re: SQL changes for SENTRY-1726

2017-05-08 Thread Alexander Kolbasov
The major problem with read-modify-write approach is that it is difficult to handle the case with two writers trying to update the value at the same time. If you handle this by adding new rows and having the ID as the primary key, one writer will succeed and another will fail because the key

Re: Review Request 59058: SENTRY-1752 HMSFollower gets stuck once it fails to process a notification event

2017-05-08 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59058/#review174241 ---

Re: Review Request 59058: SENTRY-1752 HMSFollower gets stuck once it fails to process a notification event

2017-05-08 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59058/#review174239 --- I don't see how the fix would actually help - the only way for

Re: Review Request 59058: SENTRY-1752 HMSFollower gets stuck once it fails to process a notification event

2017-05-08 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59058/#review174227 ---

Re: Review Request 59031: SENTRY-1714 MetastorePlugin.java should quetly return from renameAuthzObject() when both paths are null

2017-05-08 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59031/#review174220 ---

Re: Review Request 58727: SENTRY-1708 Extend the current test classes to handle multiple sentry servers

2017-05-08 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58727/#review173643 ---

Re: Review Request 59058: SENTRY-1752 HMSFollower gets stuck once it fails to process a notification event

2017-05-08 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59058/#review174210 ---

Review Request 59058: SENTRY-1752 HMSFollower gets stuck once it fails to process a notification event

2017-05-08 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59058/ --- Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

2017-05-08 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/#review174176 --- Ship it! Ship It! - kalyan kumar kalvagadda On May 5, 2017,