Re: Review Request 59252: SENTRY-1758 Improve Sentry memory usage by interning object names

> On May 13, 2017, 1:56 a.m., Misha Dmitriev wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/FullUpdateInitializer.java > > Lines 449 (patched) > > > > > > You probably want to remove t

Re: Review Request 59252: SENTRY-1758 Improve Sentry memory usage by interning object names

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59252/#review174878 --- Fix it, then Ship it! Looks good to me, but as we discussed, th

Re: Review Request 59252: SENTRY-1758 Improve Sentry memory usage by interning object names

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59252/ --- (Updated May 13, 2017, 1:48 a.m.) Review request for sentry, Brian Towles, Mish

Re: Review Request 59241: SENTRY-1705: Do not start HMSFollower if Hive isn't configured

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59241/#review174877 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 59252: SENTRY-1758 Improve Sentry memory usage by interning object names

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59252/#review174876 --- The comments that I made in the first few occurrences of the poten

Review Request 59252: SENTRY-1758 Improve Sentry memory usage by interning object names

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59252/ --- Review request for sentry, Brian Towles, Misha Dmitriev, Hao Hao, kalyan kumar k

Re: Review Request 58975: SENTRY-1669 HMSFollower should read current processed notification ID from database every time it runs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58975/#review174868 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 59235: SENTRY-1765 CounterWait.update throw exception when input is old

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59235/#review174849 --- Ship it! Ship It! - Vamsee Yarlagadda On May 12, 2017, 5:45

Re: Review Request 59241: SENTRY-1705: Do not start HMSFollower if Hive isn't configured

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59241/ --- (Updated May 12, 2017, 7:49 p.m.) Review request for sentry, Alexander Kolbasov

Review Request 59241: SENTRY-1705: Do not start HMSFollower if Hive isn't configured

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59241/ --- Review request for sentry, Alexander Kolbasov, Brian Towles, Hao Hao, kalyan kum

Re: Review Request 59235: SENTRY-1765 CounterWait.update throw exception when input is old

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59235/#review174839 --- Ship it! Ship It! - kalyan kumar kalvagadda On May 12, 2017,

Re: Review Request 59235: SENTRY-1765 CounterWait.update throw exception when input is old

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59235/#review174835 --- Ship it! Ship It! - Na Li On May 12, 2017, 5:45 p.m., Alexan

Re: Review Request 58975: SENTRY-1669 HMSFollower should read current processed notification ID from database every time it runs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58975/#review174830 --- Ship it! Ship It! - Hao Hao On May 12, 2017, 5:38 p.m., kaly

Review Request 59235: SENTRY-1765 CounterWait.update throw exception when input is old

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59235/ --- Review request for sentry, Brian Towles, Hao Hao, kalyan kumar kalvagadda, Na Li

Re: Review Request 58975: SENTRY-1669 HMSFollower should read current processed notification ID from database every time it runs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58975/ --- (Updated May 12, 2017, 5:38 p.m.) Review request for sentry, Alexander Kolbasov

Re: Review Request 59212: SENTRY-1763 Fix the config string for server load balancing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59212/#review174814 --- Ship it! Ship It! - Alexander Kolbasov On May 11, 2017, 11:2

Re: Review Request 58975: SENTRY-1669 HMSFollower should read current processed notification ID from database every time it runs

> On May 12, 2017, 3:18 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 328 (patched) > > > > > > do we still need this line to wake

Re: Review Request 58727: SENTRY-1708 Extend the current test classes to handle multiple sentry servers

> On May 8, 2017, 7:48 p.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/SentryHdfsServiceIntegrationBase.java > > Line 62 (original), 59 (patched) > > > > > > When we run mul

Re: Review Request 59174: SENTRY-1761 Add test for concurrent HMS followers processing notifications

> On May 12, 2017, 3:28 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestConcurrentHMSFollowers.java > > Lines 144 (patched) > > > > > > waiting for 5000 se

Re: Review Request 58727: SENTRY-1708 Extend the current test classes to handle multiple sentry servers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58727/ --- (Updated May 12, 2017, 3:49 p.m.) Review request for sentry, Alexander Kolbasov

Re: Review Request 58727: SENTRY-1708 Extend the current test classes to handle multiple sentry servers

> On May 9, 2017, 12:35 a.m., Alexander Kolbasov wrote: > > sentry-tests/sentry-tests-kafka/src/test/java/org/apache/sentry/tests/e2e/kafka/AbstractKafkaSentryTestBase.java > > Lines 25 (patched) > > > > > > Please re

Re: Review Request 58976: SENTRY-1709 Avoid randomizing the servers at client side based on configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58976/#review174806 --- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/co

Re: Review Request 59212: SENTRY-1763 Fix the config string for server load balancing

> On May 12, 2017, 3:06 p.m., Na Li wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryClientTransportConstants.java > > Line 104 (original), 104 (patched) > > > > > >

Re: Review Request 59174: SENTRY-1761 Add test for concurrent HMS followers processing notifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59174/#review174798 --- sentry-provider/sentry-provider-db/src/test/java/org/apache/sentr

Re: Review Request 59120: SENTRY-1757: Avoid using local hive meta store using wrong configuration

> On May 10, 2017, 9:31 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 138 (patched) > > > > > > We have two cases her

Re: Review Request 59120: SENTRY-1757: Avoid using local hive meta store using wrong configuration

> On May 10, 2017, 9:31 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 138 (patched) > > > > > > We have two cases her

Re: Review Request 58975: SENTRY-1669 HMSFollower should read current processed notification ID from database every time it runs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58975/#review174796 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 59212: SENTRY-1763 Fix the config string for server load balancing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59212/#review174795 --- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/co

Re: [DISCUSS] Having an interactive chat account for Apache Sentry

Sasha, Some projects, such as Hive, use an IRC channel on the irc.freenode.net server. This should be free and unlimited. However, I would like to try Slack while the community is small. Btw, I'm not aware of any Apache infra for chat accounts. On Thu, May 11, 2017 at 6:26 PM, Alexander Kolbasov

Re: Review Request 59084: SENTRY-1516 - Add gpg configuration to the root pom to enable deployment to Maven Central

> On May 11, 2017, 4:25 p.m., Sergio Pena wrote: > > Colm, the changes look good. Just a quetion, how do I test this change > > works? > > > > I run 'mvn clean install -DskipTests -Psign-artifacts', but I get an error > > that the gpg key does not exist. > > > > I run 'mvn clean package -Dski

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59167/ --- (Updated May 12, 2017, 7:06 a.m.) Review request for sentry, Brian Towles, Hao

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

> On May 12, 2017, 2:26 a.m., Vamsee Yarlagadda wrote: > > sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListenerBase.java > > Line 362 (original), 362 (patched) > >