Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

> On May 16, 2017, 10:42 p.m., Sergio Pena wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransportPool.java > > Lines 102 (patched) > > > > > > You may use conf

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59167/ --- (Updated May 17, 2017, 4:42 a.m.) Review request for sentry, Brian Towles, Hao

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

> On May 16, 2017, 10:42 p.m., Sergio Pena wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransportPool.java > > Lines 94 (patched) > > > > > > The class annotate

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

> On May 17, 2017, 12:27 a.m., kalyan kumar kalvagadda wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryTransportPool.java > > Lines 135 (patched) > > > > > > lifo

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

> On May 16, 2017, 9:07 p.m., Lei Xu wrote: > > sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListenerBase.java > > Line 362 (original), 362 (patched) > >

Re: Review Request 58975: SENTRY-1669 HMSFollower should read current processed notification ID from database every time it runs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58975/#review175187 --- In addition to Sergio comments I have some nits - if you are makin

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59167/#review175145 --- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/co

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59167/#review175162 --- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/co

Re: Review Request 58975: SENTRY-1669 HMSFollower should read current processed notification ID from database every time it runs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58975/#review175154 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59167/#review175158 --- sentry-binding/sentry-binding-hive-common/src/main/java/org/apach

Re: Review Request 59274: SENTRY-1760: HMSFollower should detect when a full snapshot from HMS is required

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59274/#review175142 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 58975: SENTRY-1669 HMSFollower should read current processed notification ID from database every time it runs

> On May 16, 2017, 12:12 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Line 266 (original), 271 (patched) > > > > > > Supp

Re: Review Request 59174: SENTRY-1761 Add test for concurrent HMS followers processing notifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59174/#review175134 --- sentry-provider/sentry-provider-db/src/test/java/org/apache/sentr

Re: Review Request 59317: SENTRY-1736 Generic service client should support Kerberos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59317/#review175137 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 59120: SENTRY-1757: Avoid using local hive meta store using wrong configuration

> On May 16, 2017, 1:34 a.m., Alexander Kolbasov wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java > > Line 673 (original), 702 (patched) > > > > > >

Re: Review Request 59317: SENTRY-1736 Generic service client should support Kerberos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59317/#review175135 --- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/co

Re: Review Request 59120: SENTRY-1757: Avoid using local hive meta store using wrong configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59120/ --- (Updated May 16, 2017, 6:29 p.m.) Review request for sentry, Alexander Kolbasov

Review Request 59317: SENTRY-1736 Generic service client should support Kerberos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59317/ --- Review request for sentry, Alexander Kolbasov, Brian Towles, Hao Hao, Na Li, Ser

Re: Review Request 59120: SENTRY-1757: Avoid using local hive meta store using wrong configuration

> On May 16, 2017, 1:34 a.m., Alexander Kolbasov wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java > > Line 425 (original), 427 (patched) > > > > > >

Re: Review Request 59120: SENTRY-1757: Avoid using local hive meta store using wrong configuration

> On May 16, 2017, 1:55 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 201 (patched) > > > > > > metastoreUri is

Re: Review Request 58975: SENTRY-1669 HMSFollower should read current processed notification ID from database every time it runs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58975/ --- (Updated May 16, 2017, 5:11 p.m.) Review request for sentry, Alexander Kolbasov

Re: Review Request 59120: SENTRY-1757: Avoid using local hive meta store using wrong configuration

> On May 16, 2017, 1:34 a.m., Alexander Kolbasov wrote: > > sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java > > Lines 154 (patched) > > > > > > Can you add a

Re: Review Request 59120: SENTRY-1757: Avoid using local hive meta store using wrong configuration

> On May 16, 2017, 1:34 a.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/UpdateableAuthzPermissions.java > > Lines 73 (patched) > > > > > > What is this

Re: Review Request 58975: SENTRY-1669 HMSFollower should read current processed notification ID from database every time it runs

> On May 15, 2017, 10:24 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 607 (patched) > > > > > > Why not persist the ID her

Re: Review Request 58975: SENTRY-1669 HMSFollower should read current processed notification ID from database every time it runs

> On May 16, 2017, 12:12 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryHmsNotification.java > > Lines 25 (patched) > > > > > >

Re: Review Request 59282: SENTRY-1716: HMSFollower doesn't need to save path info when HDFS sync is disabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59282/#review175112 --- Ship it! Ship It! - Na Li On May 15, 2017, 8:04 p.m., Sergio

Re: Review Request 59274: SENTRY-1760: HMSFollower should detect when a full snapshot from HMS is required

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59274/#review175110 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 59274: SENTRY-1760: HMSFollower should detect when a full snapshot from HMS is required

> On May 15, 2017, 4:22 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 328 (patched) > > > > > > "(which inditicates a

Re: Review Request 59120: SENTRY-1757: Avoid using local hive meta store using wrong configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59120/#review174981 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 59282: SENTRY-1716: HMSFollower doesn't need to save path info when HDFS sync is disabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59282/#review175068 --- Ship it! Ship It! - Alexander Kolbasov On May 15, 2017, 8:04