Re: Review Request 61889: SENTRY-1895: Sentry should handle the case of multiple notifications with the same ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61889/#review183797 --- I think that it is more useful to get SHA1 on the original HMS

Re: Review Request 61863: SENTRY-1896 - Optimize retrieving roles for groups

> On Aug. 24, 2017, 6:46 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 1818 (patched) > > > > > > this condition

Re: Review Request 61863: SENTRY-1896 - Optimize retrieving roles for groups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61863/#review183789 --- Ship it! Ship It! - Na Li On Aug. 24, 2017, 7:26 p.m.,

Re: Review Request 61863: SENTRY-1896 - Optimize retrieving roles for groups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61863/ --- (Updated Aug. 24, 2017, 7:26 p.m.) Review request for sentry, Alexander

Re: Review Request 61889: SENTRY-1895: Sentry should handle the case of multiple notifications with the same ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61889/#review183776 --- Ship it! Ship It! - Na Li On Aug. 24, 2017, 4:59 p.m.,

Re: Review Request 61889: SENTRY-1895: Sentry should handle the case of multiple notifications with the same ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61889/#review183772 ---

Re: Review Request 61863: SENTRY-1896 - Optimize retrieving roles for groups

> On Aug. 24, 2017, 6:46 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Line 1816 (original), 1816 (patched) > > > > > >

Re: Review Request 61863: SENTRY-1896 - Optimize retrieving roles for groups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61863/#review183764 ---

Re: Review Request 61863: SENTRY-1896 - Optimize retrieving roles for groups

> On Aug. 24, 2017, 6:38 p.m., Vamsee Yarlagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 1821 (patched) > > > > > >

Re: Review Request 61863: SENTRY-1896 - Optimize retrieving roles for groups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61863/#review183763 --- LGTM otherwise

Review Request 61889: SENTRY-1895: Sentry should handle the case of multiple notifications with the same ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61889/ --- Review request for sentry, Alexander Kolbasov and Na Li. Bugs: sentry-1895

Re: Review Request 61862: SENTRY-1822 Allow multiple Sentry reporters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61862/#review183742 --- Ship it! Ship It! - Na Li On Aug. 23, 2017, 9:20 p.m.,