Re: Review Request 63645: SENTRY-2032: Leading Slashes need to removed when creating HMS path entries

2017-11-07 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63645/#review190428 --- Do you also want to update PathUpdate.parsePath() to be

Re: Review Request 63645: SENTRY-2032: Leading Slashes need to removed when creating HMS path entries

2017-11-07 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63645/#review190431 ---

Review Request 63645: SENTRY-2032: Leading Slashes need to removed when creating HMS path entries

2017-11-07 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63645/ --- Review request for sentry, Sergio Pena and Vadim Spector. Repository: sentry

Re: Review Request 63646: SENTRY-2035: Metrics should move to destination atomically

2017-11-07 Thread Vadim Spector via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63646/#review190414 --- Ship it! Ship It! - Vadim Spector On Nov. 7, 2017, 9:47

Re: Review Request 63646: SENTRY-2035: Metrics should move to destination atomically

2017-11-07 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63646/#review190382 --- Ship it! Ship It! - kalyan kumar kalvagadda On Nov. 7,

Re: Review Request 63250: [SENTRY-1475] SOLR/Sentry authorization plugin (with solr 7)

2017-11-07 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63250/#review190372 --- Ship it! Plesae address the one last comment that I have and

Review Request 63647: SENTRY-2036: sentry_sync_notifications() should set ID when it returns errors

2017-11-07 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63647/ --- Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, and

Re: Review Request 63646: SENTRY-2035: Metrics should move to destination atomically

2017-11-07 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63646/#review190374 --- Ship it! Ship It! - Sergio Pena On Nov. 7, 2017, 9:47 p.m.,

Re: Review Request 63619: SENTRY-2033: Fix TestDbPrivilegeCleanupOnDrop to use SentryMetastorePostEventListenerNotificationLog

2017-11-07 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63619/#review190369 --- Ship it! Ship It! - Sergio Pena On Nov. 7, 2017, 6:17 p.m.,

Re: Review Request 63619: SENTRY-2033: Fix TestDbPrivilegeCleanupOnDrop to use SentryMetastorePostEventListenerNotificationLog

2017-11-07 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63619/ --- (Updated Nov. 7, 2017, 6:17 p.m.) Review request for sentry, Alexander

Re: Review Request 63619: SENTRY-2033: Fix TestDbPrivilegeCleanupOnDrop to use SentryMetastorePostEventListenerNotificationLog

2017-11-07 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63619/#review190337 ---

Re: Review Request 63518: SENTRY-1997 - "Bump sqoop dependency version to 1.99.7"

2017-11-07 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63518/#review190336 --- Ship it! Looks good. I see only tests are modified to make it

Re: Review Request 63424: SENTRY-2024: Specify Char Set for AUTHZ_OBJ_NAME

2017-11-07 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63424/#review190334 --- Let's not commit this yet until we understand why AUTHZ_OBJ_NAME