Sentry as a library

2017-11-08 Thread Alexander Kolbasov
What do you think about providing a ‘sentry service as a library’ which is a wrapper that can run inside HMS and other consumers that will talk to the underlying database, understand schemas, etc and provide all information to a client without going through Thrift interface to the server? -

Re: Review Request 63687: SENTRY-2039: KeyValue is case sensitive and it causes incompatibility issues with external comp

2017-11-08 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63687/#review190512 ---

Re: Review Request 63415: SENTRY-2012 Make SentryShellGeneric extendible

2017-11-08 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63415/#review190501 --- Overall looks good, some style nits/comments. Colm is also poking

Review Request 63687: SENTRY-2039: KeyValue is case sensitive and it causes incompatibility issues with external comp

2017-11-08 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63687/ --- Review request for sentry. Bugs: sentry-2039

Re: Please add me as a contributor

2017-11-08 Thread Sergio Pena
Great, I can help on that. Btw, what is you Apache username? On Wed, Nov 8, 2017 at 4:18 PM, Stephen Moist wrote: > Hi I would like to be added as a contributor to the Sentry project. >

Please add me as a contributor

2017-11-08 Thread Stephen Moist
Hi I would like to be added as a contributor to the Sentry project.

Re: Review Request 63619: SENTRY-2033: Fix TestDbPrivilegeCleanupOnDrop to use SentryMetastorePostEventListenerNotificationLog

2017-11-08 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63619/#review190493 --- Ship it! Ship It! - Na Li On Nov. 7, 2017, 6:17 p.m.,

Re: Review Request 63250: [SENTRY-1475] SOLR/Sentry authorization plugin (with solr 7)

2017-11-08 Thread Hrishikesh Gadre via Review Board
> On Nov. 8, 2017, 6:55 p.m., Sergio Pena wrote: > > pom.xml > > Line 94 (original), 94 (patched) > > > > > > This version is already set on SENTRY-1997. Could you rebase your patch? I have already rebased my

Re: Review Request 63250: [SENTRY-1475] SOLR/Sentry authorization plugin (with solr 7)

2017-11-08 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63250/#review190473 --- pom.xml Line 94 (original), 94 (patched)

Re: Review Request 63647: SENTRY-2036: sentry_sync_notifications() should set ID when it returns errors

2017-11-08 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63647/#review190472 --- Ship it! Ship It! - Sergio Pena On Nov. 7, 2017, 9:58 p.m.,

Re: Review Request 63250: [SENTRY-1475] SOLR/Sentry authorization plugin (with solr 7)

2017-11-08 Thread Hrishikesh Gadre via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63250/ --- (Updated Nov. 8, 2017, 6:15 p.m.) Review request for sentry and Sergio Pena.

Review Request 63668: SENTRY-2038 - Some ShellCommand improvements

2017-11-08 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63668/ --- Review request for sentry. Bugs: SENTRY-2038

Re: Review Request 63645: SENTRY-2032: Leading Slashes need to removed when creating HMS path entries

2017-11-08 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63645/ --- (Updated Nov. 8, 2017, 2:59 p.m.) Review request for sentry, Sergio Pena and

Re: Review Request 63645: SENTRY-2032: Leading Slashes need to removed when creating HMS path entries

2017-11-08 Thread Arjun Mishra via Review Board
> On Nov. 8, 2017, 7 a.m., Alexander Kolbasov wrote: > > Do you also want to update PathUpdate.parsePath() to be consistent? I will check with Vadim on that. > On Nov. 8, 2017, 7 a.m., Alexander Kolbasov wrote: > >

Review Request 63667: SENTRY-2037: Remove not needed sentry-binding-hive-v2 dependency from the main pom.xml

2017-11-08 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63667/ --- Review request for sentry. Bugs: sentry-2037