Interesting coincedence

2017-11-17 Thread Alexander Kolbasov
1. SENTRY-2000 is"Cut 2.0.0 branch" !

Review Request 63928: SENTRY-2054: Unit tests must create temporary files under the Maven target directory

2017-11-17 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63928/ --- Review request for sentry. Bugs: sentry-2054

Re: Review Request 63896: SENTRY-2052: Reduce TestSentryStore time by setting transaction retries to 1 and other refactors

2017-11-17 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63896/ --- (Updated Nov. 17, 2017, 10:29 p.m.) Review request for sentry. Bugs:

Re: Review Request 63896: SENTRY-2052: Reduce TestSentryStore time by setting transaction retries to 1 and other refactors

2017-11-17 Thread Sergio Pena via Review Board
> On Nov. 17, 2017, 5:31 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > > Line 144 (original), 141 (patched) > >

Re: Review Request 63896: SENTRY-2052: Reduce TestSentryStore time by setting transaction retries to 1 and other refactors

2017-11-17 Thread Sergio Pena via Review Board
> On Nov. 17, 2017, 4:45 p.m., Na Li wrote: > > Have you run the tests for several times to make sure each test cleans up > > the sentry store, so next test won't be affected by previous test state? Yes, I have done that and it works. - Sergio

Re: Review Request 63925: SENTRY-1640: Implement HMS Notification barrier on the HMS plugin side

2017-11-17 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63925/ --- (Updated Nov. 17, 2017, 10:04 p.m.) Review request for sentry. Bugs:

Re: Review Request 63925: SENTRY-1640: Implement HMS Notification barrier on the HMS plugin side

2017-11-17 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63925/#review191394 --- Fix it, then Ship it! please fix the minor comment and push

Re: Cutting sentry 2.0.0 off master

2017-11-17 Thread Alexander Kolbasov
We can still create 2.0 branch and just be more selective about what goes there - we may choose to skip some commits from master. - Alex. On Fri, Nov 17, 2017 at 12:24 PM, Sergio Pena wrote: > +1 > > Sounds good Kalyan. I'm still finding the test failures and seems

Review Request 63925: SENTRY-1640: Implement HMS Notification barrier on the HMS plugin side

2017-11-17 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63925/ --- Review request for sentry. Bugs: sentry-1640

Re: Cutting sentry 2.0.0 off master

2017-11-17 Thread Sergio Pena
+1 Sounds good Kalyan. I'm still finding the test failures and seems related to a Jenkins environment more than our code. On Fri, Nov 17, 2017 at 11:51 AM, Colm O hEigeartaigh wrote: > SENTRY-1812 is complete and waiting for review (but currently dependent on > SENTRY-2012

Re: HDFS tests failing

2017-11-17 Thread Colm O hEigeartaigh
Yes on my local machine, but the last few runs have been green so I can't reliably reproduce them either Colm. On Fri, Nov 17, 2017 at 4:39 PM, Sergio Pena wrote: > Are they failing on you local machine? They are working fine for me. > Could they be related to the

Re: Cutting sentry 2.0.0 off master

2017-11-17 Thread Colm O hEigeartaigh
SENTRY-1812 is complete and waiting for review (but currently dependent on SENTRY-2012 getting merged first). SENTRY-2012 was merged to master today, but I had to revert it as it broke the Kafka tests. Colm. On Fri, Nov 17, 2017 at 5:28 PM, Kalyan Kumar Kalvagadda < kkal...@cloudera.com> wrote:

Re: Review Request 63896: SENTRY-2052: Reduce TestSentryStore time by setting transaction retries to 1 and other refactors

2017-11-17 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63896/#review191364 ---

Re: Cutting sentry 2.0.0 off master

2017-11-17 Thread Kalyan Kumar Kalvagadda
Colm/Mano Kovacs, Do you have an ETA on SENTRY-1812 and SENTRY-2012? -Kalyan -Kalyan On Fri, Nov 17, 2017 at 11:00 AM, Colm O hEigeartaigh wrote: > Fine with me, but I'd like to see the fixes for SENTRY-1812 and SENTRY-2012 > make it in to 2.0.0 as well. > > Colm. > > On

Re: Cutting sentry 2.0.0 off master

2017-11-17 Thread Colm O hEigeartaigh
Fine with me, but I'd like to see the fixes for SENTRY-1812 and SENTRY-2012 make it in to 2.0.0 as well. Colm. On Fri, Nov 17, 2017 at 4:56 PM, Kalyan Kumar Kalvagadda < kkal...@cloudera.com> wrote: > Hello all, > > > All of you are aware that we have decided to release sentry 2.0.0. As a >

Re: HDFS tests failing

2017-11-17 Thread Kalyan Kumar Kalvagadda
Colm, Can you provide the details of the Jira where you say these failures? -Kalyan -Kalyan On Fri, Nov 17, 2017 at 10:25 AM, Colm O hEigeartaigh wrote: > Apologies if this is already captured in a JIRA, but some of the HDFS tests > are consistently failing for me with

Cutting sentry 2.0.0 off master

2017-11-17 Thread Kalyan Kumar Kalvagadda
Hello all, All of you are aware that we have decided to release sentry 2.0.0. As a first step I propose the cut the branch for sentry 2.0.0 off the master today. We still have couple of issues that are pending to for 2.0.0 but I would like to cut it as the tests on the master have become flaky.

Re: Review Request 63896: SENTRY-2052: Reduce TestSentryStore time by setting transaction retries to 1 and other refactors

2017-11-17 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63896/#review191354 --- Have you run the tests for several times to make sure each test

Re: Review Request 63886: SENTRY-2047: isTableEmptyCore method in SentryStore has references to MAuthzPathsMapping when it should be generic

2017-11-17 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63886/#review191352 --- Ship it! Ship It! - Na Li On Nov. 16, 2017, 7:29 p.m.,

Re: HDFS tests failing

2017-11-17 Thread Sergio Pena
Are they failing on you local machine? They are working fine for me. Could they be related to the current test failures happening on Jenkins? We've been trying to figure out which patch is causing the current test failures, but it takes us time because they pass locally. Do you think you can

Re: Review Request 63856: SENTRY-2048: Bump Hive version to 2.3.2

2017-11-17 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63856/#review191348 --- Ship it! Ship It! - Na Li On Nov. 16, 2017, 6:54 p.m.,

HDFS tests failing

2017-11-17 Thread Colm O hEigeartaigh
Apologies if this is already captured in a JIRA, but some of the HDFS tests are consistently failing for me with the latest master: ERROR] Failures: [ERROR]

Re: Review Request 63874: SENTRY-1812 - Provide interactive Sentry CLI

2017-11-17 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63874/ --- (Updated Nov. 17, 2017, 11:24 a.m.) Review request for sentry. Bugs:

Re: Review Request 63415: SENTRY-2012 Make SentryShellGeneric extendible

2017-11-17 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63415/#review191314 --- Ship it! Ship It! - Colm O hEigeartaigh On Nov. 16, 2017,