Re: Review Request 64259: SENTRY-1572 SentryMain() shouldn't dynamically load tool class

2018-01-04 Thread Xinran Tinney
> On Jan. 4, 2018, 9:37 p.m., Arjun Mishra wrote: > > I don't think you meant to commit > > "sentry-dist/src/license/THIRD-PARTY.properties". Am I right? It is being > > generated because of another issue. I am not sure if you intentionally > > created it > > Steve Moist wrote: > I have a

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

2018-01-04 Thread Vadim Spector via Review Board
> On Jan. 4, 2018, 10:40 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Line 205 (original), 206 (patched) > > > > > > I thought

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

2018-01-04 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/ --- (Updated Jan. 5, 2018, 12:10 a.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

2018-01-04 Thread Vadim Spector via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/#review194788 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 64259: SENTRY-1572 SentryMain() shouldn't dynamically load tool class

2018-01-04 Thread Arjun Mishra via Review Board
> On Jan. 4, 2018, 9:37 p.m., Arjun Mishra wrote: > > I don't think you meant to commit > > "sentry-dist/src/license/THIRD-PARTY.properties". Am I right? It is being > > generated because of another issue. I am not sure if you intentionally > > created it > > Steve Moist wrote: > I have a

Re: Review Request 64949: SENTRY-641 Add binding for lily hbase indexer

2018-01-04 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64949/#review194781 --- pom.xml Lines 513 (patched)

Re: Issue with SimpleCacheProviderBackend

2018-01-04 Thread Na Li
Colm, The following code shows where Hive sets the column info. You can debug into hive code and see why AccessedColumns is not set. The related code is in org.apache.hadoop.hive.ql.parse.SemanticAnalyzer boolean isColumnInfoNeedForAuth = SessionState.get().isAuthorizationModeV2(

Re: Review Request 64259: SENTRY-1572 SentryMain() shouldn't dynamically load tool class

2018-01-04 Thread Steve Moist via Review Board
> On Jan. 4, 2018, 9:37 p.m., Arjun Mishra wrote: > > I don't think you meant to commit > > "sentry-dist/src/license/THIRD-PARTY.properties". Am I right? It is being > > generated because of another issue. I am not sure if you intentionally > > created it I have also seen this on another revi

Re: Review Request 64259: SENTRY-1572 SentryMain() shouldn't dynamically load tool class

2018-01-04 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64259/#review194789 --- I don't think you meant to commit "sentry-dist/src/license/THIRD-

Review Request 64960: SENTRY-2113: MSentryHmsNotification should also hold the notification hash.

2018-01-04 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64960/ --- Review request for sentry, Alexander Kolbasov, Arjun Mishra, Na Li, Sergio Pena,

Re: Review Request 64890: SENTRY-1165 add clover plugin to maven to get code coverage report

2018-01-04 Thread Xinran Tinney
> On Jan. 2, 2018, 5:04 p.m., Steve Moist wrote: > > pom.xml > > Lines 117 (patched) > > > > > > Looks like 4.2.1 is the latest version, any reason why we're not using > > it? > > Xinran Tinney wrote: > I was f

Re: Review Request 64949: SENTRY-641 Add binding for lily hbase indexer

2018-01-04 Thread Steve Moist via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64949/#review194783 --- sentry-binding/sentry-binding-hbase-indexer/src/main/java/org/apa

Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

2018-01-04 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/ --- Review request for sentry, Alexander Kolbasov, Arjun Mishra, Na Li, Sergio Pena,

Re: Review Request 64820: SENTRY-2106: Remove sentry dependency on HMS table NOTIFICATION_SEQUENCE

2018-01-04 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/ --- (Updated Jan. 4, 2018, 7:23 p.m.) Review request for sentry, Alexander Kolbasov

Re: Review Request 64820: SENTRY-2106: Remove sentry dependency on HMS table NOTIFICATION_SEQUENCE

2018-01-04 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/ --- (Updated Jan. 4, 2018, 7:21 p.m.) Review request for sentry, Alexander Kolbasov

??????any parameters can change "hive" user when using sentry-hdfs sync

2018-01-04 Thread ????
Hi Kalyan, Appreciate your quick help. CDH CM does not make "entry.authorization-provider.hdfs-user" visible, I added it manually on CM. Anyway, it works now. Thanks a lot!! -- -- ??: "Ida~";<22494...@qq.com>; : 2018??1??3??(??) 2:22

Re: Review Request 64820: SENTRY-2106: Eliminate sentry ahead logic

2018-01-04 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/#review194770 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 64820: SENTRY-2106: Eliminate sentry ahead logic

2018-01-04 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/ --- (Updated Jan. 4, 2018, 5:06 p.m.) Review request for sentry, Alexander Kolbasov

Re: Review Request 64820: SENTRY-2106: Sentry ahead full snapshot retry logic

2018-01-04 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/ --- (Updated Jan. 4, 2018, 5:05 p.m.) Review request for sentry, Alexander Kolbasov

Re: Review Request 64820: SENTRY-2106: Sentry ahead full snapshot retry logic

2018-01-04 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/ --- (Updated Jan. 4, 2018, 4:43 p.m.) Review request for sentry, Alexander Kolbasov

Re: Review Request 64820: SENTRY-2106: Sentry ahead full snapshot retry logic

2018-01-04 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/ --- (Updated Jan. 4, 2018, 4:40 p.m.) Review request for sentry, Alexander Kolbasov

Review Request 64949: SENTRY-641 Add binding for lily hbase indexer

2018-01-04 Thread Mano Kovacs via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64949/ --- Review request for sentry. Bugs: SENTRY-641 https://issues.apache.org/jira/

Re: [DISCUSS] Propose new Sentry PMC - Kalyan Kalvagadda

2018-01-04 Thread Colm O hEigeartaigh
+1. Colm. On Wed, Jan 3, 2018 at 11:39 PM, Sergio Pena wrote: > Hi PMC, > > Kalyan became a committer in June/2017 and since then, he has helped all > contributors to get their patches reviewed and committed helping the > project to be active and healthy. He has done 49 commits in total + aroun

Re: [DISCUSS] Propose new Sentry committer - Na Li

2018-01-04 Thread Colm O hEigeartaigh
+1. Colm. On Wed, Jan 3, 2018 at 11:42 PM, Sergio Pena wrote: > Hi PMC, > > I'd like to propose that we vote to make Na Li a new committer on the > Apache Sentry project. > > Na Li has been a contributor since April/2017 and has contributed around 20 > patches to the project since then. She has