Review Request 68273: SENTRY-2313: alter database set owner command can be executed only by user with proper privilege

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68273/ --- Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Sergio Pen

Re: Review Request 68271: SENTRY-2337: [REVERT] SENTRY-2295: Owner privileges should not be granted to sentry admin users

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68271/#review207007 --- Ship it! Ship It! - Na Li On Aug. 8, 2018, 9:37 p.m., kalyan

Re: Review Request 68268: SENTRY-2157: Update audit log to grant/revoke owner privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68268/#review207006 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 68268: SENTRY-2157: Update audit log to grant/revoke owner privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68268/#review207005 --- Ship it! Ship It! - Na Li On Aug. 8, 2018, 10:36 p.m., Sergi

Re: Review Request 68268: SENTRY-2157: Update audit log to grant/revoke owner privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68268/#review207004 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 68268: SENTRY-2157: Update audit log to grant/revoke owner privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68268/ --- (Updated Aug. 8, 2018, 10:36 p.m.) Review request for sentry, Arjun Mishra, kal

Re: Review Request 68268: SENTRY-2157: Update audit log to grant/revoke owner privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68268/ --- (Updated Aug. 8, 2018, 10:10 p.m.) Review request for sentry, Arjun Mishra, kal

Re: Review Request 68268: SENTRY-2157: Update audit log to grant/revoke owner privileges

> On Aug. 8, 2018, 7:25 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > > Lines 1577 (patched) > > > > > > should this

Re: Review Request 68268: SENTRY-2157: Update audit log to grant/revoke owner privileges

> On Aug. 8, 2018, 9:12 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntityFactory.java > > Lines 169 (patched) > > > > > > This function c

Review Request 68271: SENTRY-2337: [REVERT] SENTRY-2295: Owner privileges should not be granted to sentry admin users

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68271/ --- Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena. Bugs: SENTRY-2

Re: Review Request 68268: SENTRY-2157: Update audit log to grant/revoke owner privileges

> On Aug. 8, 2018, 7:25 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > > Lines 1577 (patched) > > > > > > should this

Re: Review Request 68268: SENTRY-2157: Update audit log to grant/revoke owner privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68268/#review206999 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 68264: SENTRY-2335: Allow sentry to have multiple handlers for a Signal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68264/#review206998 --- Ship it! Ship It! - Na Li On Aug. 8, 2018, 8:25 p.m., Brian

Re: Review Request 68268: SENTRY-2157: Update audit log to grant/revoke owner privileges

> On Aug. 8, 2018, 7:25 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > > Line 1396 (original), 1336 (patched) > > > > > >

Re: Review Request 68264: SENTRY-2335: Allow sentry to have multiple handlers for a Signal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68264/ --- (Updated Aug. 8, 2018, 3:25 p.m.) Review request for sentry, kalyan kumar kalva

Re: Review Request 68264: SENTRY-2335: Allow sentry to have multiple handlers for a Signal

> On Aug. 8, 2018, 2:48 p.m., Na Li wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SigUtils.java > > Line 66 (original), 72 (patched) > > > > > > should we use try/catch he

Re: Review Request 67888: SENTRY-2308: Create privilege on table has no use case

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67888/#review206994 --- can you add test case for this change? - Na Li On July 13, 2018

Re: Review Request 68264: SENTRY-2335: Allow sentry to have multiple handlers for a Signal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68264/#review206992 --- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/co

Re: Review Request 68268: SENTRY-2157: Update audit log to grant/revoke owner privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68268/#review206991 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 68268: SENTRY-2157: Update audit log to grant/revoke owner privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68268/#review206989 --- Ship it! Ship It! - Arjun Mishra On Aug. 8, 2018, 2:29 p.m.,

Re: Review Request 68268: SENTRY-2157: Update audit log to grant/revoke owner privileges

> On Aug. 8, 2018, 3:46 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > > Line 1619 (original), 1571 (patched) > >

Re: Review Request 68249: SENTRY-2255: alter table set owner command can be executed only by user with proper privilege

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68249/#review206985 --- Ship it! Ship It! - kalyan kumar kalvagadda On Aug. 7, 2018,

Re: Review Request 68268: SENTRY-2157: Update audit log to grant/revoke owner privileges

> On Aug. 8, 2018, 3:46 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > > Line 1619 (original), 1571 (patched) > >

Re: Review Request 68268: SENTRY-2157: Update audit log to grant/revoke owner privileges

> On Aug. 8, 2018, 3:46 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > > Lines 1503 (patched) > > > > > > Can

Re: Review Request 67888: SENTRY-2308: Create privilege on table has no use case

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67888/#review206983 --- Ship it! Ship It! - Arjun Mishra On July 13, 2018, 6:45 p.m.

Re: Review Request 68268: SENTRY-2157: Update audit log to grant/revoke owner privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68268/#review206981 --- Ship it! Overall looks good. I had a question about audit messa

Re: Review Request 68268: SENTRY-2157: Update audit log to grant/revoke owner privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68268/#review206980 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 68268: SENTRY-2157: Update audit log to grant/revoke owner privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68268/ --- (Updated Aug. 8, 2018, 2:29 p.m.) Review request for sentry, Arjun Mishra, kaly

Review Request 68268: SENTRY-2157: Update audit log to grant/revoke owner privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68268/ --- Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li. Bu