Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

2018-08-29 Thread Brian Towles via Review Board
> On Aug. 29, 2018, 3:29 p.m., Steve Moist wrote: > > lombok.config > > Lines 1 (patched) > > > > > > In introducing lombok into sentry. Will the configs for the existing > > sl4j need to be updated or modified? > >

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

2018-08-29 Thread Alexander Kolbasov
> On Aug. 29, 2018, 8:29 p.m., Steve Moist wrote: > > lombok.config > > Lines 1 (patched) > > > > > > In introducing lombok into sentry. Will the configs for the existing > > sl4j need to be updated or modified? > >

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

2018-08-29 Thread Steve Moist via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68488/#review208112 --- lombok.config Lines 1 (patched)

Re: Review Request 68226: SENTRY-2320 Refactor existing Sentry CLIs to use jcommander instead of commons-cli

2018-08-29 Thread Steve Moist via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68226/#review208110 --- sentry-tools/pom.xml Lines 56 (patched)

Re: Review Request 68547: SENTRY-2370: Create a cache of PathUpdates to send to NN

2018-08-29 Thread Arjun Mishra via Review Board
> On Aug. 29, 2018, 3:54 p.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathImageRetriever.java > > Lines 52-53 (original), 54-71 (patched) > > > > > > "reset the cache whe

Re: Review Request 68547: SENTRY-2370: Create a cache of PathUpdates to send to NN

2018-08-29 Thread Arjun Mishra via Review Board
> On Aug. 29, 2018, 1:28 p.m., kalyan kumar kalvagadda wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathImageRetriever.java > > Lines 52-53 (original), 54-71 (patched) > > > > > > Ge

Re: Review Request 68547: SENTRY-2370: Create a cache of PathUpdates to send to NN

2018-08-29 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68547/ --- (Updated Aug. 29, 2018, 7:04 p.m.) Review request for sentry, kalyan kumar kalv

Re: Review Request 68547: SENTRY-2370: Create a cache of PathUpdates to send to NN

2018-08-29 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68547/#review208098 --- sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/h

Re: Review Request 68547: SENTRY-2370: Create a cache of PathUpdates to send to NN

2018-08-29 Thread Arjun Mishra via Review Board
> On Aug. 29, 2018, 1:28 p.m., kalyan kumar kalvagadda wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathImageRetriever.java > > Line 52 (original), 54 (patched) > > > > > > This cond

Re: Review Request 68547: SENTRY-2370: Create a cache of PathUpdates to send to NN

2018-08-29 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68547/#review208090 --- sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/h