Review Request 69924: SENTRY-2440: Add a new thrift API for checking if a user is in admin group

/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServiceIntegration.java bfafa7d99735bec07bd81ebe665f4e84e65bd3b7 Diff: https://reviews.apache.org/r/69924/diff/1/ Testing --- Unit test. Thanks, Hao Hao

Re: Review Request 69536: SENTRY-2471: Table rename should sync Sentry privilege even without location information

://reviews.apache.org/r/69536/diff/2-3/ Testing (updated) --- added new unit tests Thanks, Hao Hao

Re: Review Request 69536: SENTRY-2471: Table rename should sync Sentry privilege even without location information

7b7d0e1eb7ea1f17dea622e51ccc557e0b76fbff Diff: https://reviews.apache.org/r/69536/diff/2/ Changes: https://reviews.apache.org/r/69536/diff/1-2/ Testing --- existing unit tests Thanks, Hao Hao

Review Request 69536: SENTRY-2471: Table rename should sync Sentry privilege even without location information

: https://reviews.apache.org/r/69536/diff/1/ Testing --- existing unit tests Thanks, Hao Hao

Re: [VOTE] Release Sentry version 2.1.0

+1 Thanks Lina! Best, Hao On Fri, Sep 28, 2018 at 8:31 AM Kalyan Kumar Kalvagadda wrote: > Looks Good. > > +1 on the release of 2.1.0 > > > > *Thanks,Kalyan Kumar Kalvagadda* | Software Engineer > t. (469) 279- <00>5732 > cloudera.com > > [image: Cloudera]

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68822/#review209007 --- On Sept. 25, 2018, 9:23 p.m., Hao Hao wrote: > > --

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

15> > > > > you have got groups in line 908 if the requestor is the same as > > principlaName. It should improve performance to reuse it under this > > situation > > Hao Hao wrote: > I don't think the requestor is the same as principal? Here it

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

: https://reviews.apache.org/r/68822/diff/3/ Changes: https://reviews.apache.org/r/68822/diff/2-3/ Testing --- Unit test. Thanks, Hao Hao

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68822/#review208969 --- On Sept. 24, 2018, 9:31 p.m., Hao Hao wrote: > > --

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

> On Sept. 24, 2018, 3:35 p.m., Sergio Pena wrote: > > Btw, are you going to have another JIRA for the client to call this new API? > > Hao Hao wrote: > Sure, I can create a jira for adding the client side logical. SENTRY-2418

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

25f94fa05b05abf8c1dbc33e97e5e88ae01794e4 Diff: https://reviews.apache.org/r/68822/diff/2/ Changes: https://reviews.apache.org/r/68822/diff/1-2/ Testing --- Unit test. Thanks, Hao Hao

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

matically generated e-mail. To reply, visit: https://reviews.apache.org/r/68822/#review208950 --- On Sept. 23, 2018, 8:52 p.m., Hao Hao wrote: > > --- > This is an automaticall

Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

://reviews.apache.org/r/68822/diff/1/ Testing --- Unit test. Thanks, Hao Hao

Re: Please welcome Kalyan Kalvagadda to Apache PMC!

Congrats! Best, Hao On Mon, Feb 5, 2018 at 3:18 PM, Stephen Moist wrote: > Congrats! > > > On Feb 5, 2018, at 12:33 PM, Na Li wrote: > > > > Kalyan, Congratulation! > > > > On Mon, Feb 5, 2018 at 2:18 PM, Sergio Pena > >

Re: DISCUSSION: Prepare master for next release (2.0.0)

+1 Best, Hao On Thu, Jul 27, 2017 at 1:38 AM, Colm O hEigeartaigh wrote: > +1. > > Colm. > > On Wed, Jul 26, 2017 at 10:45 PM, Vamsee Yarlagadda > wrote: > > > +1 > > > > Thanks, > > Vamsee > > > > On Wed, Jul 26, 2017 at 2:11 PM, Na Li

Re: Requesting to add 'viktorsomogyi' as contributor

Hi Viktor, I have added you as a contributor. Best, Hao On Tue, May 30, 2017 at 7:24 AM, Viktor Somogyi wrote: > Hi folks, > > I would like to assign some jiras to myself and contribute to Sentry. > Could someone please add me as contributor so I can start doing

Re: Review Request 57375: Unable to truncate table .; from "default" databases

<https://reviews.apache.org/r/57375/#comment248352> Same here - Hao Hao On March 16, 2017, 2:41 p.m., Yongzhi Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 58975: SENTRY-1669 HMSFollower should read current processed notification ID from database every time it runs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58975/#review174830 --- Ship it! Ship It! - Hao Hao On May 12, 2017, 5:38 p.m

Re: Review Request 58808: SENTRY-1726 sql changes to store last notification-id processed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58808/#review174749 --- Ship it! Ship It! - Hao Hao On May 9, 2017, 11:15 p.m

Re: Review Request 58975: SENTRY-1669 HMSFollower should read current processed notification ID from database every time it runs

ersistent/TestSentryStore.java Lines 3035 (patched) <https://reviews.apache.org/r/58975/#comment247959> Assert.fail(..) here. - Hao Hao On May 11, 2017, 1:16 p.m., kalyan kumar kalvagadda wrote: > > --- > Th

Re: Review Request 58975: SENTRY-1669 HMSFollower should read current processed notification ID from database every time it runs

r/db/service/persistent/SentryStore.java Line 3435 (original), 3466 (patched) <https://reviews.apache.org/r/58975/#comment247700> getLastProcessedNotificationIDCore will return null right? This behavior no longer match the method description. - Hao Hao On May 10, 2017, 7:27 p.m., kalya

Re: Review Request 58867: SENTRY-1734 Create/Alter/Drop database/table should check corresponding property before drop priv...

/main/java/org/apache/sentry/service/thrift/HMSFollower.java Lines 527 (patched) <https://reviews.apache.org/r/58867/#comment246434> Do we need to file a jira to track it? - Hao Hao On April 29, 2017, 12:21 a.m., Alexander Kolbasov

Re: Review Request 58284: SENTRY-1687 FullUpdateInitializer can be more efficient

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58284/#review173062 --- Ship it! Ship It! - Hao Hao On April 26, 2017, 6:51 a.m

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

: https://reviews.apache.org/r/58412/diff/3-4/ Testing --- 1. Add new unit test in TestSentryStore 2. Enabled hdfs sync integration test Thanks, Hao Hao

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

d or not? Yes, make sense. Will update it. - Hao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58412/#review172289 ----------- On April 18, 2017, 9:34 p.m., Hao Hao wrote: > > ---

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

To reply, visit: https://reviews.apache.org/r/58412/#review172301 ----------- On April 18, 2017, 9:34 p.m., Hao Hao wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

s.apache.org/r/58412/#review172301 --- On April 18, 2017, 9:34 p.m., Hao Hao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 58593: SENTRY-1710. Reduce datanucleus key cache size for MSentryPermChange and MSentryPathChange tables to avoid holes in change IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58593/#review172565 --- Ship it! Ship It! - Hao Hao On April 20, 2017, 8:56 p.m

Re: Clarification for MPath changes for SENTRY-1587

Hi Alex, I changed MPath class to include pathID to have correct MPath equality comparison. Since the original equals() definition only compares 'path' which for different MPath object it may have the same value. For pathID (primary key) assignment I change it to be auto-increment by specifying

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

. Thanks a lot Lina for picking this up! sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java Lines 314 (patched) <https://reviews.apache.org/r/58221/#comment245376> Nit: this line seems too long. Similar to above ones longer than 100. - H

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

) --- 1. Add new unit test in TestSentryStore 2. Enabled hdfs sync integration test Thanks, Hao Hao

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

: https://reviews.apache.org/r/58412/diff/2-3/ Testing --- Thanks, Hao Hao

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

------------ On April 18, 2017, 7:34 a.m., Hao Hao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58412/ >

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58412/#review172270 --- - Hao Hao On April 18, 2017, 7:34 a.m., Hao Hao wrote

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

1537#file1691537line2560> > > > > I don't think you need to explicitely do this - it should be sufficient > > to remove the path from the set and update the MAuthzPathsMapping object. > > Hao Hao wrote: > Will try and update. Just tried with remove 'pm.deletePersistent(mPa

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

omatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58412/#review172212 ----------- On April 18, 2017, 7:34 a.m., Hao Hao wrote: > > --- > This is an automatically generated e

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58412/#review172212 ----------- On April 18, 2017, 7:34 a.m., Hao Hao wrote: > > -

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58412/#review172256 --- - Hao Hao On April 18, 2017, 7:34 a.m., Hao Hao wrote

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58412/#review172212 --- On April 18, 2017, 7:34 a.m., Hao Hao wrote: > > --

Re: Review Request 58412: [WIP]SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

: https://reviews.apache.org/r/58412/diff/1-2/ Testing --- Thanks, Hao Hao

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java 0e97466c9ba6973d8e787819e292c3b826472b38 Diff: https://reviews.apache.org/r/58412/diff/2/ Testing --- Thanks, Hao Hao

Re: Review Request 58412: [WIP]SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58412/#review172039 --- On April 13, 2017, 6:58 a.m., Hao Hao wrote: > >

Re: Review Request 58412: [WIP]SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

ath from AuthzObj. In deletePathsFromAuthzObject it skip the deletion if it cannot find it and log the info. - Hao Hao On April 13, 2017, 6:58 a.m., Hao Hao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 58412: [WIP]SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58412/#review172131 ------- On April 13, 2017, 6:58 a.m., Hao Hao wrote: > > ---

Re: [DISCUSS] Merging Sentry HA branch with master

The proposal is good to me as well. Should we start a vote on this? Or we can just start to do it if no one is objecting? Best, Hao On Mon, Apr 17, 2017 at 4:42 PM, Vamsee Yarlagadda wrote: > > > > Cherry-pick any commits that happened since sentry-ha-redesign was >

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/#review171847 --- Ship it! Ship It! - Hao Hao On April 7, 2017, 9:56 p.m

Review Request 58412: [WIP]SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

31a309bdc789bd7a997f7654e30f2021ecb5b616 Diff: https://reviews.apache.org/r/58412/diff/1/ Testing --- Thanks, Hao Hao

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

es 325 (patched) <https://reviews.apache.org/r/58221/#comment244400> Should we call hmsFollower.stop(); before terminate hmsFollowerExecutor? - Hao Hao On April 7, 2017, 5:23 p.m., Na Li wrote: > > --- > This is an automatic

Re: Review Request 58281: SENTRY-1643. AutoIncrement ChangeID of MSentryPermChange/MSentryPathChange may be error-prone

/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java Lines 2581 (patched) <https://reviews.apache.org/r/58281/#comment244398> Can you add a comment for what this test is about? Also a link to the sentry jira number. Thanks! - Hao Hao On April 8, 2017, 12:

Re: Review Request 58166: SENTRY-1692 ZK namespace configuration doesn't work

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58166/#review171310 --- Ship it! Ship It! - Hao Hao On April 4, 2017, 5:03 a.m

Re: Review Request 58093: SENTRY-1676: FullUpdateInitializer#createInitialUpdate should not throw RuntimeExceptio

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58093/#review171309 --- Ship it! Ship It! - Hao Hao On March 31, 2017, 5:07 a.m

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

/sentry/service/thrift/SentryService.java Lines 310 (patched) <https://reviews.apache.org/r/58221/#comment244140> what happens if the submitted task has not been shut down and someone calls startHMSFollower? Is it safe to allow so? - Hao Hao On April 5, 2017, 10:29 p.m., Na Li

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

-mysql-1.8.0.sql Lines 269 (patched) <https://reviews.apache.org/r/58164/#comment244115> If you are adding unique index here, you also need to change the jdo definition as I do not see it has this constraint. - Hao Hao On April 6, 2017, 2:17 p.m., kalyan kumar kalvagadda

Re: Review Request 58130: SENTRY-1684 FullUpdateInitializer has a race condition in handling results list

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58130/#review171235 --- Ship it! Ship It! - Hao Hao On April 1, 2017, 12:35 a.m

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

using yet. BTW, did you get a chance to verify those changes? - Hao Hao On April 6, 2017, 12:35 a.m., kalyan kumar kalvagadda wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 58069: SENTRY-1670 Expose current HMS notification ID as a Sentry gauge (metric)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58069/#review171038 --- Ship it! Ship It! - Hao Hao On April 4, 2017, 8:33 p.m

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

> On April 4, 2017, 4:40 p.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.oracle.sql > > Lines 1 (patched) > > <https://reviews.apache.org/r/58164/diff/2/?file=1684331#file1684331line1> > > > > Why creat

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

-upgrade-postgres-1.7.0-to-1.8.0.sql Lines 5 (patched) <https://reviews.apache.org/r/58164/#comment243837> Should it be 009-xxx other than 008-xxx if we want to have a seperate file for the change? - Hao Hao On April 4, 2017, 5:05 p.m., kalyan kumar kalvagadda

Re: Review Request 58069: SENTRY-1670 Expose current HMS notification ID as a Sentry gauge (metric)

> On April 4, 2017, 6:31 a.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Line 3167 (original), 3187 (patched) > > <https://reviews.apache.org/r/58069/diff/1/?file=168

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

-1638.oracle.sql Lines 1 (patched) <https://reviews.apache.org/r/58164/#comment243815> Why create a new file for create notification id field inside PATHChange table? It should be ok to just add upon the 008-SENTRY-1569.xxx.sql as there is no release yet. - Hao Hao On April 4, 2017

Re: Review Request 58069: SENTRY-1670 Expose current HMS notification ID as a Sentry gauge (metric)

/sentry/provider/db/service/persistent/SentryStore.java Line 3167 (original), 3187 (patched) <https://reviews.apache.org/r/58069/#comment243798> Why do we change from 'Long' to 'long' here? it would result in extra unbox and autobox. - Hao Hao On March 30, 2017, 5:25 a.m., Alexander Ko

Re: Review Request 58166: SENTRY-1692 ZK namespace configuration doesn't work

/sentry/service/thrift/LeaderStatusMonitor.java Line 96 (original) <https://reviews.apache.org/r/58166/#comment243797> Not quite follow the change. If we are complete remove namespace here, why do we still keep the namespace config in HAContext? And why do we need it? - Hao Hao On April 4

Re: Review Request 58094: SENTRY-1683 MetastoreCacheInitializer has a race condition in handling results list

/main/java/org/apache/sentry/hdfs/MetastoreCacheInitializer.java Line 364 (original), 362 (patched) <https://reviews.apache.org/r/58094/#comment243671> Could it ever be negative? - Hao Hao On March 31, 2017, 10:36 p.m., Alexander Kolbasov

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

, Hao Hao

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

t; Are we still using SentryPlugin? Yes, we are still using it when HDFS sync feature is on. - Hao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57232/#review169817 ------------

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

tps://issues.apache.org/jira/browse/SENTRY-1677/. - Hao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57232/#review169817 ---------

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

which belongs to different threads. - Hao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57232/#review169817 -------

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 859c8f882db76e46297c1f6377de32bc2b08f485 Diff: https://reviews.apache.org/r/57232/diff/8/ Changes: https://reviews.apache.org/r/57232/diff/7-8/ Testing --- Thanks, Hao Hao

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 859c8f882db76e46297c1f6377de32bc2b08f485 Diff: https://reviews.apache.org/r/57232/diff/7/ Changes: https://reviews.apache.org/r/57232/diff/6-7/ Testing --- Thanks, Hao Hao

Re: Review Request 57657: SENTRY-1658: Fixed possible null pointer dereference in SentryShellHive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57657/#review169082 --- Ship it! Ship It! - Hao Hao On March 15, 2017, 6:41 p.m

Re: Review Request 57375: Unable to truncate table .; from "default" databases

/sentry/binding/hive/HiveAuthzBindingHook.java Lines 253 (patched) <https://reviews.apache.org/r/57375/#comment241399> Could you please add a comment here to explain what is the ast structure look like here? And what does it evalutate to be '1' mean here. - Hao Hao On March 7, 2017, 1:

Re: Review Request 57654: SENTRY-1663: Moved mutable field in UpdateableAuthzPermissions to immutable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57654/#review169077 --- Ship it! Ship It! - Hao Hao On March 15, 2017, 5:33 p.m

Re: Review Request 57635: SENTRY-1660: Removed useless code in ResourceAuthorizationProvider

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57635/#review169076 --- Ship it! Ship It! - Hao Hao On March 15, 2017, 9:29 a.m

Re: Review Request 57570: SENTRY-1644. Partition ACLs disappear after renaming Hive table with partitions

, TestHDFSIntegrationAdvanced. To ensure cases such as for managed/unmanaged table we get expected output. Also, it looks like the tests are not all green. Would you mind take a look if anything related? - Hao Hao On March 13, 2017, 9:57 p.m., Lei Xu wrote

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

to syncgronize. It is simply because updatePartial requires a lock.. - Hao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57232/#review168846 ----------

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

ps://reviews.apache.org/r/57232/#review168846 ----------- On March 14, 2017, 6:59 p.m., Hao Hao wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

enever the purge delta thread takes place. - Hao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57232/#review168846 -----------

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

ly, visit: https://reviews.apache.org/r/57232/#review168846 ------- On March 10, 2017, 11:14 p.m., Hao Hao wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57232/#review168846 --- On March 10, 2017, 11:14 p.m., Hao Hao wrote: &

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

75f855caec1060f9158562aeb81ec53d8a679941 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java f2d74bfe5e413ea88c3c77ef303f1c7f9ee16253 Diff: https://reviews.apache.org/r/57232/diff/3/ Changes: https://reviews.apache.org/r/57232/diff/2-3/ Testing --- Thanks, Hao Hao

Re: Review Request 55706: SENTRY-1566: Make full Perm/Path snapshot available for NN plugin

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55706/#review168025 --- On March 2, 2017, 9:43 p.m., Hao Hao wrote: > >

Re: Review Request 57308: SENTRY-1388: Make HiveConf and Hive client jars available to Sentry deamon

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57308/#review167954 --- Ship it! Ship It! - Hao Hao On March 3, 2017, 10:41 p.m

Re: Review Request 56709: SENTRY-1569 Added changes to sql scripts persist Perm/Path change Adding missing files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56709/#review167953 --- Ship it! Ship It! - Hao Hao On March 2, 2017, 12:15 a.m

Re: Review Request 55706: SENTRY-1566: Make full Perm/Path snapshot available for NN plugin

: https://reviews.apache.org/r/55706/diff/3-4/ Testing --- Thanks, Hao Hao

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

/TestHDFSIntegration.java f2d74bfe5e413ea88c3c77ef303f1c7f9ee16253 Diff: https://reviews.apache.org/r/57232/diff/2/ Changes: https://reviews.apache.org/r/57232/diff/1-2/ Testing --- Thanks, Hao Hao

Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

91f15c0f3999a25a20dfb45f2f28abbda54366f4 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java f2d74bfe5e413ea88c3c77ef303f1c7f9ee16253 Diff: https://reviews.apache.org/r/57232/diff/1/ Testing --- Thanks, Hao Hao

Re: Review Request 55706: SENTRY-1566: Make full Perm/Path snapshot available for NN plugin

: https://reviews.apache.org/r/55706/diff/2-3/ Testing --- Thanks, Hao Hao

Re: Review Request 55706: SENTRY-1566: Make full Perm/Path snapshot available for NN plugin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55706/#review167631 --- - Hao Hao On Feb. 3, 2017, 7:53 a.m., Hao Hao wrote

Re: Review Request 55706: SENTRY-1566: Make full Perm/Path snapshot available for NN plugin

delta change in Sentryplugin class. - Hao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55706/#review165043 ----------

Re: Review Request 55706: SENTRY-1566: Make full Perm/Path snapshot available for NN plugin

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55706/#review165043 --- On Feb. 3, 2017, 7:53 a.m., Hao Hao wrote: > > -

Re: Review Request 55706: SENTRY-1566: Make full Perm/Path snapshot available for NN plugin

s does not delete a role if no groups associated with it. Until this gets changed, I do not think we can do in the simplification way. - Hao Hao On Feb. 3, 2017, 7:53 a.m., Hao Hao wrote: > > --- > This is an automatically generated e

Re: Review Request 55706: SENTRY-1566: Make full Perm/Path snapshot available for NN plugin

eviews.apache.org/r/55706/#review164454 ----------- On Feb. 3, 2017, 7:53 a.m., Hao Hao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55706/ > --

Re: Review Request 55706: SENTRY-1566: Make full Perm/Path snapshot available for NN plugin

d you mind I do it in that jira if needed? - Hao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55706/#review164454 ------------

Re: Review Request 55706: SENTRY-1566: Make full Perm/Path snapshot available for NN plugin

ovider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Line 2239 (original), 2291 (patched) <https://reviews.apache.org/r/55706/#comment239530> It is used in line 2393. Am I missing anything? - Hao Hao On Feb. 3, 2017, 7:53 a.m., H

Re: Review Request 55706: SENTRY-1566: Make full Perm/Path snapshot available for NN plugin

/hdfs/PathsUpdate.java Lines 157 (patched) <https://reviews.apache.org/r/55706/#comment239516> I have moved those code to SENTRY-1612 - Hao Hao On Feb. 3, 2017, 7:53 a.m., Hao Hao wrote: > > --- > This is an automatica

Re: Review Request 55706: SENTRY-1566: Make full Perm/Path snapshot available for NN plugin

613. - Hao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55706/#review164467 --- On Feb. 3, 2017, 7:53 a.m., Hao Hao wrote:

Re: Review Request 56709: SENTRY-1569 Added changes to sql scripts persist Perm/Path change Adding missing files

> On Feb. 22, 2017, 1:13 a.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql > > Lines 254 (patched) > > <https://reviews.apache.org/r/56709/diff/1/?file=1634523#file1634523line254> > > > > update t

Re: Review Request 55904: SENTRY-1612: HMSFollower should persist full HMS snapshot into SentryDB if there is not one.

test in TestSentryStore. Revised unit test in TestFullUpdateInitializer. Thanks, Hao Hao

Re: Review Request 55904: SENTRY-1612: HMSFollower should persist full HMS snapshot into SentryDB if there is not one.

test in TestSentryStore. Revised unit test in TestFullUpdateInitializer. Thanks, Hao Hao

Re: Review Request 57065: SENTRY-1600 Define Thrift API for HMS to Sentry notification barrier

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57065/#review167157 --- Ship it! Ship It! - Hao Hao On Feb. 25, 2017, 7:35 a.m

  1   2   3   >