Re: Review Request 65097: SENTRY-2023 Add sentry-shell support for hbase-indexer permissions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65097/ --- (Updated Jan. 16, 2018, 4:33 p.m.) Review request for sentry, Colm O hEigeartai

Re: Review Request 65097: SENTRY-2023 Add sentry-shell support for hbase-indexer permissions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65097/ --- (Updated Jan. 12, 2018, 12:13 a.m.) Review request for sentry, Colm O hEigearta

Review Request 65097: SENTRY-2023 Add sentry-shell support for hbase-indexer permissions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65097/ --- Review request for sentry, Colm O hEigeartaigh and Sergio Pena. Bugs: SENTRY-20

Re: Review Request 64949: SENTRY-641 Add binding for lily hbase indexer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64949/ --- (Updated Jan. 10, 2018, 11:37 p.m.) Review request for sentry. Changes --

Re: Review Request 64949: SENTRY-641 Add binding for lily hbase indexer

> On Jan. 9, 2018, 11:10 p.m., Sergio Pena wrote: > > sentry-policy/sentry-policy-indexer/src/main/java/org/apache/sentry/policy/indexer/IndexerWildcardPrivilege.java > > Line 108 (original), 28 (patched) > > > > > >

Re: Review Request 64949: SENTRY-641 Add binding for lily hbase indexer

> On Jan. 4, 2018, 10:19 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hbase-indexer/src/main/java/org/apache/sentry/binding/hbaseindexer/authz/HBaseIndexerAuthzBinding.java > > Lines 199 (patched) > > > > >

Re: Review Request 64949: SENTRY-641 Add binding for lily hbase indexer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64949/ --- (Updated Jan. 6, 2018, 9:31 p.m.) Review request for sentry. Changes ---

Re: Review Request 64949: SENTRY-641 Add binding for lily hbase indexer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64949/#review194874 --- Created new patch, added to jira. If test-patch passes, uploading

Re: Review Request 64949: SENTRY-641 Add binding for lily hbase indexer

> On Jan. 4, 2018, 8:23 p.m., Steve Moist wrote: > > sentry-binding/sentry-binding-hbase-indexer/src/main/java/org/apache/sentry/binding/hbaseindexer/authz/HBaseIndexerAuthzBinding.java > > Lines 92 (patched) > > > > > >

Re: Review Request 64949: SENTRY-641 Add binding for lily hbase indexer

> On Jan. 4, 2018, 10:19 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hbase-indexer/src/main/java/org/apache/sentry/binding/hbaseindexer/authz/HBaseIndexerAuthzBinding.java > > Lines 187-189 (patched) > > >

Review Request 64949: SENTRY-641 Add binding for lily hbase indexer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64949/ --- Review request for sentry. Bugs: SENTRY-641 https://issues.apache.org/jira/

Re: Review Request 63415: SENTRY-2012 Make SentryShellGeneric extendible

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63415/ --- (Updated Nov. 16, 2017, 6:40 p.m.) Review request for sentry and Colm O hEigear

Re: Review Request 63415: SENTRY-2012 Make SentryShellGeneric extendible

> On Nov. 10, 2017, 10:35 a.m., Colm O hEigeartaigh wrote: > > Minor issues: > > > > a) Make sure there is a space before an opening bracket, e.g.: > > > > SentryShellGeneric: protected String getServiceNameGeneric(Configuration > > conf){ > > > > protected String getServiceName(Configuration

Re: Review Request 63415: SENTRY-2012 Make SentryShellGeneric extendible

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63415/ --- (Updated Nov. 16, 2017, 5:27 p.m.) Review request for sentry and Colm O hEigear

Re: Review Request 63415: SENTRY-2012 Make SentryShellGeneric extendible

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63415/ --- (Updated Nov. 9, 2017, 3:32 p.m.) Review request for sentry and Colm O hEigeart

Re: Review Request 63415: SENTRY-2012 Make SentryShellGeneric extendible

> On Oct. 30, 2017, 10:40 p.m., Alexander Kolbasov wrote: > > This isn't a full review - just looked at some of the changes - probably > > comments apply in other files as well. > > > > The biggest concern - please stay away from Java8-specific features. > > Although there is decision to move

Re: Review Request 63415: SENTRY-2012 Make SentryShellGeneric extendible

> On Oct. 30, 2017, 10:40 p.m., Alexander Kolbasov wrote: > > This isn't a full review - just looked at some of the changes - probably > > comments apply in other files as well. > > > > The biggest concern - please stay away from Java8-specific features. > > Although there is decision to move

Re: Review Request 63415: SENTRY-2012 Make SentryShellGeneric extendible

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63415/ --- (Updated Oct. 31, 2017, 2:20 p.m.) Review request for sentry and Colm O hEigear

Review Request 63415: SENTRY-2012 Make SentryShellGeneric extendible

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63415/ --- Review request for sentry and Colm O hEigeartaigh. Bugs: SENTRY-2012 https:

Re: Review Request 63303: SENTRY-1992 Improve parameter handling for SentryGenericProviderBackend

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63303/ --- (Updated Oct. 27, 2017, 10:26 a.m.) Review request for sentry and Sergio Pena.

Review Request 63303: SENTRY-1992 Improve parameter handling for SentryGenericProviderBackend

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63303/ --- Review request for sentry and Sergio Pena. Bugs: SENTRY-1992 https://issues