---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72882/#review221882
---
Ship it!
Ship It!
- Na Li
On Sept. 17, 2020, 3:40 p.m
----
On July 23, 2020, 8:55 p.m., Na Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72704/
> ---
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72706/#review221345
---
Ship it!
Ship It!
- Na Li
On July 23, 2020, 11:38 p.m
://reviews.apache.org/r/72704/diff/1/
Testing
---
add new unit tests, and they pass
Thanks,
Na Li
/TestMetastoreEndToEndWithSimpleCache.java
PRE-CREATION
Diff: https://reviews.apache.org/r/71942/diff/2/
Changes: https://reviews.apache.org/r/71942/diff/1-2/
Testing
---
Add new tests and they all passed.
Thanks,
Na Li
://reviews.apache.org/r/71942/diff/1/
Testing
---
Add new tests and they all passed.
Thanks,
Na Li
(TestSimplePrivilegeCache.testListPrivilegesPerf)
SimplePrivilegeCache - total time on list obj: 3732 ms
(TestSimplePrivilegeCache.testListPrivilegeObjectsPerf)
Thanks,
Na Li
(TestSimplePrivilegeCache.testListPrivilegesPerf)
SimplePrivilegeCache - total time on list obj: 3732 ms
(TestSimplePrivilegeCache.testListPrivilegeObjectsPerf)
Thanks,
Na Li
91025#file2191025line170>
> >
> > Second argument here is basically is partIndex.
> > You sending a -1 and using it by incrementing by one.
> > Instead, I think you should just pass 0.
>
> Na Li wrote:
> If I pass 0 to the function getChildResourceValue(),
gt; >
> > This way if someone calls this method they would know that it is not
> > supported.
I have added comment in the interface ProviderBackend.
Its caller is ResourceAuthorizationProvider, which does not know what cache to
be used. Throwing exception for each autho
user for each command, and
creates cache to store it. So all authorization checks for this command are
using this cache.
https://github.com/apache/sentry/blob/master/sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBindingHookBase.java#L85
(TestSimplePrivilegeCache.testListPrivilegesPerf)
SimplePrivilegeCache - total time on list obj: 3732 ms
(TestSimplePrivilegeCache.testListPrivilegeObjectsPerf)
Thanks,
Na Li
(TestSimplePrivilegeCache.testListPrivilegesPerf)
SimplePrivilegeCache - total time on list obj: 3732 ms
(TestSimplePrivilegeCache.testListPrivilegeObjectsPerf)
Thanks,
Na Li
(TestSimplePrivilegeCache.testListPrivilegesPerf)
SimplePrivilegeCache - total time on list obj: 3732 ms
(TestSimplePrivilegeCache.testListPrivilegeObjectsPerf)
Thanks,
Na Li
nterface of PrivilegeCache
- Na
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71915/#review219056
---
On Dec. 18, 2019, 4:52 p.m., Na Li
erver1->db=db1->table=t1->column=c1->action=select" for the privilege
CommonPrivilege colSelect = create(new KeyValue("Server", "server1"),
new KeyValue("db", "db1"), new KeyValue("table", "t1"), new
Ke
tabase [name=db_1], Table
[name=tab1], Column [name=*]]]
If the authorizable part is not wildcard, it should only get privileges of that
specific child.
- Na
---
This is an automatically generated e-mail.
(TestSimplePrivilegeCache.testListPrivilegesPerf)
SimplePrivilegeCache - total time on list obj: 3732 ms
(TestSimplePrivilegeCache.testListPrivilegeObjectsPerf)
Thanks,
Na Li
string: 4436 ms
(TestSimplePrivilegeCache.testListPrivilegesPerf)
SimplePrivilegeCache - total time on list obj: 3732 ms
(TestSimplePrivilegeCache.testListPrivilegeObjectsPerf)
Thanks,
Na Li
(TestSimplePrivilegeCache.testListPrivilegeObjectsPerf)
Thanks,
Na Li
)
SimplePrivilegeCache - total time on list string: 4436 ms
(TestSimplePrivilegeCache.testListPrivilegesPerf)
SimplePrivilegeCache - total time on list obj: 3732 ms
(TestSimplePrivilegeCache.testListPrivilegeObjectsPerf)
Thanks,
Na Li
(TestSimplePrivilegeCache.testListPrivilegeObjectsPerf)
Thanks,
Na Li
obj: 3732 ms
(TestSimplePrivilegeCache.testListPrivilegeObjectsPerf)
Thanks,
Na Li
(TestTreePrivilegeCache.testListPrivilegeObjectsPerf)
SimplePrivilegeCache - total time on list string: 4436 ms
(TestSimplePrivilegeCache.testListPrivilegesPerf)
SimplePrivilegeCache - total time on list obj: 3732 ms
(TestSimplePrivilegeCache.testListPrivilegeObjectsPerf)
Thanks,
Na Li
see only select action is used
for authorization check
Thanks,
Na Li
matically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71901/#review219015
---
On Dec. 13, 2019, 12:23 a.m., Na Li wrote:
>
> ---
> This is an automatically generate
see only select action is used
for authorization check
Thanks,
Na Li
://reviews.apache.org/r/71901/diff/1/
Testing
---
manually set the configuration to be true, and see only select action is used
for authorization check
Thanks,
Na Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71838/#review218892
---
Ship it!
Ship It!
- Na Li
On Nov. 27, 2019, 4:28 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70846/#review215909
---
Ship it!
Ship It!
- Na Li
On June 14, 2019, 2:58 p.m
ntry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtFunctionScope.java
Line 120 (original), 123 (patched)
<https://reviews.apache.org/r/70846/#comment302843>
can you add test case for creating function fail due to not having
pr
entry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
38b4c87
Diff: https://reviews.apache.org/r/70068/diff/4/
Changes: https://reviews.apache.org/r/70068/diff/3-4/
Testing
---
add new tests and all old tests in TestSentryStore pass
Thanks,
Na Li
entry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
38b4c87
Diff: https://reviews.apache.org/r/70068/diff/3/
Changes: https://reviews.apache.org/r/70068/diff/2-3/
Testing
---
add new tests and all old tests in TestSentryStore pass
Thanks,
Na Li
entry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
38b4c87
Diff: https://reviews.apache.org/r/70068/diff/2/
Changes: https://reviews.apache.org/r/70068/diff/1-2/
Testing
---
add new tests and all old tests in TestSentryStore pass
Thanks,
Na Li
e/sentry/provider/db/service/persistent/TestSentryStore.java
38b4c87
Diff: https://reviews.apache.org/r/70068/diff/1/
Testing
---
add new tests and all old tests in TestSentryStore pass
Thanks,
Na Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70043/#review213102
---
Ship it!
Ship It!
- Na Li
On Feb. 22, 2019, 6:40 p.m
/hdfs/HMSPaths.java
Lines 507 (patched)
<https://reviews.apache.org/r/70043/#comment298962>
should this be removed if it has no authz obj?
Why change its type to DIR?
- Na Li
On Feb. 22, 2019, 6:40 p.m., kalyan kumar kalvagadda
from the set it will be found/delted."?
Your change has performance penalty. Do you have an idea how big the
performance degradation could it be? and will we be able to accept that?
- Na Li
On Feb. 22, 2019, 6:40 p.m., kal
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69987/#review213085
---
Ship it!
Ship It!
- Na Li
On Feb. 21, 2019, 8:17 p.m
/main/java/org/apache/sentry/binding/metastore/SentryMetaStoreFilterHook.java
312c5db
Diff: https://reviews.apache.org/r/70013/diff/2/
Changes: https://reviews.apache.org/r/70013/diff/1-2/
Testing
---
existing HMS tests succeeded
Thanks,
Na Li
reading database and
tables.
Thanks,
Na Li
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70013/#review212962
-----------
On Feb. 19, 2019, 9:59 p.m., Na Li wrote:
>
> ---
&g
/SentryMetaStoreFilterHook.java
312c5db
Diff: https://reviews.apache.org/r/70013/diff/1/
Testing
---
existing HMS tests succeeded
Thanks,
Na Li
reading database and
tables.
Thanks,
Na Li
: https://reviews.apache.org/r/70008/diff/3/
Changes: https://reviews.apache.org/r/70008/diff/2-3/
Testing
---
existing tests for metastore, and add two new tests for reading database and
tables.
Thanks,
Na Li
: https://reviews.apache.org/r/70008/diff/2/
Changes: https://reviews.apache.org/r/70008/diff/1-2/
Testing
---
existing tests for metastore, and add two new tests for reading database and
tables.
Thanks,
Na Li
-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestMetastoreEndToEnd.java
6327f16
Diff: https://reviews.apache.org/r/70008/diff/1/
Testing
---
existing tests for metastore, and add two new tests for reading database and
tables.
Thanks,
Na Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69924/#review212802
---
Ship it!
Ship It!
- Na Li
On Feb. 7, 2019, 11:47 p.m., Hao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69536/#review212797
---
Ship it!
Ship It!
- Na Li
On Feb. 7, 2019, 1:04 a.m., Hao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69076/#review212599
---
Ship it!
Ship It!
- Na Li
On Jan. 29, 2019, 9:09 p.m
to wait for my addition approval before commiting the change
- Na Li
On Dec. 17, 2018, 5:07 p.m., Arjun Mishra wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69573/#review212597
---
Ship it!
Ship It!
- Na Li
On Dec. 17, 2018, 5:07 p.m
READ_TABLE at HMS
Thanks,
Na Li
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69702/#review212291
---
On Jan. 29, 2019, 4:15 p.m., Na Li wro
ly, visit:
https://reviews.apache.org/r/69702/#review212291
-------
On Jan. 29, 2019, 4:15 p.m., Na Li wrote:
>
> ---
> This is an automatically generated e-mail. To re
READ_TABLE at HMS
Thanks,
Na Li
READ_TABLE at HMS
Thanks,
Na Li
/sentry/tests/e2e/metastore/TestMetastoreEndToEnd.java
f8f304f
Diff: https://reviews.apache.org/r/69702/diff/5/
Changes: https://reviews.apache.org/r/69702/diff/4-5/
Testing
---
add new e2e tests for READ_DATABASE and READ_TABLE at HMS
Thanks,
Na Li
iff: https://reviews.apache.org/r/69841/diff/2/
Changes: https://reviews.apache.org/r/69841/diff/1-2/
Testing
---
Tested manually and verified the user name now is "sentry" when sentry
HMSFollower gets notifications from HMS server
Thanks,
Na Li
}
> >
> > ```
> > All you have additionally do is change the tests to run sentry server as
> > user “sentry”.
> >
> > Here is the sample code. I have tested it locally.
>
> Na Li wrote:
> HiveSimpleConnectionFactory is used by HMSFollower to ge
line150>
> >
> > You are adding 250 msec delay. Is it good enough?
> >
> > There are few tests that have sentryServers.size()> 1, so we should be
> > good even with higher delay.
> >
> >
> > Based on your test
Diff: https://reviews.apache.org/r/69840/diff/3/
Changes: https://reviews.apache.org/r/69840/diff/2-3/
Testing
---
such deadlock does not happen with this fix.
Other unit tests passed
Thanks,
Na Li
}
> >
> > ```
> > All you have additionally do is change the tests to run sentry server as
> > user “sentry”.
> >
> > Here is the sample code. I have tested it locally.
>
> Na Li wrote:
> HiveSimpleConnectionFactory is used by HMSFollower to ge
e this solution here. Make sure the user is "sentry" in
insecured mode, and add "sentry" as services in HMS server.
- Na
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69
Diff: https://reviews.apache.org/r/69840/diff/2/
Changes: https://reviews.apache.org/r/69840/diff/1-2/
Testing
---
such deadlock does not happen with this fix.
Other unit tests passed
Thanks,
Na Li
- Na
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69840/#review212353
-------
On Jan. 25, 2019, 9:30 p.m., Na Li wrote:
>
> -
Testing
---
Tested manually and verified the user name now is "sentry" when sentry
HMSFollower gets notifications from HMS server
Thanks,
Na Li
iff/1/
Testing
---
such deadlock does not happen with this fix.
Other unit tests passed
Thanks,
Na Li
/
Testing
---
add new e2e tests for READ_DATABASE and READ_TABLE at HMS
Thanks,
Na Li
Kakyan,
Thanks for getting this done!
Lina
On Fri, Jan 18, 2019 at 2:42 PM Kalyan Kumar Kalvagadda
wrote:
> Hello all,
>
>
> Here are the steps to start using the new sentry repository.
>
>
> There are two ways to use the repo
>
> 1. Use Github to push. (*Current process followed*)
>
> 2. Use
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69353/#review212150
---
Ship it!
Ship It!
- Na Li
On Dec. 18, 2018, 11:23 p.m
s pass. I have created SENTRY-2486 to fix this bug correctly
- Na Li
On Jan. 11, 2019, 4:55 a.m., Na Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://
r to bypass
authoriozation check at readiong metadata.
The value of realm is not important as only short user name is checked.
- Na Li
On Jan. 11, 2019, 4:55 a.m., Na Li wrote:
>
> ---
> This is an automatically generated e-m
/sentry/tests/e2e/minisentry/InternalSentrySrv.java
9fa42f2
Diff: https://reviews.apache.org/r/69702/diff/3/
Changes: https://reviews.apache.org/r/69702/diff/2-3/
Testing
---
add new e2e tests for READ_DATABASE and READ_TABLE at HMS
Thanks,
Na Li
://reviews.apache.org/r/69702/diff/1-2/
Testing
---
add new e2e tests for READ_DATABASE and READ_TABLE at HMS
Thanks,
Na Li
---
add new e2e tests for READ_DATABASE and READ_TABLE at HMS
Thanks,
Na Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69620/#review211680
---
Ship it!
Ship It!
- Na Li
On Dec. 21, 2018, 5:39 p.m
lue is
"org.apache.hadoop.hive.metastore.ObjectStore". Setting it here would make it
more obvious what implementation is used.
- Na Li
On Dec. 21, 2018, 5:39 p.m., Sergio Pena wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
ve.metastore.ObjectStore". In this way, we can
test the real sentry-hive integration.
On the other hand, you need fix of HIVE-20776 in order to make the test
work.
- Na Li
On Dec. 21, 2018, 5:39 p.m., Sergio Pena wrote:
>
> --
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69620/#review211585
---
- Na Li
On Dec. 21, 2018, 5:39 p.m., Sergio Pena wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69586/#review211441
---
Ship it!
Ship It!
- Na Li
On Dec. 19, 2018, 3:24 p.m
apache/sentry/binding/metastore/SentryMetaStoreFilterHook.java
Lines 115 (patched)
<https://reviews.apache.org/r/69586/#comment296490>
should we keep the username case? see
https://issues.apache.org/jira/browse/SENTRY-2432
- Na Li
On Dec. 18, 2018, 7:28 p.m., Sergi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69567/#review211335
---
Ship it!
Ship It!
- Na Li
On Dec. 13, 2018, 9:10 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69501/#review211250
---
Ship it!
Ship It!
- Na Li
On Dec. 3, 2018, 5:22 p.m., Arjun
Sergio,
I prefer to move it sooner. Otherwise, we could forget when busy working on
other issues.
Thanks,
Lina
On Tue, Dec 11, 2018 at 3:11 PM Sergio Pena
wrote:
> Hey team, the Sentry project is part of the git-wip.
> Do we want to move sooner and or later?
>
> - Sergio
>
> -- Forwar
/sentry/provider/db/service/persistent/NotificationProcessor.java
Lines 418 (patched)
<https://reviews.apache.org/r/69536/#comment296098>
Can you make comment more explicit on path info is not complete?
- Na Li
On Dec. 10, 2018, 2:21 a.m., Hao Hao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69087/#review211169
---
Ship it!
Ship It!
- Na Li
On Nov. 29, 2018, 10:14 p.m
is no path
info, but if the table name is changed, the privilege is moved to table of new
name?
- Na Li
On Dec. 10, 2018, 2:21 a.m., Hao Hao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
entries of same
path_name, but different authzObj. And make sure you don't delete entries of
different authzObj value.
- Na Li
On Dec. 10, 2018, 2:11 a.m., Arjun Mishra wrote:
>
> ---
> This is an automatically generated e-
vice/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
Lines 3739 (patched)
<https://reviews.apache.org/r/69530/#comment296075>
path is a collection. Can you change the input paramete
istent/SentryStore.java
Lines 3943 (patched)
<https://reviews.apache.org/r/69353/#comment296044>
You don't fetch users of that privilege. Do you want to return that? If the
caller does not want it, it can be dropped. Or let a input indicating if we
want to get users as well
- Na Li
On De
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69353/#review28
---
typo: "sentrys tore" should be "sentry store&quo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69352/#review27
---
Ship it!
Ship It!
- Na Li
On Dec. 7, 2018, 3:14 p.m
)
<https://reviews.apache.org/r/69351/#comment295816>
is this change intentially?
sentry-dist/src/license/THIRD-PARTY.properties
Line 37 (original), 37 (patched)
<https://reviews.apache.org/r/69351/#comment295815>
is this change intentially?
- Na Li
On Nov. 29, 20
> On Nov. 29, 2018, 6:44 p.m., Na Li wrote:
> > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java
> > Lines 176 (patched)
> > <https://reviews.apache.org/r/69087/diff/10/?file=2111053#file2111053line182&
/sentry/provider/db/service/model/MAuthzPathsMapping.java
Lines 176 (patched)
<https://reviews.apache.org/r/69087/#comment295778>
do you want to clear pathsToPersist after persisting them? Otherwise, next
time it is called, those paths will be added again
- Na Li
On Nov. 29, 2018, 6:
/sentry/provider/db/service/model/MAuthzPathsMapping.java
Line 78 (original), 88 (patched)
<https://reviews.apache.org/r/69087/#comment295777>
this seems to be a bug. If paths contains path_1, and caller adds path_2,
this change results in paths contains only path_2, but lost path_1.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69351/#review210930
---
Ship it!
Ship It!
- Na Li
On Nov. 27, 2018, 3:32 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69448/#review210909
---
Ship it!
Ship It!
- Na Li
On Nov. 27, 2018, 9:34 p.m
> On Nov. 26, 2018, 7:44 p.m., Na Li wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/UpdatableCache.java
> > Line 37 (original), 37 (patched)
> > <https://reviews.apache.org/r/69448/diff/1/?file=2110388#file2110388line37&
1 - 100 of 1132 matches
Mail list logo
