Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/#review196651 --- Ship it! Ship It! - Vadim Spector On Jan. 30, 2018, 1:08 a.m

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

> On Jan. 25, 2018, 11:42 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java > > Line 235 (original), 270 (patched) > > > > > >

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/#review196297 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

> On Jan. 25, 2018, 4:16 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/TransactionManager.java > > Line 231 (original), 246 (patched) > >

Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

> On Jan. 25, 2018, 4:16 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/TransactionManager.java > > Line 231 (original), 246 (patched) > >

Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65268/#review196083 --- Ship it! Ship It! - Vadim Spector On Jan. 23, 2018, 11:40 p.

Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65268/#review196078 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

> On Jan. 22, 2018, 8:49 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java > > Lines 67 (patched) > > > > > > I wonder about

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

> On Jan. 22, 2018, 8:49 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java > > Lines 67 (patched) > > > > > > I wonder about

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/#review195917 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/#review195758 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 64820: SENTRY-2106: Remove sentry dependency on HMS table NOTIFICATION_SEQUENCE when checking if Sentry is out-of-sync with HMS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/#review195750 --- Ship it! Ship It! - Vadim Spector On Jan. 16, 2018, 3:50 p.m

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

> On Jan. 4, 2018, 10:40 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Line 205 (original), 206 (patched) > > > > > > I thought

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/#review194788 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 64820: SENTRY-2106: Sentry ahead full snapshot retry logic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/#review194500 --- Ship it! Ship It! - Vadim Spector On Dec. 25, 2017, 10:49 p.

Re: Review Request 64820: SENTRY-2106: Sentry ahead full snapshot retry logic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/#review194489 --- Seems like I have no problems with the code once my comments in th

Re: Review Request 64820: SENTRY-2106: Sentry ahead full snapshot retry logic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/#review194479 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 64820: SENTRY-2106: Sentry ahead full snapshot retry logic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/#review194476 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 64820: SENTRY-2106: Sentry ahead full snapshot retry logic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/#review194475 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 64820: SENTRY-2106: Sentry ahead full snapshot retry logic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/#review194474 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 64820: SENTRY-2106: Sentry ahead full snapshot retry logic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64820/#review194472 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/#review194174 --- Ship it! Ship It! - Vadim Spector On Dec. 19, 2017, 8:04 p.m

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/#review194079 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 64452: SENTRY-2091: User-based Privilege is broken by SENTRY-769

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64452/#review193992 --- sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry

Re: Review Request 64545: SENTRY-2078: Have sentry server print an obvious INFO level log message when it becomes the writer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64545/#review193707 --- Ship it! Ship It! - Vadim Spector On Dec. 13, 2017, 5:45 p.m

Re: Review Request 64545: SENTRY-2078: Have sentry server print an obvious INFO level log message when it becomes the writer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64545/#review193591 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63881/#review193045 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

> On Dec. 5, 2017, 11:25 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Line 420 (original), 430 (patched) > > > > > > Use `

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

> On Dec. 5, 2017, 11:25 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 377 (patched) > > > > > > Will someone up the

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63881/#review192934 --- Ship it! Ship It! - Vadim Spector On Dec. 5, 2017, 9:02 p.m.

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63881/#review192914 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63881/#review192387 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

> On Nov. 28, 2017, 10:16 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > > Line 2514 (original), 2513 (patched) > >

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63596/#review192068 --- sentry-provider/sentry-provider-db/src/test/java/org/apache/sentr

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

> On Nov. 28, 2017, 10:16 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > > Line 2514 (original), 2513 (patched) > >

Re: Review Request 63975: SENTRY-2066: DB name is not set for AlterTable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63975/#review191564 --- sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/te

Re: Review Request 63886: SENTRY-2047: isTableEmptyCore method in SentryStore has references to MAuthzPathsMapping when it should be generic

> On Nov. 16, 2017, 8:14 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Line 3251 (original), 3251 (patched) > > > >

Re: Review Request 63886: SENTRY-2047: isTableEmptyCore method in SentryStore has references to MAuthzPathsMapping when it should be generic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63886/#review191251 --- Ship it! Ship It! - Vadim Spector On Nov. 16, 2017, 7:29 p.m

Re: Review Request 63645: SENTRY-2032: Leading Slashes need to removed when creating HMS path entries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63645/#review191247 --- Ship it! Ship It! - Vadim Spector On Nov. 16, 2017, 8:38 p.m

Re: Review Request 63886: SENTRY-2047: isTableEmptyCore method in SentryStore has references to MAuthzPathsMapping when it should be generic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63886/#review191238 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 63645: SENTRY-2032: Leading Slashes need to removed when creating HMS path entries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63645/#review191214 --- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/co

Re: Review Request 63646: SENTRY-2035: Metrics should move to destination atomically

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63646/#review190414 --- Ship it! Ship It! - Vadim Spector On Nov. 7, 2017, 9:47 p.m.

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

> On Nov. 6, 2017, 10:11 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > > Lines 2453 (patched) > > > > > > In

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63596/#review190231 --- sentry-provider/sentry-provider-db/src/test/java/org/apache/sentr

Re: Review Request 63086: SENTRY-1993: StringIndexOutOfBoundsException in HMSPathsDumper.java

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63086/#review188866 --- Ship it! New patch added call to hmsPaths.addPathsToAuthzObject

Re: Review Request 63086: SENTRY-1993: StringIndexOutOfBoundsException in HMSPathsDumper.java

> On Oct. 18, 2017, 2:44 p.m., Vadim Spector wrote: > > Ship It! I'll proceed with commit today - Vadim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63086/#review188492 ---

Re: Review Request 63086: SENTRY-1993: StringIndexOutOfBoundsException in HMSPathsDumper.java

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63086/#review188492 --- Ship it! Ship It! - Vadim Spector On Oct. 17, 2017, 7:12 p.m