Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

> On July 27, 2016, 9:37 p.m., Rahul Sharma wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestFailover.java, > > line 47 > > > > > > Are you making that configurable

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

> On July 27, 2016, 9:37 p.m., Rahul Sharma wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestFailover.java, > > line 47 > > > > > > Are you making that configurable

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

> On July 26, 2016, 6:39 p.m., Anne Yu wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestActivator.java, > > line 42 > > > > > > It would be better to test

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

> On July 26, 2016, 7:16 p.m., Anne Yu wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestFailover.java, > > line 47 > > > > > > Will it be possible to have more than 2

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

> On July 26, 2016, 7:16 p.m., Anne Yu wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestFailover.java, > > line 47 > > > > > > Will it be possible to have more than 2

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

> On July 26, 2016, 6:39 p.m., Anne Yu wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestActivator.java, > > line 42 > > > > > > It would be better to test

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50404/#review143588 ---

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50404/#review143579 ---

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

> On July 25, 2016, 8:37 p.m., Sravya Tirukkovalur wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatus.java, > > line 140 > > > > > > It is not clear to me what

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50404/#review143423 --- Awesome work Rahul! Left minor comments.

Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50404/ --- Review request for sentry, Anne Yu and Sravya Tirukkovalur. Repository: sentry