Re: Review Request 50611: Sentry HA Test: programmatic failover, validate privileges before and afterwards.

2016-08-18 Thread Dapeng Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50611/#review146165 --- Thank Anne, I have no more question. - Dapeng Sun On 八月 17,

Re: Review Request 50611: Sentry HA Test: programmatic failover, validate privileges before and afterwards.

2016-08-18 Thread Anne Yu
> On Aug. 18, 2016, 2:29 a.m., Dapeng Sun wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java, > > line 200 > > > > > > >>One qq here, in mini-cluster

Re: Review Request 50611: Sentry HA Test: programmatic failover, validate privileges before and afterwards.

2016-08-17 Thread Anne Yu
> On Aug. 17, 2016, 2:48 a.m., Dapeng Sun wrote: > > Thank Anne for your patch, I left some minor comments. Thanks Dapeng. > On Aug. 17, 2016, 2:48 a.m., Dapeng Sun wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java, > > line 114 > >

Re: Review Request 50611: Sentry HA Test: programmatic failover, validate privileges before and afterwards.

2016-08-16 Thread Dapeng Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50611/#review145951 --- Thank Anne for your patch, I left some minor comments.

Re: Review Request 50611: Sentry HA Test: programmatic failover, validate privileges before and afterwards.

2016-08-16 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50611/ --- (Updated Aug. 16, 2016, 6:17 p.m.) Review request for sentry, Hao Hao and

Re: Review Request 50611: Sentry HA Test: programmatic failover, validate privileges before and afterwards.

2016-07-29 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50611/ --- (Updated July 29, 2016, 8:03 p.m.) Review request for sentry, Hao Hao and

Re: Review Request 50611: Sentry HA Test: programmatic failover, validate privileges before and afterwards.

2016-07-29 Thread Anne Yu
> On July 29, 2016, 6:26 p.m., Rahul Sharma wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestProgrammaticFailover.java, > > lines 117-120 > > > > > > how is the boolean

Re: Review Request 50611: Sentry HA Test: programmatic failover, validate privileges before and afterwards.

2016-07-29 Thread Rahul Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50611/#review144144 ---