Re: Review Request 59869: SENTRY-1796: Add better debug logging for retrieving the delta changes

2017-06-13 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59869/#review177861 --- Ship it! Ship It! - Alexander Kolbasov On June 14, 2017, 12:

Re: Review Request 59869: SENTRY-1796: Add better debug logging for retrieving the delta changes

2017-06-13 Thread Vamsee Yarlagadda
> On June 12, 2017, 11:32 p.m., Alexander Kolbasov wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SentryUtils.java > > Lines 40 (patched) > > > > > > Would it make sense to

Re: Review Request 59869: SENTRY-1796: Add better debug logging for retrieving the delta changes

2017-06-13 Thread Alexander Kolbasov
> On June 12, 2017, 11:32 p.m., Alexander Kolbasov wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SentryUtils.java > > Lines 40 (patched) > > > > > > Would it make sense to

Re: Review Request 59869: SENTRY-1796: Add better debug logging for retrieving the delta changes

2017-06-13 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59869/ --- (Updated June 14, 2017, 12:31 a.m.) Review request for sentry, Alexander Kolbas

Re: Review Request 59869: SENTRY-1796: Add better debug logging for retrieving the delta changes

2017-06-13 Thread Vamsee Yarlagadda
> On June 12, 2017, 11:32 p.m., Alexander Kolbasov wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SentryUtils.java > > Lines 40 (patched) > > > > > > Would it make sense to

Re: Review Request 59869: SENTRY-1796: Add better debug logging for retrieving the delta changes

2017-06-12 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59869/#review177680 --- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/co

Re: Review Request 59869: SENTRY-1796: Add better debug logging for retrieving the delta changes

2017-06-09 Thread Vamsee Yarlagadda
> On June 9, 2017, 7:55 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Line 3760 (original), 3764 (patched) > >

Re: Review Request 59869: SENTRY-1796: Add better debug logging for retrieving the delta changes

2017-06-09 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59869/ --- (Updated June 9, 2017, 11:22 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 59869: SENTRY-1796: Add better debug logging for retrieving the delta changes

2017-06-09 Thread Vamsee Yarlagadda
> On June 9, 2017, 7:55 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUtil.java > > Lines 53 (patched) > > > > > > do you neeed

Re: Review Request 59869: SENTRY-1796: Add better debug logging for retrieving the delta changes

2017-06-09 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59869/ --- (Updated June 9, 2017, 9:38 p.m.) Review request for sentry, Alexander Kolbasov

Re: Review Request 59869: SENTRY-1796: Add better debug logging for retrieving the delta changes

2017-06-09 Thread Vamsee Yarlagadda
> On June 9, 2017, 7:55 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUtil.java > > Lines 72 (patched) > > > > > > This is not

Re: Review Request 59869: SENTRY-1796: Add better debug logging for retrieving the delta changes

2017-06-09 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59869/#review177446 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 59869: SENTRY-1796: Add better debug logging for retrieving the delta changes

2017-06-08 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59869/ --- (Updated June 9, 2017, 1:35 a.m.) Review request for sentry, Alexander Kolbasov

Re: Review Request 59869: SENTRY-1796: Add better debug logging for retrieving the delta changes

2017-06-08 Thread Vamsee Yarlagadda
> On June 8, 2017, 5:16 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUtil.java > > Lines 145 (patched) > > > > > > There shou

Re: Review Request 59869: SENTRY-1796: Add better debug logging for retrieving the delta changes

2017-06-08 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59869/ --- (Updated June 9, 2017, 1:01 a.m.) Review request for sentry, Alexander Kolbasov

Re: Review Request 59869: SENTRY-1796: Add better debug logging for retrieving the delta changes

2017-06-08 Thread Vamsee Yarlagadda
> On June 8, 2017, 5:16 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUtil.java > > Lines 139 (patched) > > > > > > Would the

Re: Review Request 59869: SENTRY-1796: Add better debug logging for retrieving the delta changes

2017-06-07 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59869/#review177277 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 59869: SENTRY-1796: Add better debug logging for retrieving the delta changes

2017-06-07 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59869/ --- (Updated June 8, 2017, 1:05 a.m.) Review request for sentry, Alexander Kolbasov

Re: Review Request 59869: SENTRY-1796: Add better debug logging for retrieving the delta changes

2017-06-07 Thread Alexander Kolbasov
> On June 7, 2017, 9:56 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUtil.java > > Lines 59 (patched) > > > > > > It seems tha

Re: Review Request 59869: SENTRY-1796: Add better debug logging for retrieving the delta changes

2017-06-07 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59869/ --- (Updated June 7, 2017, 11:09 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 59869: SENTRY-1796: Add better debug logging for retrieving the delta changes

2017-06-07 Thread Vamsee Yarlagadda
- Vamsee --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59869/#review177229 --- On June 7, 2017, 10:21 p.m., Vamsee Yarlagadda wrote: >

Re: Review Request 59869: SENTRY-1796: Add better debug logging for retrieving the delta changes

2017-06-07 Thread Vamsee Yarlagadda
> On June 7, 2017, 9:56 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUtil.java > > Lines 59 (patched) > > > > > > It seems tha

Re: Review Request 59869: SENTRY-1796: Add better debug logging for retrieving the delta changes

2017-06-07 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59869/ --- (Updated June 7, 2017, 10:21 p.m.) Review request for sentry, Alexander Kolbaso