---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63415/#review191314
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On Nov. 16, 2017, 6:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63415/
---
(Updated Nov. 16, 2017, 6:40 p.m.)
Review request for sentry and Colm O hEigear
> On Nov. 10, 2017, 10:35 a.m., Colm O hEigeartaigh wrote:
> > Minor issues:
> >
> > a) Make sure there is a space before an opening bracket, e.g.:
> >
> > SentryShellGeneric: protected String getServiceNameGeneric(Configuration
> > conf){
> >
> > protected String getServiceName(Configuration
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63415/
---
(Updated Nov. 16, 2017, 5:27 p.m.)
Review request for sentry and Colm O hEigear
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63415/#review190689
---
Minor issues:
a) Make sure there is a space before an opening bra
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63415/
---
(Updated Nov. 9, 2017, 3:32 p.m.)
Review request for sentry and Colm O hEigeart
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63415/#review190501
---
Overall looks good, some style nits/comments. Colm is also poking
> On Oct. 30, 2017, 10:40 p.m., Alexander Kolbasov wrote:
> > This isn't a full review - just looked at some of the changes - probably
> > comments apply in other files as well.
> >
> > The biggest concern - please stay away from Java8-specific features.
> > Although there is decision to move
> On Oct. 30, 2017, 10:40 p.m., Alexander Kolbasov wrote:
> > This isn't a full review - just looked at some of the changes - probably
> > comments apply in other files as well.
> >
> > The biggest concern - please stay away from Java8-specific features.
> > Although there is decision to move
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63415/
---
(Updated Oct. 31, 2017, 2:20 p.m.)
Review request for sentry and Colm O hEigear
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63415/#review189652
---
This isn't a full review - just looked at some of the changes - pr
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63415/
---
Review request for sentry and Colm O hEigeartaigh.
Bugs: SENTRY-2012
https:
12 matches
Mail list logo
