?????? [DISCUSS] Require the review before merging the PR

2019-04-03 Thread bismy
e: [DISCUSS] Require the review before merging the PR +1 zhang_...@boco.com.cn ??2019??4??3?? 3:25?? > +1 > > > ?? 2019??4??32:55??Zheng Feng ?? > > > > Hi, > > > > I just wonder if we can enable this setting [1] on servicecomb-pack [2

Re: [DISCUSS] Require the review before merging the PR

2019-04-03 Thread wjm wjm
+1 zhang_...@boco.com.cn 于2019年4月3日周三 下午3:25写道: > +1 > > > 在 2019年4月3日,下午2:55,Zheng Feng 写道: > > > > Hi, > > > > I just wonder if we can enable this setting [1] on servicecomb-pack [2] > and > > it could be helpful when reviewing the PR. I think at least one people > > review the changes and

Re: [DISCUSS] Require the review before merging the PR

2019-04-03 Thread zhang_...@boco.com.cn
+1 > 在 2019年4月3日,下午2:55,Zheng Feng 写道: > > Hi, > > I just wonder if we can enable this setting [1] on servicecomb-pack [2] and > it could be helpful when reviewing the PR. I think at least one people > review the changes and approve before merging it. We have to raise a JIRA > for the infra

Re: [DISCUSS] Require the review before merging the PR

2019-04-03 Thread Willem Jiang
+1 for it. We could start from servicecomb-pack project first. We could enable this feature for the other sub projects if it goes well. Any thoughts? Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Wed, Apr 3, 2019 at 2:56 PM Zheng Feng wrote: > > Hi, > > I just wonder if we can enable

[DISCUSS] Require the review before merging the PR

2019-04-03 Thread Zheng Feng
Hi, I just wonder if we can enable this setting [1] on servicecomb-pack [2] and it could be helpful when reviewing the PR. I think at least one people review the changes and approve before merging it. We have to raise a JIRA for the infra team to do this setting. So I post this message here to