Re:Re: HA of Apache ShardingSphere(incubator) work plans

2020-02-09 Thread 秦金卫
Yes, we will follow the metadata issue after config and registry issues done. At 2020-02-08 11:31:38, "zhaojun" wrote: >sure, kim and haoran will follow the metadata issue in future > >-- >Zhao Jun (cherrylzhao) >Apache ShardingSphere & ServiceComb > >> On Feb 8, 2020, at 10:59

Re:Re: [DISCUSS] 4.0.1 stable version release plan

2020-02-09 Thread KimmKing
Hi, Jun: I and yonglun/tuohai666 had added travis ci config to 4.0.1 several days ago with PR#4203. But I don't know it should be added to change logs or not. At 2020-02-10 14:43:57, "zhaojun" wrote: >Hi, all > >The latest change logs is as below > >## Bug fixes > >3956 using guava cache to

Re: [DISCUSS] 4.0.1 stable version release plan

2020-02-09 Thread zhaojun
Hi, all The latest change logs is as below ## Bug fixes 3956 using guava cache to fix parsing deadlock probleam 3975 oracle insert SQL could not work in encrypt mode 3997 proxy for PostgreSQL decode parameters error in all types except String 4004 COM_STM_EXECUTE of MySQL could not support

Re: [DISCUSS] 4.0.1 stable version release plan

2020-02-09 Thread Zonglei Dong
Hi Zhao Jun, OK, I understand, Thanks. Zonglei Dong Apache ShardingSphere On 02/10/2020 13:59,zhaojun wrote: I suggest we can merge the 3918’s PR and not care of the Metadata model’s redesign right now, because if we don’t merge it, user may be always meet this bug in 4.x’s version. In

Re: [DISCUSS] 4.0.1 stable version release plan

2020-02-09 Thread zhaojun
> Should we add the fix of Issue#4182[1] into 4.0.1? Thanks for feedback, tuohai666 have just merged it to 4.0.1, I will update the change log later -- Zhao Jun (cherrylzhao) Apache ShardingSphere & ServiceComb

Re: [DISCUSS] 4.0.1 stable version release plan

2020-02-09 Thread zhaojun
> I suggest we can merge the 3918’s PR and not care of the Metadata model’s > redesign right now, > because if we don’t merge it, user may be always meet this bug in 4.x’s > version. In fact, get resultsSet using logicTable will lead to sharding-encrypt not available. See the bug issue 3995

Re: [DISCUSS] 4.0.1 stable version release plan

2020-02-09 Thread zhaojun
> We can change issues #3956 and #4004 as bug, and keep #4054 and #4205 as > enhancement. Agree with it -- Zhao Jun (cherrylzhao) Apache ShardingSphere & ServiceComb

Re: [DISCUSS] 4.0.1 stable version release plan

2020-02-09 Thread Juan Pan
This release is mainly to do bug fix and some little optimizations for our Release 4.0.0, right? I am in charge of sharding-parser, and plan it for our release 5.x. Anything if i could do, please tell me. Juan Pan (Trista) Senior DBA & PPMC of Apache

Re: [DISCUSS] 4.0.1 stable version release plan

2020-02-09 Thread zhangli...@apache.org
We can change issues #3956 and #4004 as bug, and keep #4054 and #4205 as enhancement. -- Liang Zhang (John) Apache ShardingSphere & Dubbo zhangli...@apache.org 于2020年2月10日周一 上午11:45写道: > The enhancement has a little more in name than in reality. Maybe we need > change all

Re: [DISCUSS] 4.0.1 stable version release plan

2020-02-09 Thread zhangli...@apache.org
The enhancement has a little more in name than in reality. Maybe we need change all enhancement tags to bug tags. -- Liang Zhang (John) Apache ShardingSphere & Dubbo Zonglei Dong 于2020年2月10日周一 上午9:57写道: > Hi Zhao Jun, > > > I was participated in discussing the 3918[1], I

Re: [DISCUSS] 4.0.1 stable version release plan

2020-02-09 Thread Zhang Yonglun
I have merged all my 5.0.0 PRs to 4.0.1. I suggest all committers check theirs to avoid miss. 5.0.0 #3861, PostgreSQL Proxy read parameters error in all types except String #3968, Ambiguous description of COM_STMT_EXECUTE in MySQL protocol #4042, Use the two-stage parsing strategy recall travis

Re: [DISCUSS] 4.0.1 stable version release plan

2020-02-09 Thread Zonglei Dong
Hi Zhao Jun, I was participated in discussing the 3918[1], I agree with that Metadata model’s redesign is a big refactor 3922[2] I suggest we can merge the 3918’s PR and not care of the Metadata model’s redesign right now, because if we don’t merge it, user may be always meet this bug in

Re:[DISCUSS] 4.0.1 stable version release plan

2020-02-09 Thread Sion Yang
Should we add the fix of Issue#4182[1] into 4.0.1? [1] https://github.com/apache/incubator-shardingsphere/issues/4182 -- Yi Yang(Sion) Apache ShardingSphere At 2020-02-09 15:44:05, "zhaojun" wrote: >Hi, ShardingSphere community, > >I’d like to be the release manager of 4.0.1 version. >We

Re: [DISCUSS] 4.0.1 stable version release plan

2020-02-09 Thread Sheng Wu
Thanks for the feedback, good to me. Sheng Wu 吴晟 Twitter, wusheng1108 zhaojun 于2020年2月10日周一 上午9:37写道: > > Agree with the principle. > > Do we have substantial changes? From changelog, literally, there is. > > I have review these optimize code, the code change scope is small, > so I think it

Re: [DISCUSS] 4.0.1 stable version release plan

2020-02-09 Thread zhaojun
> Agree with the principle. > Do we have substantial changes? From changelog, literally, there is. I have review these optimize code, the code change scope is small, so I think it was not a substantial changes. -- Zhao Jun (cherrylzhao) Apache ShardingSphere & ServiceComb

Re: [DISCUSS] 4.0.1 stable version release plan

2020-02-09 Thread zhaojun
Hi, Nicholas 3918[1] PR have introduced another bug, see issue 3995[2]. Metada model needs to redesign in 3992[3] This will be a big refactor, so we don’t plan to include it in 4.0.1 [1]: https://github.com/apache/incubator-shardingsphere/pull/3918

Re: [DISCUSS] 4.0.1 stable version release plan

2020-02-09 Thread Sheng Wu
zhaojun 于2020年2月10日周一 上午9:17写道: > Hi, Sheng and guangyuan > > Thanks for kind remind, also I have just google the principle of version > specification. > 4.0.1 is mainly for bug fix and there is no substantial improvements > happened. > Agree with the principle. Do we have substantial changes?

Re: [DISCUSS] 4.0.1 stable version release plan

2020-02-09 Thread zhaojun
Hi, Sheng and guangyuan Thanks for kind remind, also I have just google the principle of version specification. 4.0.1 is mainly for bug fix and there is no substantial improvements happened. 2nd version number means new feature or substantial improvements are introduced. --

Re: [DISCUSS] 4.0.1 stable version release plan

2020-02-09 Thread 蒋晓峰
Hi zhaojun, what about the pull request of https://github.com/apache/incubator-shardingsphere/pull/3918? I thought that this pull request is necessary to 4.0.1 version. Thanks, Nicholas Jiang On Sun, Feb 9, 2020 at 3:44 PM zhaojun wrote: > Hi, ShardingSphere community, > > I’d like to be

Re: [DISCUSS] 4.0.1 stable version release plan

2020-02-09 Thread guangyuan wang
I'm also curious about the principle of version number. Sheng Wu 于2020年2月9日周日 下午5:43写道: > A question, traditionally, the 3rd version number means bug fix,

Re: [DISCUSS] 4.0.1 stable version release plan

2020-02-09 Thread Sheng Wu
A question, traditionally, the 3rd version number means bug fix, but the changelogs include enhancement. Do we set the 2nd version number for new feature only? Sheng Wu 吴晟 Twitter, wusheng1108 zhangli...@apache.org 于2020年2月9日周日 下午5:34写道: > +1. > Great. There are no missing tasks from my side.

Re: [DISCUSS] 4.0.1 stable version release plan

2020-02-09 Thread zhangli...@apache.org
+1. Great. There are no missing tasks from my side. -- Liang Zhang (John) Apache ShardingSphere & Dubbo zhaojun 于2020年2月9日周日 下午3:44写道: > Hi, ShardingSphere community, > > I’d like to be the release manager of 4.0.1 version. > We have done some bug fixes and performance