javascript readability..

2011-07-25 Thread Paul Lindner
Hi, I'm curious to know what people think about some of the idioms in the JS code you find in shindig. There's an awful lot of stuff like this: shindig.foo = function(){ //... var myFunction = function() { } return {'foo': myFunction, 'bar': function() { re

Re: [VOTE] Ryan Baxter as Apache Shindig Committer

2011-07-25 Thread Han Nguyen
+1 On Fri, Jul 22, 2011 at 11:51 AM, Paul Lindner wrote: > Hello, > > I would like to propose that Ryan Baxter be granted committer access > to Shindig along with PMC membership. > > Ryan has been instrumental in moving OpenSocial v2 forward and implementing > these new features in Shindig. > >

Re: Review Request: Fix implementation on gadgets.window.getContainerDimensions API and update some descriptions

2011-07-25 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1190/#review1183 --- http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer

Re: sample container error

2011-07-25 Thread Ryan J Baxter
Sorry Derek, I thought you were using trunk. The common container was not introduced until after 2.0, so it shouldn't be causing the error. -Ryan Email: rjbax...@us.ibm.com Phone: 978-899-3041 developerWorks Profile From: Derek Houghton To: dev@shindig.apache.org, Date: 07/25/2011

Re: sample container error

2011-07-25 Thread Derek Houghton
Ryan, I've been working on version 2.0.0 for a while. suddenly started getting the samplecontainer errors. would the deprecation of shindig-container.js cause this? Derek On 25 Jul 2011, at 19:57, Ryan J Baxter wrote: > Derek, not sure if you are just starting out with your container > implem

Re: Example implementation for user prefs?

2011-07-25 Thread Henry Saputra
If you want the user pref to be persisted in the database you need to implement the server handler for it. I remember Doug Davies has tried to add persistent layer for user pref. Maybe he could share his progress. Including him in the email. - Henry On Mon, Jul 25, 2011 at 3:42 PM, Mat Schaffer

Re: database implementation

2011-07-25 Thread Derek Houghton
Trying to port my database from version 2.0.0 to trunk. Now when I try and set up the basic database connection in the trunk I immediately get the following errors. I'm sure its a duplicate dependency but I can't see it. I thought that I needed both the social api shindig-common and the samples

Re: Example implementation for user prefs?

2011-07-25 Thread Mat Schaffer
So with some research it looks like I'm supposed to be implementing my own server module. Is that pretty much accurate? Again, any advice or RTFMs (with a link to the respective FMs) is appreciated. Thanks, Mat On Fri, Jul 22, 2011 at 10:20 AM, Mat Schaffer wrote: > So I noticed that UserPref

Review Request: Fix implementation on gadgets.window.getContainerDimensions API and update some descriptions

2011-07-25 Thread Jason Chiang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1190/ --- Review request for shindig and Ryan Baxter. Summary --- 1. Update implemen

Re: Fix implementation on gadgets.window.getContainerDimensions API and update some descriptions (issue4800050)

2011-07-25 Thread Henry Saputra
Hi, Could you move this review to https://reviews.apache.org? - Henry On Mon, Jul 25, 2011 at 12:31 PM, wrote: > Reviewers: rbaxter85, dev_shindig.apache.org, > > Description: > 1. Update implementation of gadgets.window.getContainerDimensions based > on latest API which will call the callback

Fix implementation on gadgets.window.getContainerDimensions API and update some descriptions (issue4800050)

2011-07-25 Thread jasonchiangc
Reviewers: rbaxter85, dev_shindig.apache.org, Description: 1. Update implementation of gadgets.window.getContainerDimensions based on latest API which will call the callback function with the dimension object as parameter. 2. correct the feature docs. Please review this at http://codereview.apps

Re: Review Request: Enable closure compiler by default

2011-07-25 Thread Paul Lindner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1179/#review1178 --- almost there! http://svn.apache.org/repos/asf/shindig/trunk/features

Re: sample container error

2011-07-25 Thread Ryan J Baxter
Derek, not sure if you are just starting out with your container implementation or if you are working on an existing container, but shindig-container.js is being "deprecated" in favor of a more standardized container called the common container. You can find samples using the common container

Re: sample container error

2011-07-25 Thread Derek Houghton
Dan, long time in replying as I got a little confused here. I thought that the opt_params in the samplecontainer.js was what was getting passed to the core:rpc:pubsub:shindig-container.js. but when the error occurs my debug call in the samplecontainer.js is not called. I am unclear as to how to

Re: [VOTE] Ryan Baxter as Apache Shindig Committer

2011-07-25 Thread Eric Woods
A big +1 from me. - Eric W.