Re: Review Request: Fix implementation on gadgets.window.getContainerDimensions API and update some descriptions

2011-07-27 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1190/#review1206 --- Ship it! LGTM - Ryan On 2011-07-27 14:45:36, Jason Chiang wrote: >

Re: Review Request: Improve exportJs() in the face of potentially non-existent symbols.

2011-07-27 Thread johnfargo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1199/#review1203 --- trunk/features/src/main/javascript/features/exportjs/exportjs.js

Review Request: Change osapi._registerMethods to 'last one in wins'

2011-07-27 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1211/ --- Review request for shindig. Summary --- While debugging using a container c

Question about access to cached gadget metadata

2011-07-27 Thread Matthew Hatem
We have a use case where I have my own instance of the Common Container and I need access to a gadgets' metadata outside the context of gadget navigation. Currently the common container keeps a cache/map of gadget metadata. We see two potential solutions: 1) Create a lifecycle callback and cache

Re: Example implementation for user prefs?

2011-07-27 Thread Dan Dumont
Correction: the preferences to render with are a RENDER_PARAM and as such are only needed when doing the gadget render, not the metadata request. No patch needed. From: Dan Dumont/Westford/IBM@Lotus To: dev@shindig.apache.org, Date: 07/27/2011 03:35 PM Subject:Re: Example impl

Re: Example implementation for user prefs?

2011-07-27 Thread daviesd
This is GOOD stuff. I think I'm gonna have to move off of beta2 (is there a beta3 in site?). I didn't realize all this work had been done and I was doing a lot of it myself. Thanks, doug On 7/27/11 3:33 PM, "Dan Dumont" wrote: > http://opensocial-resources.googlecode.com/svn/spec/2.0/incubat

Re: Example implementation for user prefs?

2011-07-27 Thread Dan Dumont
http://opensocial-resources.googlecode.com/svn/spec/2.0/incubating/Core-Container.xml#Configuring-The-Container When you insantiate the common container, you can provide these functions, keyed appropriately, via the config object. The GET_PREFERENCES function will be called as defined when ma

Re: Example implementation for user prefs?

2011-07-27 Thread daviesd
Dan, Nice! I'm still using 3.0.0-beta2, so hadn't seen this yet. Was there an earlier thread on how to use this? Can you explain how I hook into this and provide a server-side implementation? And does this mean when I call navigateGadget that I should now be providing a unique id for the siteId

Re: Enhancing gadgets.log

2011-07-27 Thread Ryan J Baxter
My original plan was to tie the RPC call into gadgets.log so this would work for existing gadgets as well. I then realized I would be adding a dependency to RPC and gadgets.log is a core feature so that did not seem like a good approach. I guess creating a new feature would be the only way to

Re: Example implementation for user prefs?

2011-07-27 Thread Dan Dumont
FYI, there have been some recent changes in the common container to expose a callback to the container page that allows for the persisting and retrieval of persisted preferences. /** * @see setprefs.js setprefs feature. */ this.rpcRegister('set_pref', function(rpcArgs, key, value) {

Re: [VOTE] Ryan Baxter as Apache Shindig Committer

2011-07-27 Thread Ryan J Baxter
Paul when does this vote end? I wasn't sure if we only counted business days or not :) -Ryan Email: rjbax...@us.ibm.com Phone: 978-899-3041 developerWorks Profile From: Paul Lindner To: dev@shindig.apache.org, Date: 07/22/2011 11:51 AM Subject:[VOTE] Ryan Baxter as Apache S

Re: Review Request: Remove scheme from default test domain/host name in config/container.js

2011-07-27 Thread Paul Lindner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/939/#review1201 --- Ship it! nice - Paul On 2011-06-21 17:57:51, Henry Saputra wrote:

RE: Example implementation for user prefs?

2011-07-27 Thread Ciancetta, Jesse E.
I believe appdata is stored per user/per application as opposed to per user/per application instance, so I think you'll need to add the module ID (application instance ID) somewhere in your naming scheme for the persisted appdata. I think as its implemented currently two instances of the same ap

Re: Review Request: Remove scheme from default test domain/host name in config/container.js

2011-07-27 Thread Henry Saputra
> On 2011-06-21 17:25:05, li xu wrote: > > LGTM. thanks for addressing it. Thx for the review - Henry --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/939/#review871 --

Re: Review Request: Remove scheme from default test domain/host name in config/container.js

2011-07-27 Thread Henry Saputra
> On 2011-06-21 16:05:24, Stanton Sievers wrote: > > Ditto Paul's comment. Other than that, LGTM. Thx for the review - Henry --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/939/#review870 --

Re: Review Request: Remove scheme from default test domain/host name in config/container.js

2011-07-27 Thread Henry Saputra
> On 2011-06-21 15:45:22, Paul Lindner wrote: > > trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java, > > line 136 > > > > > > set host = '//' here and then append to it. > > Goo

Re: Example implementation for user prefs?

2011-07-27 Thread daviesd
Paul, Sure. Give me a few days, I just got back from vacation. I'll have to figure out whether the container token will be sufficient for this, as I had to apply other patches to get the gadget token to be used. Thanks, doug On 7/27/11 12:58 PM, "Paul Lindner" wrote: > Can you write this up a

Re: Example implementation for user prefs?

2011-07-27 Thread Paul Lindner
Can you write this up a patch so we can make this the default implementation? This is something I've been meaning to do for months. On Wed, Jul 27, 2011 at 8:58 AM, daviesd wrote: > Actually, I was lazy and went with the approach of layering userprefs on > top > of appdata as follows: > >co

Re: Example implementation for user prefs?

2011-07-27 Thread daviesd
Actually, I was lazy and went with the approach of layering userprefs on top of appdata as follows: container.rpcRegister('set_pref', function(rpcArgs, data) { var prefName = rpcArgs['a'][1]; var prefKey = 'up_' + prefName; var prefValue = rpcArgs['a'][2]; var

Re: Review Request: Fix implementation on gadgets.window.getContainerDimensions API and update some descriptions

2011-07-27 Thread Jason Chiang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1190/ --- (Updated 2011-07-27 14:45:36.702350) Review request for shindig and Ryan Baxter.

Re: Review Request: Improve exportJs() in the face of potentially non-existent symbols.

2011-07-27 Thread Michael Hermanto
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1199/#review1200 --- trunk/features/src/main/javascript/features/exportjs/exportjs.js