RE: Example implementation for user prefs?

2011-07-29 Thread Ciancetta, Jesse E.
Doug can you explain more about how your using appdata + site id to store user prefs? I tried looking below but couldn't find an explanation. I realize that every gadget site has a unique gadget id, but couldn't a container choose to reuse a gadget site? Say a container renders gadget 1 in site

RE: javascript readability..

2011-07-29 Thread Ciancetta, Jesse E.
Hey John, I hadn’t seen the exportJs support before (I haven’t done any work with features in a long time) -- that does look very similar! (and as an aside -- hats off to whoever came up with that scheme to be able to closure compile JS in isolation but still have fully qualified symbols

Re: Example implementation for user prefs?

2011-07-29 Thread daviesd
In our implementation the siteid SHOULD be unique and specific to an instance of a gadget (I¹m still working out the details on this). So they won¹t be reused. That still means appdata could be queried and user preferences visible to others. However I¹m working off this comment...

DeferredExportJsProcessorTest Failing against Trunk

2011-07-29 Thread Stanton Sievers
Hi everyone, Is anyone else seeing this failure when building against Trunk? It might be related to some recent changes to ExportJsProcessor.java. Thanks, -Stanton Failed tests: testProcessWithOneNonEmptyFeatureDeferred (org.apache.shindig.gadgets.js.DeferredExportJsProcessorTest):

Review Request: Abstracted 2 methods out.

2011-07-29 Thread chris . cal . berkeley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1224/ --- Review request for shindig, johnfargo and Ziv Horesh. Summary ---

Re: Review Request: Abstracted 2 methods out.

2011-07-29 Thread Ziv Horesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1224/#review1231 ---

Re: Review Request: Abstracted 2 methods out.

2011-07-29 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1224/#review1232 --- Is there requirement or scenario where these need to be exposed as

Review Request: Let allowedTags and allowedAttributes be Provided Sets.

2011-07-29 Thread johnfargo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1225/ --- Review request for shindig and Ziv Horesh. Summary --- Changes

Re: Review Request: Let allowedTags and allowedAttributes be Provided Sets.

2011-07-29 Thread Ziv Horesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1225/#review1233 --- Ship it! - Ziv On 2011-07-29 22:23:13, johnfargo wrote:

Re: Review Request: Abstracted 2 methods out.

2011-07-29 Thread Henry Saputra
Thanks for the reply John. Just want to make sure we add customization point to Shindig as necessary =) - Henry On Fri, Jul 29, 2011 at 2:36 PM, John Hjelmstad fa...@google.com wrote: For various reasons, we happen to use different global symbol names in our use of the config lib. That in turn

Re: Review Request: Abstracted 2 methods out.

2011-07-29 Thread John Hjelmstad
Agreed, well worth asking. On Fri, Jul 29, 2011 at 4:50 PM, Henry Saputra henry.sapu...@gmail.comwrote: Thanks for the reply John. Just want to make sure we add customization point to Shindig as necessary =) - Henry On Fri, Jul 29, 2011 at 2:36 PM, John Hjelmstad fa...@google.com wrote:

Re: Review Request: Abstracted 2 methods out.

2011-07-29 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1224/#review1234 --- Ship it! Just connect with John with email. LGTM (with changes to

Re: Review Request: Abstracted 2 methods out.

2011-07-29 Thread johnfargo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1224/#review1235 --- Committed as r1152402. - johnfargo On 2011-07-30 00:12:24, csong

Re: Example implementation for user prefs?

2011-07-29 Thread Ryan J Baxter
As someone pointed out earlier in the thread, Mark Weitzel, was looking into cleaning up app data and user prefs. This did not make it into OpenSocial 2.0 but I think Mark wants to pick it back up in OpenSocial Next. I think it's a fair assumption that the APIs around app data and user prefs

Re: Review Request: Abstracted 2 methods out.

2011-07-29 Thread chrissong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1224/ --- (Updated 2011-07-30 00:12:24.555729) Review request for shindig, johnfargo and

Re: NoClassDefFound Error when building the Java5 profile

2011-07-29 Thread Paul Lindner
Which JVM? Tests are passing on Jenkins: http://hudson.inuus.com/job/Shindig%20Java%201.5/ On Tue, Jul 19, 2011 at 3:53 PM, Stanton Sievers ssiev...@us.ibm.comwrote: Hi Everyone, Is anybody else seeing this error when building the Java5 profile? I built the Java5 profile a few weeks ago

None of the examples are working in HEAD

2011-07-29 Thread Phillip Rhodes
Hey all, quick FYI: I just svn up'd my shindig dir and rebuilt and started experimenting with the various examples, only to find that nothing seems to be working at the moment. Here's a quick list of the things that are flaking out: for /container/sample1.html Error: window.___jsl is