found the issue, I was using newer version of org.json
Thanks,
/Nuwan
On Tue, Dec 13, 2011 at 7:29 AM, Nuwan Bandara wrote:
> Hi
>
> Any help appreciated. Am getting bunch of errors like this. I suspect that
> some files are not properly getting passed ? Is it an issue that I dont
> have all th
Hi
Any help appreciated. Am getting bunch of errors like this. I suspect that
some files are not properly getting passed ? Is it an issue that I dont
have all the dependencies ?
42) Error injecting constructor, org.json.JSONException: A JSONObject text
must begin with '{' at character 1
at
org.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3053/#review3861
---
Ship it!
Looks good to me.
- Stanton
On 2011-12-07 16:53:27, Dan D
Doug if you want to create ones for IntelliJ and contribute them back we
would welcome them :) Might be something to consider if you plan on
contributing more code down the line.
-Ryan
Email: rjbax...@us.ibm.com
Phone: 978-899-3041
developerWorks Profile
From: daviesd
To: ,
Date:
Li, revision submitted. Cleaned up the code to use Maps, used the Eclipse
formatters, and added a junit test.
Thanks for your help.
doug
On 12/12/11 3:10 PM, "Li Xu" wrote:
> ah, I see, no worry. I can clean up the code style when committing it.
> thanks.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3064/
---
(Updated 2011-12-12 21:22:49.348470)
Review request for shindig.
Changes
-
ah, I see, no worry. I can clean up the code style when committing it.
thanks.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3053/#review3847
---
LGTM
- Jason
On 2011-12-07 16:53:27, Dan Dumont wrote:
>
> ---
Awesome Li! As far as the code style comment. I'm an IntelliJ person.
Anyone have the templates for that? If not, I'll see about moving over to
Eclipse to do the edits.
doug
On 12/12/11 2:50 PM, "Li Xu" wrote:
> Thanks for the patch, Doug! It looks pretty good to me. only a few minor
> thin
Thanks for the patch, Doug! It looks pretty good to me. only a few minor
things I have added to the review.
Thanks!
li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3064/#review3849
---
Ship it!
It looks pretty good to me, thanks for the patch! I can help
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3064/#review3850
---
Ship it!
It looks pretty good to me, thanks for the patch! I can help
No I plan to keep that. That method is to set up the schedule to refresh
gadget tokens.
There's no management at all of container tokens :(
Also, it's possible to arrive in a situation where gadget tokens are
expired and could not be refreshed because the container token is expired
and the pag
AFAIK there is already a time interval based security token refresh
from common container via
osapi.container.Container.prototype.scheduleRefreshTokens_ ?
It will later visited each gadget site and call rpc
update_security_token to the iframe to update the ST.
Is the approach you proposed is diff
Wow that didn't keep any of my formatting. Let me clean some of that up.
Our concerns are:
* The current implementation only deals with refreshing the gadget tokens.
Every implementer of the CommonContainer needs to write a refresh
mechanism from the ground up.
* There's no way to force all t
Recently we have noticed some shortcomings with the common container
around the current implementation of security token refreshes.
Our concerns are:
The current implementation only deals with refreshing the gadget tokens.
Every implementer of the CommonContainer needs to write a refresh
mechan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3064/
---
(Updated 2011-12-12 16:48:18.875271)
Review request for shindig.
Changes
-
You may need to tell your SVN client to add them to source control
Then create the patch and make sure they are selected. (if you're using
eclipse, that's what I use)
From: daviesd
To: ,
Date: 12/12/2011 11:38 AM
Subject:Re: OAUTH2 ClientAuthenticationHandler: No access to
Hmmm... I included 2 NEW files in the diff, but they didn't get added to the
review. How do I do this?
doug
On 12/12/11 11:18 AM, "daviesd" wrote:
> I have submitted a revision to the review (3064) that implements the
> OAuth2RequestParameterGenerator class. I look forward to your responses
I have submitted a revision to the review (3064) that implements the
OAuth2RequestParameterGenerator class. I look forward to your responses and
getting this integrated as quickly as possible.
Thanks for the guidance,
doug
On 12/8/11 3:50 PM, "Li Xu" wrote:
> I see. Just a thought, Inject an
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3064/
---
(Updated 2011-12-12 16:14:04.550741)
Review request for shindig.
Changes
-
> On 2011-12-09 14:25:51, Jesse Ciancetta wrote:
> > LGTM
> >
> > This is an interesting capability -- its too bad we couldn't find a way to
> > get it done without two requests though.
> >
> > I did actually have one other thought about an alternative that could work
> > (but again has its o
22 matches
Mail list logo
