On 2012-01-20 16:35:55, Stanton Sievers wrote:
Small nits on whitespace.
I do have some bigger questions regarding the implementation and maybe
these are more for the spec group. What's to stop one person from updating
another person? The rest API says that the User-Id defaults
On 2012-01-20 16:35:55, Stanton Sievers wrote:
Small nits on whitespace.
I do have some bigger questions regarding the implementation and maybe
these are more for the spec group. What's to stop one person from updating
another person? The rest API says that the User-Id defaults
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3571/#review4529
---
Ship it!
LGTM. Applied the patch and was able to get an oAuth2Spec
On 2012-01-20 16:35:55, Stanton Sievers wrote:
Small nits on whitespace.
I do have some bigger questions regarding the implementation and maybe
these are more for the spec group. What's to stop one person from updating
another person? The rest API says that the User-Id defaults
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3531/
---
(Updated 2012-01-23 14:19:57.390944)
Review request for shindig.
Changes
On 2012-01-20 16:35:55, Stanton Sievers wrote:
Small nits on whitespace.
I do have some bigger questions regarding the implementation and maybe
these are more for the spec group. What's to stop one person from updating
another person? The rest API says that the User-Id defaults
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3571/#review4534
---
Ship it!
LGTM after whitespace fixes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3566/#review4535
---
Ship it!
LGTM
- Dan
On 2012-01-20 16:53:37, Henry Saputra wrote:
I have a gadget that was using
var moduleId = new gadgets.Prefs().getModuleId();
To get the current moduleId (siteId) of the gadget so that it could retrieve
userprefs
osapi.userprefs.get( { siteId : moduleId } )
This is now return 0 instead of the id I have for the element the gadget was
Hrmm... I don't recall moduleId ever being anything other than 0.
The discussions have focused around what a moduleId is (a number that's
baked into the security token, primarily used to identify saved instances
of a gadget) and what a siteId is ( a string value that's used in or as an
id
In pref.js shindig was setting the Prefs moduleId to the mid parameter.
Perhaps something is different here now. So for whatever reason that use to
return me whatever I had as my siteId and now it doesn't.
At any rate, this is a TEST gadget that is probably trying to access
something it
Not a problem.
mid is for the moduleId. (maybe it wasn't always so... but for
consistency sake it probably should remain so)
IIRC, Prefs.getModuleId returns the value in the ifr url 'mid' param.
Your GET_PREFERENCES/SET_PREFERENCES impl should be getting the siteid,
which it can look up a
I agree on everything you just stated.
So my only outstanding question would be is anyone aware of a way for a
gadget to find out it's siteId (the id that was set on the element the
gadget was rendered into)?
Any yes, I'd like to see the rpc requests changed to use the gadget security
token.
I don't think so. In my opinion, the siteId is a purely container piece
of information.
why do you need to get it inside the gadget?
From: daviesd davi...@oclc.org
To: dev@shindig.apache.org,
Date: 01/23/2012 02:57 PM
Subject:Re: getModuleId
I agree on everything you just
Like I said... An edge case... And probably not a real world use case.
But my test gadget sets a bunch of userprefs and then it needs to repull the
values (from persistence) and make sure they've been set properly (tests a
race condition we had).
I was using osapi.userprefs.get to retrieve the
Hrmm...
I don't know if you'll be able to do this anymore until you hook up the
moduleId support.
From: daviesd davi...@oclc.org
To: dev@shindig.apache.org,
Date: 01/23/2012 03:08 PM
Subject:Re: getModuleId
Like I said... An edge case... And probably not a real world use
That's what I was kind of figuring. So can you tell me what state the
moduleId stuff is at? Is it still under development or can I start using it
now? I hope we get another beta (or final 3.0.0 release) soon that has this
and oauth2 in a stable state.
doug
On 1/23/12 3:16 PM, Dan Dumont
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3528/
---
(Updated 2012-01-23 20:26:52.530429)
Review request for shindig and Dan Dumont.
The server side moduleId stuff is all there for you to implement however
you want to persist gadget instances.
It should be fairly flexible so that you can implement it many different
ways. Just inject your implementation in place of shindig's module id
manager
I have a spec patch out there
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3531/#review4539
---
Ship it!
Committed r1234987
- Dan
On 2012-01-23 14:19:57, Dan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3571/#review4541
---
Ship it!
Committed r1235006
Please link the Jira here in the Bugs
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3528/#review4542
---
Ship it!
Committed r1235009. Please link the Jira in the bugs
22 matches
Mail list logo
