Re: Review Request: gadgets.metadata request fails for gadgets that don't have a "default" view

2012-01-27 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3670/ --- (Updated 2012-01-28 01:17:22.559949) Review request for shindig. Summary -

Review Request: gadgets.metadata request fails for gadgets that don't have a "default" view

2012-01-27 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3670/ --- Review request for shindig. Summary --- The request for gadgets.metadata fa

Review Request: SHINDIG-1686 The gadgets.views.init does not check for the view name if it contains secondary view

2012-01-27 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3666/ --- Review request for shindig. Summary --- See jira: SHINDIG-1686 (https://iss

Re: Review Request: Publish global selection into the DataContext of a gadget (if available)

2012-01-27 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3668/ --- (Updated 2012-01-27 21:12:09.770883) Review request for shindig and Andrew Davis

Re: Review Request: Publish global selection into the DataContext of a gadget (if available)

2012-01-27 Thread Ryan Baxter
> On 2012-01-27 21:00:21, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensocial-data-context/datacontext.js, > > line 166 > > > > > > usually keys from the

Re: Review Request: Publish global selection into the DataContext of a gadget (if available)

2012-01-27 Thread Dan Dumont
> On 2012-01-27 21:00:21, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensocial-data-context/datacontext.js, > > line 166 > > > > > > usually keys from the

Re: Review Request: Publish global selection into the DataContext of a gadget (if available)

2012-01-27 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3668/#review4658 --- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javas

Review Request: Publish global selection into the DataContext of a gadget (if available)

2012-01-27 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3668/ --- Review request for shindig and Andrew Davis. Summary --- This review is mos

Re: OAuth2RequestParameterGenerator

2012-01-27 Thread daviesd
I¹m just wondering if it¹s as easy as having BasicHttpFetcher transfer the HttpRequest params to the httpMethod params. Was it an oversight or were they not copied for a reason? doug On 1/27/12 2:23 PM, "daviesd" wrote: > Back in December Li Xu helped me get a patch submitted that added the >

RE: NOTICE and LICENSE files

2012-01-27 Thread Ciancetta, Jesse E.
>-Original Message- >From: Ate Douma [mailto:a...@douma.nu] >Sent: Friday, January 27, 2012 9:55 AM >To: dev@shindig.apache.org >Subject: Re: NOTICE and LICENSE files > >On 01/27/2012 01:57 PM, Ciancetta, Jesse E. wrote: >> I've been working with Ate on the Rave project since its inception

OAuth2RequestParameterGenerator

2012-01-27 Thread daviesd
Back in December Li Xu helped me get a patch submitted that added the OAuth2RequestParameterGenerator interface. It is meant to be implemented if you want to pass additional parameters along to the various oauth2 flow requests. I¹ve since noticed an issue with this. The parameters I add get pass

Re: [PROPOSAL] Maven project enhancements to improve embedding and extending shindig-server (for Apache Rave)

2012-01-27 Thread Ate Douma
On 01/27/2012 02:21 PM, Ciancetta, Jesse E. wrote: Thanks Ate for taking the time to submit such a thorough proposal. This all sounds good to me -- please submit the patch for review. Cool, will do. Ate --Jesse -Original Message- From: Ate Douma [mailto:a...@douma.nu] Sent: Tuesd

Re: NOTICE and LICENSE files

2012-01-27 Thread Ate Douma
On 01/27/2012 01:57 PM, Ciancetta, Jesse E. wrote: I've been working with Ate on the Rave project since its inception and personally have 100% trust in his opinions and recommendations on these types of matters (and many other matters as well). Ate has been helping Rave work though these same

Re: getModuleId

2012-01-27 Thread Dan Dumont
I had assumed you meant the navigate chain of calls. The metadata call doesn't deal with specific moduleIds, and in fact I've been talking to Jesse about removing the security token from the metadata response if we can figure out a sane way to bundle the token request and metadata request tog

Re: getModuleId

2012-01-27 Thread Dan Dumont
The container wishing to navigate a gadget to a saved instance, a new saved instance, or the default unsaved instance of 0. From: Henry Saputra To: dev@shindig.apache.org, Date: 01/27/2012 02:16 AM Subject:Re: getModuleId Dan, In the Shindig code, who is responsible to set

RE: [PROPOSAL] Maven project enhancements to improve embedding and extending shindig-server (for Apache Rave)

2012-01-27 Thread Ciancetta, Jesse E.
Thanks Ate for taking the time to submit such a thorough proposal. This all sounds good to me -- please submit the patch for review. --Jesse >-Original Message- >From: Ate Douma [mailto:a...@douma.nu] >Sent: Tuesday, January 24, 2012 9:29 PM >To: dev@shindig.apache.org >Cc: rave-...@incu

RE: NOTICE and LICENSE files

2012-01-27 Thread Stanton Sievers
If you could write up the JIRA, that would be great Jesse. This is something we need to fix before we declare 3.0.0.or is it 2.5.0 now :). Thanks, -Stanton From: "Ciancetta, Jesse E." To: "dev@shindig.apache.org" , Date: 01/27/2012 07:57 Subject:RE: NOTICE and LICENSE f

RE: NOTICE and LICENSE files

2012-01-27 Thread Ciancetta, Jesse E.
I've been working with Ate on the Rave project since its inception and personally have 100% trust in his opinions and recommendations on these types of matters (and many other matters as well). Ate has been helping Rave work though these same type of issues from the start and he's been active o