Review Request: change if condition in actions_container.js due to runAction function receives an empty array when it calls the registry.getGadgetSites instead of "undefined"

2012-03-06 Thread Yao Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4216/ --- Review request for shindig and Henry Saputra. Summary --- runAction functio

Re: SHINDIG-1719 - UnsupportedOperationException

2012-03-06 Thread Henry Saputra
Do you extend the OurDefaultSecurityTokenCodec from AbstractSecurityToken? If you do then you dont need to do anything I think - Henry On Tue, Mar 6, 2012 at 1:03 PM, daviesd wrote: > Ya it's the difference between insecure and secure.  If I use insecure > tokens it works.  If I switch to secur

Re: SHINDIG-1719 - UnsupportedOperationException

2012-03-06 Thread daviesd
Ya it's the difference between insecure and secure. If I use insecure tokens it works. If I switch to secure (our default) it gets this exception when encoding the token. doug On 3/6/12 3:29 PM, "Henry Saputra" wrote: > Hey Doug, > > Sorry about the trouble. > > How do you reproduce this?

Re: SHINDIG-1719 - UnsupportedOperationException

2012-03-06 Thread daviesd
I think it's because we have our own implementation of DefaultSecurityTokenCodec that we override with guice. this.bind(SecurityTokenCodec.class).to(OurDefaultSecurityTokenCodec.class); If I change this back to DefaultSecurityTokenCodec things work fine. I don't exactly remember the reason we wer

Re: Review Request: Improvement to OAuth2 message files

2012-03-06 Thread Adam Clarke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4202/#review5653 --- Ship it! LGTM - Adam On 2012-03-06 19:29:51, li xu wrote: > > ---

Re: SHINDIG-1719 - UnsupportedOperationException

2012-03-06 Thread Henry Saputra
Hey Doug, Sorry about the trouble. How do you reproduce this? - Henry On Tue, Mar 6, 2012 at 12:13 PM, daviesd wrote: > Henry, > > I¹m having issues with the fix for SHINDIG-1719.   The stacktrace looks as > follows: > > Mar 6, 2012 3:04:20 PM > org.apache.shindig.gadgets.servlet.GadgetsHandle

SHINDIG-1719 - UnsupportedOperationException

2012-03-06 Thread daviesd
Henry, I¹m having issues with the fix for SHINDIG-1719. The stacktrace looks as follows: Mar 6, 2012 3:04:20 PM org.apache.shindig.gadgets.servlet.GadgetsHandlerService createErrorResponse WARNING: Error handling request: java.lang.UnsupportedOperationException: Unsupported function: getActiveU

Review Request: Improvement to OAuth2 message files

2012-03-06 Thread li xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4202/ --- Review request for shindig. Summary --- As part of the release cycle in our

Re: Problem with latest shindig

2012-03-06 Thread daviesd
Paul, I think this has to do with version 1290973 of JsonUtil.java which you made changes to. If I roll this file back to version 950407 my tests work again. Ideas? I¹m banging my head against the wall on this one. doug On 3/5/12 5:33 PM, "daviesd" wrote: > I just got back from vacation an

Re: osapi.groups missing

2012-03-06 Thread Stanton Sievers
That's exactly it Henry. No one is binding GroupService or implementing it. Shindig simply doesn't have a GroupService implementation. The simplest solution may be to have JsonDbOpensocialService implement GroupService and then have SampleModule bind it like it does everything else. Even i