Re: Review Request: MakeRequestHandler and HttpRequestHandler do not use a real gadget when rewriting responses

2012-03-19 Thread Ryan Baxter
> On 2012-03-20 01:23:55, Henry Saputra wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ResponseRewriter.java, > > line 30 > > > > > > Since most impl

Re: Review Request: MakeRequestHandler and HttpRequestHandler do not use a real gadget when rewriting responses

2012-03-19 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4284/#review6104 --- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/j

Re: Review Request: MakeRequestHandler and HttpRequestHandler do not use a real gadget when rewriting responses

2012-03-19 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4284/ --- (Updated 2012-03-20 00:24:09.605030) Review request for shindig. Changes -

Re: Review Request: MakeRequestHandler and HttpRequestHandler do not use a real gadget when rewriting responses

2012-03-19 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4284/#review6079 --- Ship it! LGTM http://svn.apache.org/repos/asf/shindig/trunk/java/ga

Re: Review Request: MakeRequestHandler and HttpRequestHandler do not use a real gadget when rewriting responses

2012-03-19 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4284/ --- (Updated 2012-03-19 18:52:24.861290) Review request for shindig. Changes -

Re: Review Request: MakeRequestHandler and HttpRequestHandler do not use a real gadget when rewriting responses

2012-03-19 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4284/#review6074 --- Ship it! Few small nits. Other than that this LGTM. http://svn.apa

Re: Review Request: gadgets.io.makeRequest supports PUT but the PUT body is not passed along

2012-03-19 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4273/ --- (Updated 2012-03-19 17:43:45.731644) Review request for shindig, Dan Dumont and

Review Request: MakeRequestHandler and HttpRequestHandler do not use a real gadget when rewriting responses

2012-03-19 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4284/ --- Review request for shindig. Summary --- When the MakeRequestHandler or Http

Re: Review Request: Fix for SHINDIG-1736

2012-03-19 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4366/#review6070 --- Ship it! LGTM - Ryan On 2012-03-15 17:47:31, Doug Davies wrote: >

Re: requestNavigateTo and set_title are unknown RPC services if I don't include shindig-container feature.

2012-03-19 Thread Dan Dumont
You are currently expected to implement those events, as every container's gadget chrome could be very different. The CC can not predict how you have constructed your title area, or if you even have a title area. From: Jian L Hu To: dev@shindig.apache.org, Date: 03/18/2012 10:28 PM S

Re: requestNavigateTo and set_title are unknown RPC services if I don't include shindig-container feature.

2012-03-19 Thread daviesd
You need to implement those since every container might handle it differently. doug On 3/18/12 10:26 PM, "Jian L Hu" wrote: > > > Hi All, > > views and settitle features have dependency to services like > requestNavigateTo and set_title. > However common container don't register these RPC s

Re: Review Request: rpc does not support communicating with gadget created on an dom node in existing iframe

2012-03-19 Thread Yao Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3908/ --- (Updated 2012-03-19 07:38:42.936953) Review request for shindig, Henry Saputra,