Re: Review Request: Pass token on listMethods to enable allowUnauthenticated=false

2012-06-19 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5422/#review8403 --- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/j

Re: Review Request: Pass token on listMethods to enable allowUnauthenticated=false

2012-06-19 Thread Doug Davies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5422/#review8401 --- Ship it! Ship It! - Doug Davies On June 19, 2012, 5:39 p.m., Brian

Re: Adding additional APIs to Shindig

2012-06-19 Thread daviesd
Thanks Stanton. So it sounds like you were saying to roll my own on this and not try to leverage off of any existing shindig handlers? I certainly agree on the security aspect. This would all take place over ssl. doug On 6/18/12 5:26 PM, "Stanton Sievers" wrote: > Hi Doug, > > The largest

Re: Review Request: Pass token on listMethods to enable allowUnauthenticated=false

2012-06-19 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5422/#review8400 --- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/j

Review Request: Pass token on listMethods to enable allowUnauthenticated=false

2012-06-19 Thread Brian Lillie
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5422/ --- Review request for shindig, Ryan Baxter and Doug Davies. Description --- Co

Re: Review Request: We handle invalid EE data model target types incorrectly in the EE container code

2012-06-19 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5390/#review8396 --- Committed revision 1351771 - Ryan Baxter On June 18, 2012, 6:04 p.m

Re: Review Request: Pass token on listMethods to enable allowUnauthenticated=false

2012-06-19 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5422/#review8399 --- Ship it! Ship It! - Dan Dumont On June 19, 2012, 5:39 p.m., Brian

Re: Review Request: Code Review for JIRA 1801, shared tokens should share accessors

2012-06-19 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5420/#review8395 --- Adam I noticed we are lacking some unit tests for this method (and mos

Re: Review Request: Best effort support for open-views.ee getting a string dataModel

2012-06-19 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5345/#review8394 --- Ship it! Ship It! - Ryan Baxter On June 19, 2012, 2:48 p.m., Dan D

Re: Review Request: We handle invalid EE data model target types incorrectly in the EE container code

2012-06-19 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5390/#review8390 --- Ship it! Ship It! - Dan Dumont On June 18, 2012, 6:04 p.m., Ryan B

Re: Review Request: OAuthResponseParms logger does not resolve msgKey into appropriate message

2012-06-19 Thread ddumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1960/ --- (Updated June 19, 2012, 2 p.m.) Review request for shindig. Changes --- F

Re: Review Request: Best effort support for open-views.ee getting a string dataModel

2012-06-19 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5345/ --- (Updated June 19, 2012, 2:48 p.m.) Review request for shindig, Henry Saputra and

Re: Review Request: Code Review for JIRA 1793, expose OAuth2 client invalidation on OAuth2Store

2012-06-19 Thread Doug Davies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5419/#review8393 --- Ship it! Ship It! - Doug Davies On June 19, 2012, 1:09 p.m., Adam

Re: Review Request: SHINDIG-1807 Fix the JsonUtil to also consider methods start with is as accessor to properties

2012-06-19 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5411/#review8386 --- Ship it! Ship It! - Dan Dumont On June 19, 2012, 1:32 a.m., Henry

Re: Review Request: SHINDIG-1807 Fix the JsonUtil to also consider methods start with is as accessor to properties

2012-06-19 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5411/#review8383 --- Ship it! Ship It! - Stanton Sievers On June 19, 2012, 1:32 a.m., H

Re: Review Request: SHINDIG-1807 Fix the JsonUtil to also consider methods start with is as accessor to properties

2012-06-19 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5411/#review8384 --- Ship it! Ship It! - Ryan Baxter On June 19, 2012, 1:32 a.m., Henry

Review Request: Code Review for JIRA 1793, expose OAuth2 client invalidation on OAuth2Store

2012-06-19 Thread Adam Clarke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5419/ --- Review request for shindig, Stanton Sievers, Brian Lillie, and Doug Davies. Desc

Review Request: Code Review for JIRA 1801, shared tokens should share accessors

2012-06-19 Thread Adam Clarke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5420/ --- Review request for shindig, Stanton Sievers and Brian Lillie. Description --

Re: Review Request: Code Review for JIRA 1793, expose OAuth2 client invalidation on OAuth2Store

2012-06-19 Thread Adam Clarke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5419/ --- (Updated June 19, 2012, 1:09 p.m.) Review request for shindig, Stanton Sievers,

Re: Review Request: Best effort support for open-views.ee getting a string dataModel

2012-06-19 Thread Dan Dumont
> On June 19, 2012, 12:38 a.m., Ryan Baxter wrote: > > Dan instead of creating a whole new gadget to test with, could you modify > > the sample gadget which already leverages these APIs? > > https://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/Photo

Re: Review Request: Code Review for JIRA 1793, expose OAuth2 client invalidation on OAuth2Store

2012-06-19 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5419/#review8389 --- Ship it! Ship It! - Dan Dumont On June 19, 2012, 1:09 p.m., Adam C

Re: Review Request: Code Review for JIRA 1793, expose OAuth2 client invalidation on OAuth2Store

2012-06-19 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5419/#review8388 --- Ship it! Ship It! - Stanton Sievers On June 19, 2012, 1:09 p.m., A

Re: Review Request: Code Review for JIRA 1801, shared tokens should share accessors

2012-06-19 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5420/#review8387 --- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/j

Re: Review Request: Best effort support for open-views.ee getting a string dataModel

2012-06-19 Thread Ryan Baxter
> On June 19, 2012, 12:38 a.m., Ryan Baxter wrote: > > Dan instead of creating a whole new gadget to test with, could you modify > > the sample gadget which already leverages these APIs? > > https://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/Photo