Re: Review Request: Make gadget token TTL configurable

2012-09-04 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6906/#review11047 --- Ship it! Ship It! - Henry Saputra On Sept. 4, 2012, 10:27 p.m., S

Re: Build failed in Jenkins: Shindig Trunk (IBM 1.6) #8

2012-09-04 Thread Stanton Sievers
I'm pretty sure it is an IBM JDK problem. I've seen this before with local builds against the IBM JDK but was never able to track down the root cause of the problem. I might need to add a separate exclude for these so that RAT ignores these files. Anyone have any preference on how we handle this

Re: Build failed in Jenkins: Shindig Trunk (IBM 1.6) #8

2012-09-04 Thread Ryan Baxter
Stanton, any idea why these javacores are being generated? Is it an IBM JDK problem? Unapproved licenses: java/gadgets/javacore.20120827.012034.7501.0003.txt java/gadgets/javacore.20120829.015104.1138.0003.txt On Tue, Sep 4, 2012 at 6:30 PM, Apache Jenkins Server < jenk...@builds.apache.or

Re: Review Request: Make gadget token TTL configurable

2012-09-04 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6906/ --- (Updated Sept. 4, 2012, 10:27 p.m.) Review request for shindig and Dan Dumont.

Re: Review Request: Make gadget token TTL configurable

2012-09-04 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6906/#review11031 --- http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/j

Re: Review Request: Make gadget token TTL configurable

2012-09-04 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6906/#review11030 --- Ship it! Ship It! - Dan Dumont On Sept. 4, 2012, 6:46 p.m., Stant

Re: Review Request: Make gadget token TTL configurable

2012-09-04 Thread Stanton Sievers
> On Sept. 4, 2012, 6:41 p.m., Henry Saputra wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/SecurityTokenCodec.java, > > line 65 > > > > > > Might as well just

Re: Review Request: Make gadget token TTL configurable

2012-09-04 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6906/ --- (Updated Sept. 4, 2012, 6:46 p.m.) Review request for shindig and Dan Dumont.

Re: Review Request: Make gadget token TTL configurable

2012-09-04 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6906/#review11027 --- http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/j

Re: Review Request: Make gadget token TTL configurable

2012-09-04 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6906/#review11024 --- Nice! This change was actually smaller than I had expected :) http:

Re: Overriding Guice Modules

2012-09-04 Thread daviesd
Thanks. That works! Appreciate the direction. doug On 9/4/12 10:42 AM, "Stanton Sievers" wrote: > Hi Doug, > > Does the Modules.override functionality in guice help at all? I'm > wondering if you can override the DefaulyGuiceModule with a module that > does you binding. > > -Stanton > On S

Re: Review Request: Make gadget token TTL configurable

2012-09-04 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6906/ --- (Updated Sept. 4, 2012, 5:21 p.m.) Review request for shindig and Dan Dumont.

Review Request: Make gadget token TTL configurable

2012-09-04 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6906/ --- Review request for shindig and Dan Dumont. Description --- Today the gadget

Re: Review Request: Latest (and probably last) iteration of OAuth2 Consumer fixes rolled up into a single patch.

2012-09-04 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6436/#review11013 --- I must have missed these the first time through... or maybe the diff

Re: Overriding Guice Modules

2012-09-04 Thread daviesd
Wow! I didn't know about this. Thanks for the info. Yes, this might just work. I'll let ya know. doug On 9/4/12 10:42 AM, "Stanton Sievers" wrote: > Hi Doug, > > Does the Modules.override functionality in guice help at all? I'm > wondering if you can override the DefaulyGuiceModule with

Re: Overriding Guice Modules

2012-09-04 Thread Stanton Sievers
Hi Doug, Does the Modules.override functionality in guice help at all? I'm wondering if you can override the DefaulyGuiceModule with a module that does you binding. -Stanton On Sep 4, 2012 9:47 AM, "daviesd" wrote: > If I wanted to implement my own Authority implementation (replacing > BasicA

Overriding Guice Modules

2012-09-04 Thread daviesd
If I wanted to implement my own Authority implementation (replacing BasicAuthority) it appears that I would have to completely override the DefaultGuiceModule and just change one line to bind to my implementation. However, this means every time I upgrade artifacts I have to make sure the default im