Re: Review Request: Code Review for JIRA 1801, shared tokens should share accessors

--- All unit tests pass Thanks, Adam Clarke

Re: Review Request: Latest (and probably last) iteration of OAuth2 Consumer fixes rolled up into a single patch.

/oauth2/handler/OAuth2HandlerErrorTest.java 1386626 Diff: https://reviews.apache.org/r/6436/diff/ Testing --- All existing JUnits pass Thanks, Adam Clarke

Re: Review Request: Latest (and probably last) iteration of OAuth2 Consumer fixes rolled up into a single patch.

>And create a JIRA for the enhancement and link it here? > >I just don't want to forget about it. > > > - superddumont > > > On Sept. 17, 2012, 2:41 p.m., Adam Clarke wrote: >> >> -

Re: Review Request: Latest (and probably last) iteration of OAuth2 Consumer fixes rolled up into a single patch.

/oauth2/handler/OAuth2HandlerErrorTest.java 1386626 Diff: https://reviews.apache.org/r/6436/diff/ Testing --- All existing JUnits pass Thanks, Adam Clarke

Re: Review Request: Latest (and probably last) iteration of OAuth2 Consumer fixes rolled up into a single patch.

ndler/OAuth2HandlerErrorTest.java 1382074 Diff: https://reviews.apache.org/r/6436/diff/ Testing --- All existing JUnits pass Thanks, Adam Clarke

Re: Review Request: Latest (and probably last) iteration of OAuth2 Consumer fixes rolled up into a single patch.

et.java, > > line 129 > > <https://reviews.apache.org/r/6436/diff/2/?file=138705#file138705line129> > > > > Can you please collapse this code and use a ternary operator to pass in > > your message if accessor.isValid() or not? Done. - Adam -

Re: Review Request: Latest (and probably last) iteration of OAuth2 Consumer fixes rolled up into a single patch.

ttps://reviews.apache.org/r/6436/#review10333 ------- On Aug. 24, 2012, 1:04 p.m., Adam Clarke wrote: > > --- > This is an automatically generated e-mail

Re: Review Request: Latest (and probably last) iteration of OAuth2 Consumer fixes rolled up into a single patch.

/src/test/java/org/apache/shindig/gadgets/oauth2/handler/OAuth2HandlerErrorTest.java 1376889 Diff: https://reviews.apache.org/r/6436/diff/ Testing --- All existing JUnits pass Thanks, Adam Clarke

Re: Review Request: Latest (and probably last) iteration of OAuth2 Consumer fixes rolled up into a single patch.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6436/#review10023 ------- On Aug. 13, 2012, 12:33 p.m., Adam Clarke wrote: > > -

Re: Review Request: Latest (and probably last) iteration of OAuth2 Consumer fixes rolled up into a single patch.

dgets/oauth2/handler/OAuth2HandlerErrorTest.java 1372387 Diff: https://reviews.apache.org/r/6436/diff/ Testing --- All existing JUnits pass Thanks, Adam Clarke

Re: Review Request: OAuth1.0a , Make oauth_body_hash optional and support PLAINTEXT

/shindig/gadgets/oauth/OAuthStore.java 1363028 Diff: https://reviews.apache.org/r/6035/diff/ Testing --- All JUnits pass. Thanks, Adam Clarke

Review Request: OAuth1.0a , Make oauth_body_hash optional and support PLAINTEXT

8 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java 1363028 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthStore.java 1363028 Diff: https://reviews.apache.org/r/6035/diff/ Testing --- All JUnits pass. Thanks, Adam Clarke

Re: Review Request: Additional OAuth2 Logging Filters

ogger/FilteredLoggerTest.java 1355349 Diff: https://reviews.apache.org/r/5592/diff/ Testing --- all units pass Thanks, Adam Clarke

Re: Review Request: Additional OAuth2 Logging Filters

INDIG-1813 Diffs (updated) - http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/logger/FilteredLogger.java 1354123 Diff: https://reviews.apache.org/r/5592/diff/ Testing --- all units pass Thanks, Adam Clarke

Re: Review Request: OAuth2TokenPersistence setSecret fails if no encrypter

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5497/#review8650 --- Ship it! Ship It! - Adam Clarke On June 26, 2012, 8:33 p.m

Review Request: Additional OAuth2 Logging Filters

s/src/main/java/org/apache/shindig/gadgets/oauth2/logger/FilteredLogger.java 1354123 Diff: https://reviews.apache.org/r/5592/diff/ Testing --- all units pass Thanks, Adam Clarke

Re: Review Request: Code Review for JIRA 1801, shared tokens should share accessors

://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java 1352576 Diff: https://reviews.apache.org/r/5420/diff/ Testing --- All unit tests pass Thanks, Adam Clarke

Re: Review Request: OAuth2TokenPersistence setSecret fails if no encrypter

hould set the encrypted secret to be the unencrypted secret that was passed in. The persistence layer should be storing the encrypted secret, so if that was null the information would be lost. - Adam Clarke On June 21, 2012, 6:03 p.m., Brian Lillie

Re: Review Request: Code Review for JIRA 1801, shared tokens should share accessors

/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java 1352576 Diff: https://reviews.apache.org/r/5420/diff/ Testing --- All unit tests pass Thanks, Adam Clarke

Re: Review Request: Code Review for JIRA 1801, shared tokens should share accessors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5420/#review8395 --- On June 21, 2012, 3:53 p.m., Adam Clarke wrote: > > --

Re: Review Request: Code Review for JIRA 1801, shared tokens should share accessors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5420/#review8387 ------- On June 21, 2012, 3:53 p.m., Adam Clarke wrote: > > -

Re: Review Request: Code Review for JIRA 1801, shared tokens should share accessors

Diffs (updated) - http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java 1352576 Diff: https://reviews.apache.org/r/5420/diff/ Testing --- All unit tests pass Thanks, Adam Clarke

Review Request: Code Review for JIRA 1793, expose OAuth2 client invalidation on OAuth2Store

/OAuth2Store.java 1346021 Diff: https://reviews.apache.org/r/5419/diff/ Testing --- All unit tests pass Thanks, Adam Clarke

Review Request: Code Review for JIRA 1801, shared tokens should share accessors

/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java 1351704 Diff: https://reviews.apache.org/r/5420/diff/ Testing --- All unit tests pass Thanks, Adam Clarke

Re: Review Request: Code Review for JIRA 1793, expose OAuth2 client invalidation on OAuth2Store

1351689 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Store.java 1351689 Diff: https://reviews.apache.org/r/5419/diff/ Testing --- All unit tests pass Thanks, Adam Clarke

Review Request: Per latest OAuth2 spec, handle 400 from refresh_token response

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5330/ --- Review request for shindig and Stanton Sievers. Summary --- Spec did become

Re: Review Request: pass User-Agent header on makeRequest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5162/ --- (Updated 2012-05-21 13:27:18.757970) Review request for shindig. Changes -

Review Request: pass User-Agent header on makeRequest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5162/ --- Review request for shindig. Summary --- Passes the User-Agent header so int

Re: Review Request: Jira 1732 and lots of other fixes/enhancements

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4947/ --- (Updated 2012-05-04 14:31:05.271804) Review request for shindig, Ryan Baxter and

Re: Review Request: Jira 1732 and lots of other fixes/enhancements

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4947/ --- (Updated 2012-05-01 15:12:43.842304) Review request for shindig, Ryan Baxter and

Re: Review Request: Share OAuth2Token for a user across multiple gadgets

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4291/ --- (Updated 2012-04-11 14:55:54.729162) Review request for shindig, Ryan Baxter and

Re: Review Request: Share OAuth2Token for a user across multiple gadgets

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4291/ --- (Updated 2012-04-10 15:00:53.484791) Review request for shindig, Ryan Baxter and

Re: Review Request: Share OAuth2Token for a user across multiple gadgets

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4291/ --- (Updated 2012-04-10 13:39:26.956532) Review request for shindig, Ryan Baxter and

Re: Review Request: Share OAuth2Token for a user across multiple gadgets

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4291/ --- (Updated 2012-04-09 20:02:38.850154) Review request for shindig, Ryan Baxter and

Re: Review Request: Share OAuth2Token for a user across multiple gadgets

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4291/ --- (Updated 2012-03-11 17:43:19.266570) Review request for shindig, Ryan Baxter and

Review Request: Share OAuth2Token for a user across multiple gadgets

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4291/ --- Review request for shindig, Ryan Baxter and li xu. Summary --- Allows multi

Re: Review Request: gadgets.io.makeRequest supports PUT but the PUT body is not passed along

apache.org/r/4273/ > --- > > (Updated 2012-03-09 19:23:05) > > > Review request for shindig, Dan Dumont and Adam Clarke. > > > Summary > --- > > Currently I can use gadgets.io.makeRequest to do a PUT but the PUT body does > not reach the dest

Re: Review Request: Improvement to OAuth2 message files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4202/#review5653 --- Ship it! LGTM - Adam On 2012-03-06 19:29:51, li xu wrote: > > ---

Re: Review Request: OAuth2 access tokens being removed from OAuth2Store when request returns any 4xx response

To reply, visit: > https://reviews.apache.org/r/3987/ > --- > > (Updated 2012-02-21 21:40:31) > > > Review request for shindig, li xu and Adam Clarke. > > > Summary > --- > > From JIRA: >

Re: Review Request: OAuth2.0 client implementation in Apache Shindig.

sis tool caught all these and I fixed them > On 2011-09-27 17:46:35, Ryan Baxter wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java, > > line 35 > > <https://reviews.apache.org/r/1947/diff/3/?file=45536#file45536line35> >

Re: Review Request: OAuthResponseParms logger does not resolve msgKey into appropriate message

> On 2011-09-20 08:41:49, Paul Lindner wrote: > > thanks! > > Addressed in the second patch for https://reviews.apache.org/r/1947/ - Adam --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1960/