Re: Review Request: Add support for Embedded Experience Gadgets in the CommonContainer test environment

2012-01-08 Thread Matt Marum
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3165/ --- (Updated 2012-01-08 23:08:29.278791) Review request for shindig. Changes -

Re: Review Request: Add support for Embedded Experience Gadgets in the CommonContainer test environment

2011-12-21 Thread Matt Marum
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3165/ --- (Updated 2011-12-21 17:24:41.770174) Review request for shindig. Changes -

Re: Review Request: Add support for Embedded Experience Gadgets in the CommonContainer test environment

2011-12-21 Thread Matt Marum
wise. Unless it does some input sanitizing or something. - Matt --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3165/#review4011 -------

Re: Review Request: Add support for Embedded Experience Gadgets in the CommonContainer test environment

2011-12-21 Thread Matt Marum
/viewController.js <https://reviews.apache.org/r/3165/#comment9145> Will do. - Matt On 2011-12-21 16:05:37, Matt Marum wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews

Re: Review Request: Add support for Embedded Experience Gadgets in the CommonContainer test environment

2011-12-21 Thread Matt Marum
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3165/ --- (Updated 2011-12-21 16:05:37.642013) Review request for shindig. Changes -

Review Request: Add support for Embedded Experience Gadgets in the CommonContainer test environment

2011-12-13 Thread Matt Marum
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3165/ --- Review request for shindig. Summary --- As we start to build (and promote t

Re: Review Request: Need to move oauth2.json to shindig-gadget

2011-11-09 Thread Matt Marum
: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2793/ > --- > > (Updated 2011-11-09 20:58:57) > > > Re

Re: Review Request: Security Token Cleanup in preparation for ContainerConfig controlled token expirations

2011-10-20 Thread Matt Marum
> On 2011-10-19 21:05:16, Matt Marum wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/BlobCrypterSecurityTokenCodec.java, > > line 22 > > <https://reviews.apache.org/r/2396/diff/6/?file=51209#file51209line22&

Re: Review Request: Security Token Cleanup in preparation for ContainerConfig controlled token expirations

2011-10-19 Thread Matt Marum
19 19:46:39, Dan Dumont wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2396/ > --- > > (Updated 2011-10-19 19:46:39) > > > Review request for

Re: Review Request: OAuth 2.0 service provider implementation in Apache Shindig.

2011-09-20 Thread Matt Marum
> On 2011-09-20 09:01:22, Paul Lindner wrote: > > wow, lots of code here. Only skimmed. In terms of style there's lots of > > tabs and trailing white space. > > > > For function please consider looking at what's coming in shiro 1.2: > > > > https://issues.apache.org/jira/browse/SHIRO-119 > >

Re: Review Request: PHP: Proxied requests with OAuth2

2011-08-30 Thread Matt Marum
; This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1680/ > --- > > (Updated 2011-08-30 13:46:53) > > > Review request for shindig, Matt Marum and Eric Woods. > > > S

Re: Review Request: Add back container inline client for pubsub2 to sample CommonContainer

2011-07-13 Thread Matt Marum
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1104/ --- (Updated 2011-07-13 21:24:07.030107) Review request for shindig. Changes -

Review Request: Add back container inline client for pubsub2 to sample CommonContainer

2011-07-13 Thread Matt Marum
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1104/ --- Review request for shindig. Summary --- This was inadvertently removed in a

Re: Review Request: Fix AnonymousSecurityToken when used in CommonContainer

2011-07-13 Thread Matt Marum
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1101/ --- (Updated 2011-07-13 20:47:28.325492) Review request for shindig. Summary -

Review Request: Fix AnonymousSecurityToken when used in CommonContainer

2011-07-13 Thread Matt Marum
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1101/ --- Review request for shindig. Summary --- The current implementation of Anony

Review Request: Update ICU4J from 4.6.1 to 4.8

2011-05-31 Thread Matt Marum
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/811/ --- Review request for shindig. Summary --- ICU 4.8 was released last week, I'd

Re: Review Request: PHP: View level support for Features, Preloads and Locales

2011-04-05 Thread Matt Marum
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/545/#review390 --- Ship it! LGTM - Matt On 2011-04-03 16:12:03, Bastian Hofmann wrote: