Reviewers: johnfargo,
Description:
* binds safejson to gadgets.json.stringify which skips over caja
specific properties and only serializes properties a gadget has access
to.
* use json_sans_eval to parse json rather than eval
Please review this at http://codereview.appspot.com/216045/show
Aff
Reviewers: MikeSamuel,
Description:
* Displays errors in list if there was an error
* Displays warnings in a display:none div otherwise
Please review this at http://codereview.appspot.com/217084/show
Affected files:
M
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaCon
http://codereview.appspot.com/217084/diff/1/2
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java
(right):
http://codereview.appspot.com/217084/diff/1/2#newcode157
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java:157:
Reviewers: chirag,
Description:
* filters out caja properties from native json.stringify
* tames methods created using osapi.registerMethod_
- the latter should be reviewed particularly carefully
Please review this at http://codereview.appspot.com/223109/show
Affected files:
M features/
http://codereview.appspot.com/223109/show
http://codereview.appspot.com/223109/diff/6001/4004
File features/src/main/javascript/features/core.json/json.js (right):
http://codereview.appspot.com/223109/diff/6001/4004#newcode56
features/src/main/javascript/features/core.json/json.js:56: if
(!/___$/.test(k))
On 2010/03/08 22:45:11, johnfar
Reviewers: johnfargo,
Description:
* do not render proxy url gadgets if using caja since proxy url gadgets
bypass the entire rewriting stack including the cajoler
Please review this at http://codereview.appspot.com/380041/show
Affected files:
M
java/gadgets/src/main/java/org/apache/shin
http://codereview.appspot.com/380041/diff/1/2
File
java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java
(right):
http://codereview.appspot.com/380041/diff/1/2#newcode205
java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java:205:
}
I'd really lik
http://codereview.appspot.com/380041/diff/1/4
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/Renderer.java
(right):
http://codereview.appspot.com/380041/diff/1/4#newcode81
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/Renderer.java:81:
if (gadget.getCurrentView(
Reviewers: chirag,
Description:
* whitelists GA and its methods for use in cajoled gadgets
Please review this at http://codereview.appspot.com/847044/show
Affected files:
A features/src/main/javascript/features/analytics/taming.js
Index: features/src/main/javascript/features/analytics/t
Done.
http://codereview.appspot.com/847044/show
http://codereview.appspot.com/846046/diff/1/8
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java
(right):
http://codereview.appspot.com/846046/diff/1/8#newcode180
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java:180:
ping?
http://codereview.appspot.com/846046/show
r4052
compile
On 2010/04/25 20:40:26, jasvir wrote:
Update rev?
http://codereview.appspot.com/846046/show
* moved taming to the directory where analytics functions are hooked up
to gadgets.analytics
* unfortunately there isn't an unobfuscated version of libga available
for review
http://codereview.appspot.com/847044/show
I've been following this along on a separate thread. Thanks for
knocking this out fargo!
LGTM
http://codereview.appspot.com/1272042/show
LGTM
http://codereview.appspot.com/1301042/show
Reviewers: johnfargo,
Description:
* upgrade to latest rev of Caja
* small api change to wire HttpFetcher to Caja's UriFetcher for
retrieving scripts
Please review this at http://codereview.appspot.com/1460041/show
Affected files:
M
java/gadgets/src/main/java/org/apache/shindig/gadgets/
ping. Has this been submitted? If so, can we close out this review.
http://codereview.appspot.com/196053/show
LGTM
http://codereview.appspot.com/1478041/show
heh. I *just* sent essentially the same upgrade your way at
http://codereview.appspot.com/1460041/show
I notice however that the introduction of UriManager at r951107 breaks
cajoled gadgets but this is not caught by any of the existing tests.
http://codereview.appspot.com/1714043/show
LGTM
http://codereview.appspot.com/1714043/diff/1/5
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlParser.java
(right):
http://codereview.appspot.com/1714043/diff/1/5#newcode144
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlParser.java:1
Reviewers: johnfargo,
Description:
Simple clean up
* getting rid of the unused imports
* added .equals() on classes that have a .compare()
* corrected misuse of == instead of .equals() for testing strings
* replace repeated string concat with a stringbuffer
Please review this at http://coderevi
http://codereview.appspot.com/1807042/diff/1/2
File
java/common/src/main/java/org/apache/shindig/protocol/DefaultHandlerRegistry.java
(right):
http://codereview.appspot.com/1807042/diff/1/2#newcode624
java/common/src/main/java/org/apache/shindig/protocol/DefaultHandlerRegistry.java:624:
public b
http://codereview.appspot.com/1807042/diff/5001/6003
File
java/gadgets/src/test/java/org/apache/shindig/gadgets/render/HtmlRendererTest.java
(right):
http://codereview.appspot.com/1807042/diff/5001/6003#newcode65
java/gadgets/src/test/java/org/apache/shindig/gadgets/render/HtmlRendererTest.java:
http://codereview.appspot.com/1807042/diff/14001/15001
File
java/common/src/main/java/org/apache/shindig/protocol/DefaultHandlerRegistry.java
(right):
http://codereview.appspot.com/1807042/diff/14001/15001#newcode629
java/common/src/main/java/org/apache/shindig/protocol/DefaultHandlerRegistry.ja
Please hold off on reviewing this change - it was a first pass and not
quite ready for consumption.
http://codereview.appspot.com/1852041/show
Reviewers: gagan.goku, johnfargo,
Description:
* uses full caja parser rather than a lexer workaround for @imports in
CSS
* Adds missing broken test for @import "url"
Please review this at http://codereview.appspot.com/1852041/show
Affected files:
D
java/gadgets/src/main/java/org/apach
In addition to Chirag's pointer, programmatically, if you're looking for
html attributes that take URIs, the attributes returned by
com.google.caja.lang.html.HtmlSchema that take a uri have .getType() ===
HTML.Attribute.Type.URI.
The default list is derived from the w3c spec and I'd rather avoid
LGTM
http://codereview.appspot.com/1715049/show
:
* TODO(jasvir): This ought to be set to the real URI for accurate
reporting
On 2010/07/16 01:12:34, johnfargo wrote:
want to just do it in this CL? all calling contexts have the source
Uri
available.
I also changed the relative urls like "www.example.org/foo" into actual
absolute ones.
D
ping
http://codereview.appspot.com/1807042/show
http://codereview.appspot.com/1807042/diff/18001/19001
File
java/common/src/main/java/org/apache/shindig/protocol/DefaultHandlerRegistry.java
(right):
http://codereview.appspot.com/1807042/diff/18001/19001#newcode629
java/common/src/main/java/org/apache/shindig/protocol/DefaultHandlerRegistry.ja
Better yet - syncing to head removed all that guff anyways. I'll commit
unless someone objects.
http://codereview.appspot.com/1807042/show
http://codereview.appspot.com/1875044/diff/2001/3005
File features/src/main/javascript/features/shindig.uri/uri.js (right):
http://codereview.appspot.com/1875044/diff/2001/3005#newcode60
features/src/main/javascript/features/shindig.uri/uri.js:60: function
parseFrom(url) {
I don't think parsing
Thanks for the review.
Sorry to hold off on submitting this. I synced to trunk only to realize
it breaks StyleTagProxyEmbeddedUrlsVisitorTest. I'll figure out why and
sync.
http://codereview.appspot.com/1852041/show
StyleTagProxyEmbeddedUrlsVisitorTest.testImportsAndBackgroundUrlsInStyleTag()
is incorrect. According the W3C CSS2 spec
http://www.w3.org/TR/CSS2/syndata.html#at-rules: CSS 2.1 user agents
must ignore any '@import' rule that occurs inside a block or after any
non-ignored statement other than an
Reviewers: gagan.goku,
Description:
Replace the resource attribute list in ProxyVisitor with on that derives
it programmatically from the html schema.
https://issues.apache.org/jira/browse/SHINDIG-1390
Please review this at http://codereview.appspot.com/1900042/show
Affected files:
M
j
Retracting this CL at least for now because of the problems pointed out.
On 2010/07/28 12:28:29, gagan.goku wrote:
On 2010/07/28 12:02:21, Kuntal Loya wrote:
> Hi Jasvir,
>
> This code looks great. I however have a couple of doubts -
>
> * The tags you mentioned in the list c
Actually both these logging statements can probably just be deleted.
http://codereview.appspot.com/1897044/show
LGTM after discussion on the list.
PS. Codereview still gives me:
Error fetching
http://svn.apache.org/repos/asf/shindig/trunk/java/java/common/conf/shindig.properties?rev=965784:
HTTP status 404
http://codereview.appspot.com/1806044/show
Applied. Thank you for the patch.
http://codereview.appspot.com/1897044/show
Reviewers: johnfargo,
Description:
* upgrade to latest
- there were no api visible changes to shindig
Please review this at http://codereview.appspot.com/1893044/show
Affected files:
M pom.xml
Index: pom.xml
===
--- pom.x
Reviewers: zhoresh,
Description:
* Stop throwing runtime errors in the css parser
* rename HTMLElement.{g,s}etStyle method to avoid conflicts
* Fix entity name handling in HTML.
* Be more tolerant when parsing doctypes
Please review this at http://codereview.appspot.com/2024041/
Affected files
Reviewers: chirag, shishir.birmiwal,
Description:
Cajoled output is more verbose than in needs to be. This change
results in minified output unless the debug flag is set. In debug
mode, code is always cajoled and not cached.
Please review this at http://codereview.appspot.com/2012047/
Affecte
http://codereview.appspot.com/2006042/diff/37001/38005
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/VanillaCajaHtmlParser.java
(right):
http://codereview.appspot.com/2006042/diff/37001/38005#newcode70
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/Vanil
http://codereview.appspot.com/2194044/
Reviewers: zhoresh, johnfargo,
Description:
* more lenient html parsing and recovery (thanks Gagan)
* bugfix for prescence of unrepresentably large numbers in scripts
* support for document.getElementsByTagName('*')
Please review this at http://codereview.appspot.com/2737042/
Affected files:
I don't understand the consequences of moving directories but +1 on renaming
gadgets.container to something other than gadgets.container.
On Tue, Feb 9, 2010 at 10:00 PM, Paul Lindner wrote:
> Hi,
>
> One thing that always bothered me for containers was the problems getting
> the page all set up
It ought to be fetched by maven and stashed in your maven
cache ~/.m2/repository/caja/caja/r3950/caja-r3950.jar where 3950 is the
version of caja its pulling. I am not sure how the php version unpacks this
file to get at html-sanitizer.js
On Thu, Feb 11, 2010 at 4:20 PM, Pieter Maes -- Maescool
le for the last year.
Jasvir
On Fri, Feb 12, 2010 at 12:40 PM, Pieter Maes -- Maescool wrote:
>
> yep.. i can fetch it..
> and i found the code you just pasted.. so it's there..
> maybe i need to clean a cache?
> you guys just can test with the osda app
> http://osda.appsp
Welcome on board Chirag!
On Sun, Feb 21, 2010 at 4:46 AM, Nuwan Bandara wrote:
> Congratulations Chirag!
>
> Regards
> /Nuwan
>
> On Sun, Feb 21, 2010 at 4:27 PM, chico charlesworth <
> chico.charleswo...@googlemail.com> wrote:
>
> > welcome chirag :)
> >
> > On 21 February 2010 10:09, Chris Chab
On Mon, Mar 1, 2010 at 6:25 PM, Robert Peterson wrote:
> How can we do the equivalent of sample1.html with caja? Here is what we
> tried:
>
> *test-spec.xml:*
>
>
>
>
>
>
>
>
>
> *renderGadget():*
> var gadget0 = gadgets.container.createGadget({specUrl: "
> http://ourserver.com/tes
-
[ERROR] BUILD FAILURE
[INFO]
[INFO] There are test failures.
Please refer to
/Users/jasvir/src/svn-changes/shindig/java/server/target/surefire-reports
for the individual test results.
[INFO]
---
http://hudson.zones.apache.org/hudson/job/Shindig/ hasn't updated since Feb
4. Is there something I can do to kick start the build again - its very
useful!
Regards
Jasvir
+1
On Wed, Apr 14, 2010 at 1:43 AM, Mat Mannion wrote:
> +1 non-binding
>
> On 14 April 2010 02:50, John Hjelmstad wrote:
> > Hello,
> >
> > Continuing with the new tradition started by Paul Lindner's proposal for
> > Jacky Wang, I am proposing that Zivh Horesh be granted committer access
> to
On Wed, May 12, 2010 at 2:01 PM, Paul Lindner wrote:
> On Wed, May 12, 2010 at 11:16 AM, Kam Kasravi >wrote:
>
> > Will this framework be taking advantage of the features framework where
> > views would be appropriately expanded, etc?
> >
>
> Not sure.. John?
>
>
> > Also, has there been any ef
On Thu, May 13, 2010 at 5:07 PM, Paul Lindner wrote:
> There are some features that are new, experimental and generally not
> production ready nor standardized yet. However I'd like to see them
> checked
> in and maintained over time after such time they can graduate to
> shindig-gadgets and/or
The html parser already parses script tags and so knows the urls of code
being included. At this point, the rewriter could substitute a
known-to-cajole version if it cared to and/or inline the script. Is your
concern that a library like jQuery may have been modified and/or be included
from an unre
A clean checkout, build and still gives me the original stack trace before I
interact with the servlet at all.
jasvir-macbookpro:shindig jasvir$ svn diff
jasvir-macbookpro:shindig jasvir$ svn up
At revision 947901.
jasvir-macbookpro:shindig jasvir$ mvn -Prun
[INFO] Scanning for projects...
[INFO
+1
On Thu, Jun 10, 2010 at 12:28 AM, Jacky Wang (王超) wrote:
> +1 :)
>
> On Thu, Jun 10, 2010 at 5:15 AM, chico charlesworth <
> chico.charleswo...@gmail.com> wrote:
>
> > +1
> >
> > On 9 June 2010 21:49, Ziv Horesh wrote:
> >
> > > true, my bad copy and paste...
> > >
> > > On Wed, Jun 9, 2010 a
earning, 'setOutcome']
]);
});
For methods you would similarly use caja___.whiteListMethods() and for
constructors, caja___.whiteListCtors().
Regards
Jasvir
On Wed, Jul 7, 2010 at 3:46 PM, csev wrote:
> John - Thanks.
>
> Would you prefer I write up a few pages in the wiki and point
On Wed, Jul 7, 2010 at 4:15 PM, John Hjelmstad wrote:
> @Chuck, I agree that slightly cleaning it up for Wiki consumption and
> enhancement would be of benefit. Most important though is just to get the
> content up!
>
> @Jasvir, perhaps Chuck's documentation could serve as a
On Wed, Jul 21, 2010 at 1:59 PM, Gagandeep singh wrote:
> Hi
>
> Is there any rationale behind GadgetException extending Excepiton and thus
> not being able to encapsulate runtime exceptions like NullPointerException
> (checked vs unchecked exception) ?
> Would it make sense for it to do so ? I am
+1
On Wed, Jul 28, 2010 at 1:52 PM, Ziv Horesh wrote:
> +1
>
> On Wed, Jul 28, 2010 at 1:23 PM, John Hjelmstad wrote:
>
> > +1
> >
> > On Wed, Jul 28, 2010 at 1:21 PM, Paul Lindner wrote:
> >
> > > I would like to propose that Michael Hermanto be granted committer
> access
> > > to
> > > Shind
How do I try out something from the staging repo? I've always tested
Shindig by building from source but this seems like the wrong thing to do in
this case.
On Tue, Aug 10, 2010 at 1:02 PM, Bastian Hofmann wrote:
> Hi,
>
> There are some folders (content, extras) missing in the php release
> pa
On Tue, Aug 17, 2010 at 10:32 AM, Pablo Graña wrote:
> I partially understand the same origin policy, but not all of its
> consequences. If all gadgets are rendered from the same ifr 'service', they
> share the same origin. Does that mean that every gadget can walk the dom of
> every other gadget
+1
I agree!
On Thu, Aug 19, 2010 at 10:46 PM, Paul Lindner wrote:
> I would like to propose that Gagandeep Singh be granted committer
> access to Shindig
> along with PMC membership if desired.
>
> WIth over 20 accepted patches, numerous reviews of code and all around
> activity I believe Gagan
On Wed, Aug 18, 2010 at 2:50 AM, Tim Wintle wrote:
> On Tue, 2010-08-17 at 11:35 -0700, ๏̯͡๏ Jasvir Nagra wrote:
> >
> > For code in the caja subset of javascript/html, the cajoled gadget can
> > safely be on the same origin as the container. The security policy
> >
The contents continue to be rendered in an iframe but the contents are
cajoled.
On Tue, Aug 24, 2010 at 5:10 AM, Justin Wyllie
wrote:
>
> My understanding is that if I tick the Use Caja box the content will not be
> rendered in an iframe but in a Caja style virtual iframe. In my sample
> containe
Yes. json-simple.jar is used by Caja.
On Mon, Aug 30, 2010 at 9:30 AM, Paul Lindner wrote:
> If you execute "mvn dependency:tree" you can find out where the deps come
> from. In this case it's caja:
>
> [INFO] +- org.apache.shindig:shindig-gadgets:jar:2.0.0-SNAPSHOT:compile
> [INFO] | +- caja
On Tue, Aug 31, 2010 at 9:06 AM, Ziv Horesh wrote:
> On Thu, Aug 26, 2010 at 7:27 PM, wrote:
>
> >
> > http://codereview.appspot.com/1841045/diff/34001/24002
> > File
> >
> >
> java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/ContentTypeCharsetRemoverRewriterTest.java
> > (right):
>
o do.
> Please commit if you approve of the change.
>
> Thanks
> Gagan
>
>
> 2010/8/31 ๏̯͡๏ Jasvir Nagra
>
>
>>
>> On Tue, Aug 31, 2010 at 9:06 AM, Ziv Horesh wrote:
>>
>>> On Thu, Aug 26, 2010 at 7:27 PM, wrote:
>>>
>>> >
Are you seeing this problem on the php version or Java version of Shindig?
On Mon, Sep 20, 2010 at 7:51 AM, Justin Wyllie
wrote:
>
> I've written a small gadget which uses the tabs feature.
> I initialise the tabs in a function called by
> gadgets.util.registerOnLoadHandler .
> I'm getting error
This is just one of the many problems with inlining two or more gadgets gets
you. The others include but aren't limited to:
* css styles defined in one gadget will apply on other gadgets with
elements, classes, ids or other selectors that match
* javascript functions and globals between gadgets t
ur apis to get and set html elements in the
gadget (including when setting innerHTML) so that they actually get the
right elements and don't accidentally clobber another gadget instance that
has been inlined.
On Tue, Nov 2, 2010 at 10:20 PM, ๏̯͡๏ Jasvir Nagra wrote:
> This is just one of
76 matches
Mail list logo
