Re: Review Request: Allow ContainerConfig stack to load property values from external resources and update BlobCrypterSecurityTokenCodec to use this new feature.

2011-11-15 Thread Jesse Ciancetta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2824/#review3263 --- Ship it! Committed r1202283. - Jesse On 2011-11-14 20:46:51, Jesse

Re: Review Request: Allow ContainerConfig stack to load property values from external resources and update BlobCrypterSecurityTokenCodec to use this new feature.

2011-11-15 Thread Ryan Baxter
> On 2011-11-15 14:20:24, Ryan Baxter wrote: > > LGTM. Jesse just following process here, could you attach the patch to the > > JIRA? Then I will commit it. > > Jesse Ciancetta wrote: > I'll give it a day or two to see if Paul might get a chance to add my > Apache user id to the SVN comm

Re: Review Request: Allow ContainerConfig stack to load property values from external resources and update BlobCrypterSecurityTokenCodec to use this new feature.

2011-11-15 Thread Jesse Ciancetta
> On 2011-11-15 14:20:24, Ryan Baxter wrote: > > LGTM. Jesse just following process here, could you attach the patch to the > > JIRA? Then I will commit it. I'll give it a day or two to see if Paul might get a chance to add my Apache user id to the SVN commit access group. If he does I'll g

Re: Review Request: Allow ContainerConfig stack to load property values from external resources and update BlobCrypterSecurityTokenCodec to use this new feature.

2011-11-15 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2824/#review3256 --- Ship it! LGTM. Jesse just following process here, could you attach t

Re: Review Request: Allow ContainerConfig stack to load property values from external resources and update BlobCrypterSecurityTokenCodec to use this new feature.

2011-11-14 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2824/#review3236 --- Ship it! Good stuff. Thanks Jesse! - Stanton On 2011-11-14 20:46:

Re: Review Request: Allow ContainerConfig stack to load property values from external resources and update BlobCrypterSecurityTokenCodec to use this new feature.

2011-11-14 Thread Jesse Ciancetta
> On 2011-11-14 19:26:13, Henry Saputra wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/auth/BlobCrypterSecurityTokenCodecTest.java, > > line 230 > > > > > > Can we a

Re: Review Request: Allow ContainerConfig stack to load property values from external resources and update BlobCrypterSecurityTokenCodec to use this new feature.

2011-11-14 Thread Jesse Ciancetta
> On 2011-11-14 19:17:59, Dan Dumont wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/config/container.js, line 104 > > > > > > Could you add a comment after this line, like: "// You can specify the > > key to u

Re: Review Request: Allow ContainerConfig stack to load property values from external resources and update BlobCrypterSecurityTokenCodec to use this new feature.

2011-11-14 Thread Jesse Ciancetta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2824/ --- (Updated 2011-11-14 20:46:51.179593) Review request for shindig. Changes -

Re: Review Request: Allow ContainerConfig stack to load property values from external resources and update BlobCrypterSecurityTokenCodec to use this new feature.

2011-11-14 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2824/#review3213 --- http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/ja

Re: Review Request: Allow ContainerConfig stack to load property values from external resources and update BlobCrypterSecurityTokenCodec to use this new feature.

2011-11-14 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2824/#review3210 --- Ship it! Looks great, thanks! http://svn.apache.org/repos/asf/shind

Review Request: Allow ContainerConfig stack to load property values from external resources and update BlobCrypterSecurityTokenCodec to use this new feature.

2011-11-14 Thread Jesse Ciancetta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2824/ --- Review request for shindig. Summary --- Update the ContainerConfig stack to