Re: Review Request: Code Review for JIRA 1801, shared tokens should share accessors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5420/ --- (Updated Sept. 25, 2012, 4:40 p.m.) Review request for shindig, Stanton Sievers

Re: Review Request: Code Review for JIRA 1801, shared tokens should share accessors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5420/#review9896 --- Adam, any update or response to address Brian's comments? - Dan Dumon

Re: Review Request: Code Review for JIRA 1801, shared tokens should share accessors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5420/#review8482 --- The CodeAuthorizationResponseHandler picks up the gadgetUri from the a

Re: Review Request: Code Review for JIRA 1801, shared tokens should share accessors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5420/ --- (Updated June 22, 2012, 11:18 a.m.) Review request for shindig, Stanton Sievers

Re: Review Request: Code Review for JIRA 1801, shared tokens should share accessors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5420/ --- (Updated June 21, 2012, 3:56 p.m.) Review request for shindig and Brian Lillie.

Re: Review Request: Code Review for JIRA 1801, shared tokens should share accessors

> On June 19, 2012, 4:31 p.m., Ryan Baxter wrote: > > Adam I noticed we are lacking some unit tests for this method (and most of > > the class in general). This might be a good opportunity to add some unit > > tests. I agree with you that we need some unit tests here, but (as you're probably

Re: Review Request: Code Review for JIRA 1801, shared tokens should share accessors

> On June 19, 2012, 1:39 p.m., Dan Dumont wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java, > > line 182 > > > > > > Could you

Re: Review Request: Code Review for JIRA 1801, shared tokens should share accessors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5420/ --- (Updated June 21, 2012, 3:53 p.m.) Review request for shindig and Brian Lillie.

Re: Review Request: Code Review for JIRA 1801, shared tokens should share accessors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5420/#review8395 --- Adam I noticed we are lacking some unit tests for this method (and mos

Review Request: Code Review for JIRA 1801, shared tokens should share accessors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5420/ --- Review request for shindig, Stanton Sievers and Brian Lillie. Description --

Re: Review Request: Code Review for JIRA 1801, shared tokens should share accessors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5420/#review8387 --- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/j