Re: Review Request: Declared actions get fired in the first instance of the gadget, ignoring any specified view target in the declaration

2011-09-02 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1682/#review1733 --- Dan when I apply your patch the actions in the reference

Re: Review Request: Declared actions get fired in the first instance of the gadget, ignoring any specified view target in the declaration

2011-09-02 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1682/ --- (Updated 2011-09-02 13:19:47.959759) Review request for shindig, Ryan Baxter,

Re: Review Request: Declared actions get fired in the first instance of the gadget, ignoring any specified view target in the declaration

2011-09-02 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1682/#review1734 --- Ship it! Committed revision 1164527. Please close the review and

Re: Review Request: Declared actions get fired in the first instance of the gadget, ignoring any specified view target in the declaration

2011-09-01 Thread Dan Dumont
On 2011-08-31 21:09:46, Ryan Baxter wrote: http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js, line 427 https://reviews.apache.org/r/1682/diff/3/?file=36312#file36312line427 check that gadgetSites is not undefined

Re: Review Request: Declared actions get fired in the first instance of the gadget, ignoring any specified view target in the declaration

2011-09-01 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1682/ --- (Updated 2011-09-01 12:47:32.468086) Review request for shindig, Ryan Baxter,

Re: Review Request: Declared actions get fired in the first instance of the gadget, ignoring any specified view target in the declaration

2011-08-31 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1682/ --- (Updated 2011-08-31 19:09:24.515118) Review request for shindig, Ryan Baxter,

Re: Review Request: Declared actions get fired in the first instance of the gadget, ignoring any specified view target in the declaration

2011-08-31 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1682/#review1704 ---