[
https://issues.apache.org/jira/browse/SLIDER-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338259#comment-15338259
]
ASF subversion and git services commented on SLIDER-1079:
-
Commit
[
https://issues.apache.org/jira/browse/SLIDER-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330884#comment-15330884
]
Gour Saha commented on SLIDER-1079:
---
It is actually a valid usage. App owners in the early phase of app
[
https://issues.apache.org/jira/browse/SLIDER-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330618#comment-15330618
]
shanyu zhao commented on SLIDER-1079:
-
Hi [~gsaha], the cache is keyed on the app def, which should
[
https://issues.apache.org/jira/browse/SLIDER-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329035#comment-15329035
]
Gour Saha commented on SLIDER-1079:
---
[~shanyu] this patch is causing a functional issue when
[
https://issues.apache.org/jira/browse/SLIDER-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260852#comment-15260852
]
Gour Saha commented on SLIDER-1079:
---
[~ste...@apache.org], [~shanyu] can we close this bug given the
[
https://issues.apache.org/jira/browse/SLIDER-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163341#comment-15163341
]
Steve Loughran commented on SLIDER-1079:
Just catching up with my own review, missed it was
[
https://issues.apache.org/jira/browse/SLIDER-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15152477#comment-15152477
]
ASF subversion and git services commented on SLIDER-1079:
-
Commit
[
https://issues.apache.org/jira/browse/SLIDER-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15152461#comment-15152461
]
Jonathan Maron commented on SLIDER-1079:
[~shanyu] - Looks good. I also ran the full unit test
[
https://issues.apache.org/jira/browse/SLIDER-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134286#comment-15134286
]
Jonathan Maron commented on SLIDER-1079:
Looks pretty good. Can you:
1) Create a method that
[
https://issues.apache.org/jira/browse/SLIDER-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134761#comment-15134761
]
shanyu zhao commented on SLIDER-1079:
-
Thanks [~jmaron] for your feedback. I addressed 1) and 2) in
10 matches
Mail list logo