when this three classes are not intended to be derived from we should
definitely declare them final to be on the safe side.
stefan
>-Original Message-
>From: Konrad Windszus [mailto:konra...@gmx.de]
>Sent: Monday, March 6, 2017 8:09 PM
>To: dev@sling.apache.org
>Subject: Re: Time for a
[
https://issues.apache.org/jira/browse/SLING-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897939#comment-15897939
]
Felix Meschberger commented on SLING-6609:
--
Thanks, [~kwin]. Looks good except, I
Actually thinking about this further:
DefaultValidationFailure implements already a ProviderType (namely
ValidationFailure). That should make that class inherit the ProviderType
annotation as well. I Have not verified that with bnd (baselining as well as
import-packages) though.
> Am 06.03.201
Hi Stefan, thanks for your comments.
IIRC the provider and consumer type annotations only have an influence if you
derive from/implement those.
I would for now be in favor of making all those final (i.e. prevent to derive
from those classes). If there really is a need to implement your own
Valid
i did not had the time to really think into the API itself, but from a formal
perspective I think for those 3 classes it would be good to explicitly add the
corresponding @ProviderType or @ConsumerType annotation:
org.apache.sling.validation.SlingValidationException -> @ProviderType, and
maybe
+1
+1
[
https://issues.apache.org/jira/browse/SLING-6614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897623#comment-15897623
]
Guillaume Lucazeau commented on SLING-6614:
---
PR: https://github.com/apache/sling
[
https://issues.apache.org/jira/browse/SLING-6614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Lucazeau updated SLING-6614:
--
Comment: was deleted
(was: PR: https://github.com/apache/sling/pull/201)
> JcrContentLo
[
https://issues.apache.org/jira/browse/SLING-6614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897621#comment-15897621
]
ASF GitHub Bot commented on SLING-6614:
---
GitHub user glucazeau opened a pull request
GitHub user glucazeau opened a pull request:
https://github.com/apache/sling/pull/201
SLING-6614: check that property/parent node is not protected before import
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/glucazeau/sling dev
[
https://issues.apache.org/jira/browse/SLING-6615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897588#comment-15897588
]
Andrea Biardi edited comment on SLING-6615 at 3/6/17 4:26 PM:
--
[
https://issues.apache.org/jira/browse/SLING-6615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrea Biardi updated SLING-6615:
-
Attachment: log2
log containing thread dump obtained with kill -3
> sling listener crashes - cann
[
https://issues.apache.org/jira/browse/SLING-6615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897540#comment-15897540
]
Robert Munteanu commented on SLING-6615:
Can you take a thread dump of the process
Andrea Biardi created SLING-6615:
Summary: sling listener crashes - cannot reliably start sling
Key: SLING-6615
URL: https://issues.apache.org/jira/browse/SLING-6615
Project: Sling
Issue Type
I think that's not necessary. It's all in the svn history and the
revision numbers are referenced from the ticket.
Regards
Julian
On Mon, Mar 6, 2017 at 12:55 PM, Oliver Lietz wrote:
> On Monday 06 March 2017 12:27:28 Julian Sedding wrote:
>> Thanks for reverting these changes, Olli. I meant to
[
https://issues.apache.org/jira/browse/SLING-6610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897464#comment-15897464
]
Konrad Windszus edited comment on SLING-6610 at 3/6/17 3:18 PM:
[
https://issues.apache.org/jira/browse/SLING-6610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897464#comment-15897464
]
Konrad Windszus commented on SLING-6610:
I am open for other proposals, but basica
[
https://issues.apache.org/jira/browse/SLING-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897456#comment-15897456
]
Konrad Windszus commented on SLING-6609:
Extended the javadoc with [r1785659|http:
[
https://issues.apache.org/jira/browse/SLING-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897451#comment-15897451
]
Julian Sedding commented on SLING-6609:
---
bq. Maybe you could add the annotation plus
Guillaume Lucazeau created SLING-6614:
-
Summary: JcrContentLoader should ignore protected nodes and
properties
Key: SLING-6614
URL: https://issues.apache.org/jira/browse/SLING-6614
Project: Sling
[
https://issues.apache.org/jira/browse/SLING-6613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-6613:
---
Attachment: 0001-SLING-6613-ResourceResolverFactory-not-registered-wh.patch
[~cziegeler] - WDY
Robert Munteanu created SLING-6613:
--
Summary: ResourceResolverFactory not registered when legacy
configuration references JcrResourceProviderFactory
Key: SLING-6613
URL: https://issues.apache.org/jira/browse/SLIN
+1 checked signatures and build
On Mon, Mar 6, 2017 at 4:01 AM, Robert Munteanu wrote:
> On Fri, 2017-03-03 at 10:02 +0100, Oliver Lietz wrote:
> > Please vote to approve this release:
>
> +1
>
> Robert
[
https://issues.apache.org/jira/browse/SLING-6612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vlad Bailescu updated SLING-6612:
-
Attachment: SLING-6612-test.patch
> HTL/Sightly sometimes fails to recompile an updated Java POJO
Vlad Bailescu created SLING-6612:
Summary: HTL/Sightly sometimes fails to recompile an updated Java
POJO located in the repository
Key: SLING-6612
URL: https://issues.apache.org/jira/browse/SLING-6612
On Monday 06 March 2017 12:27:28 Julian Sedding wrote:
> Thanks for reverting these changes, Olli. I meant to do the same for
> some time, but never got around to it.
>
> I think this idea need more thought and work before it can become truly
> useful.
Should we add a reverse patch containing you
+1
On Mon, Mar 6, 2017 at 3:48 AM, Robert Munteanu wrote:
> On Sun, 2017-03-05 at 08:40 +0100, Oliver Lietz wrote:
> > Please vote to approve this release:
>
> +1
>
> Robert
[
https://issues.apache.org/jira/browse/SLING-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897208#comment-15897208
]
Felix Meschberger commented on SLING-6609:
--
Fully agreed with the safety net for
[
https://issues.apache.org/jira/browse/SLING-6610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897196#comment-15897196
]
Oliver Lietz commented on SLING-6610:
-
I have to look closer, but {{ValidatorAndSeveri
[
https://issues.apache.org/jira/browse/SLING-6502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897153#comment-15897153
]
Oliver Lietz commented on SLING-6502:
-
[~cziegeler], [~fmeschbe]: as Felix raised conc
Thanks for reverting these changes, Olli. I meant to do the same for
some time, but never got around to it.
I think this idea need more thought and work before it can become truly useful.
Regards
Julian
On Sat, Mar 4, 2017 at 2:58 PM, wrote:
> Author: olli
> Date: Sat Mar 4 13:58:36 2017
> N
[
https://issues.apache.org/jira/browse/SLING-6473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Sedding resolved SLING-6473.
---
Resolution: Later
Changes reverted in [r1785487|https://svn.apache.org/r1785487] by [~olli].
I
+1
regards,
Karl
On Mon, Mar 6, 2017 at 9:49 AM, Robert Munteanu wrote:
> On Fri, 2017-03-03 at 11:42 +0100, Oliver Lietz wrote:
>> Please vote to approve this release:
>
> +1
>
> Robert
--
Karl Pauls
karlpa...@gmail.com
[
https://issues.apache.org/jira/browse/SLING-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897088#comment-15897088
]
Julian Sedding commented on SLING-6609:
---
I agree with [~kwin] on this one. Especiall
+1
regards,
Karl
On Fri, Mar 3, 2017 at 5:20 PM, Daniel Klco wrote:
> +1
>
> On Fri, Mar 3, 2017 at 4:29 AM, Timothee Maret wrote:
>
>> +1 (non binding)
>>
>> Regards,
>>
>> Timothee
>>
>> 2017-03-03 9:15 GMT+01:00 Oliver Lietz :
>>
>> > Hi,
>> >
>> > we solved 2 issues in this release:
>> > h
[
https://issues.apache.org/jira/browse/SLING-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897075#comment-15897075
]
Konrad Windszus commented on SLING-6609:
Even if it was historically supported, I
hi,
sorry for the noise – Parent 30 was not available in Maven Central (it is
now).
O.
[
https://issues.apache.org/jira/browse/SLING-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897056#comment-15897056
]
Felix Meschberger commented on SLING-6609:
--
Ah, right, but historically, I am not
[
https://issues.apache.org/jira/browse/SLING-6610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-6610.
Resolution: Fixed
Assignee: Konrad Windszus
> DefaultValidationFailure and DefaultVali
[
https://issues.apache.org/jira/browse/SLING-6610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897009#comment-15897009
]
Konrad Windszus commented on SLING-6610:
Fixed in [r1785616|http://svn.apache.org/
[
https://issues.apache.org/jira/browse/SLING-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz closed SLING-6246.
---
> Update to latest maven scr plugin and scr annotations
>
[
https://issues.apache.org/jira/browse/SLING-6560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz closed SLING-6560.
---
> Exclude Lucene's index-details.txt from Rat checks
> --
[
https://issues.apache.org/jira/browse/SLING-6532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz closed SLING-6532.
---
> No longer add the Felix SCR annotations to the list of dependencies
> --
[
https://issues.apache.org/jira/browse/SLING-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz closed SLING-6572.
---
> Generate SCR metadata required for mock-based unit tests
> -
[
https://issues.apache.org/jira/browse/SLING-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz closed SLING-6245.
---
> Add odd-even release policy to release plugin
> -
>
>
[
https://issues.apache.org/jira/browse/SLING-6533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz closed SLING-6533.
---
> No longer add bndlib to the list of commons dependencies
> -
[
https://issues.apache.org/jira/browse/SLING-6611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret reassigned SLING-6611:
-
Assignee: Timothee Maret
> Improve FileVaultContentSerializer performance
> -
[
https://issues.apache.org/jira/browse/SLING-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896983#comment-15896983
]
Konrad Windszus commented on SLING-6609:
The default value is also supposed to be
[
https://issues.apache.org/jira/browse/SLING-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896981#comment-15896981
]
Felix Meschberger commented on SLING-6609:
--
Actually, I am not entirely sure, whe
On Thursday 02 March 2017 13:40:41 Oliver Lietz wrote:
> Hi,
>
> we solved 6 issues in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12338540
+1
O.
Tommaso Teofili created SLING-6611:
--
Summary: Improve FileVaultContentSerializer performance
Key: SLING-6611
URL: https://issues.apache.org/jira/browse/SLING-6611
Project: Sling
Issue Type:
Hi,
the vote has passed with the following result:
+1 (binding): Carsten Ziegeler, Robert Munteanu, Radu Cotescu, Stefan Seifert,
Daniel Klco, Oliver Lietz
I will copy this release to the Sling dist directory and promote the artifacts
to the central Maven repository.
Thanks for voting!
O.
+1 (non binding)
2017-03-03 9:49 GMT+01:00 Oliver Lietz :
> Hi,
>
> we solved 2 issues in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12338806
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-1653/
>
> You can use this UNIX
On Sun, 2017-03-05 at 08:29 +0100, Oliver Lietz wrote:
> Please vote to approve this release:
+1
BTW, https://issues.apache.org/jira/browse/SLING-6287 should be moved
to the next release.
Robert
signature.asc
Description: This is a digitally signed message part
On Fri, 2017-03-03 at 15:23 +0100, Oliver Lietz wrote:
> Please vote to approve this release:
+1
Robert
signature.asc
Description: This is a digitally signed message part
On Fri, 2017-03-03 at 10:18 +0100, Oliver Lietz wrote:
> Please vote to approve this release:
+1
Robert
signature.asc
Description: This is a digitally signed message part
On Fri, 2017-03-03 at 10:02 +0100, Oliver Lietz wrote:
> Please vote to approve this release:
+1
Robert
signature.asc
Description: This is a digitally signed message part
+1 (not binding)
2017-03-03 15:23 GMT+01:00 Oliver Lietz :
> Hi,
>
> we solved 7 issues in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12335062
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-1657/
>
> You can use this UNIX
On Fri, 2017-03-03 at 09:49 +0100, Oliver Lietz wrote:
> Please vote to approve this release:
+1
Robert
signature.asc
Description: This is a digitally signed message part
[
https://issues.apache.org/jira/browse/SLING-6430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz closed SLING-6430.
---
> Documentation IDE Tooling
> -
>
> Key: SLING-6430
>
On Fri, 2017-03-03 at 11:42 +0100, Oliver Lietz wrote:
> Please vote to approve this release:
+1
Robert
signature.asc
Description: This is a digitally signed message part
On Sun, 2017-03-05 at 08:40 +0100, Oliver Lietz wrote:
> Please vote to approve this release:
+1
Robert
signature.asc
Description: This is a digitally signed message part
Thanks Oliver!
I have done the remaining steps.
Regards,
Timothee
2017-03-06 9:36 GMT+01:00 Oliver Lietz :
> On Monday 06 March 2017 09:29:28 Timothee Maret wrote:
> > Hi,
> >
> > The vote has passed with the following result :
> >
> > +1 (binding): Oliver Lietz, Robert Munteanu, Daniel Klco
>
[
https://issues.apache.org/jira/browse/SLING-5888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz closed SLING-5888.
---
> Health Check for detecting not-installed configurations/bundles from the OSGi
> installer
> ---
Hi,
the vote has passed with the following result:
+1 (binding): Konrad Windszus, Carsten Ziegeler, Robert Munteanu, Daniel Klco,
Oliver Lietz
+1 (non-binding): Timothee Maret
I will copy this release to the Sling dist directory and promote the artifacts
to the central Maven repository.
Thank
[
https://issues.apache.org/jira/browse/SLING-5916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret updated SLING-5916:
--
Fix Version/s: (was: Content Distribution Core 0.2.6)
Content Distribution
[
https://issues.apache.org/jira/browse/SLING-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret updated SLING-4797:
--
Fix Version/s: (was: Content Distribution Core 0.2.6)
Content Distribution
[
https://issues.apache.org/jira/browse/SLING-5760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret updated SLING-5760:
--
Fix Version/s: (was: Content Distribution Core 0.2.6)
Content Distribution
[
https://issues.apache.org/jira/browse/SLING-6211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret updated SLING-6211:
--
Fix Version/s: (was: Content Distribution Core 0.2.6)
Content Distribution
On Thursday 02 March 2017 08:55:22 Oliver Lietz wrote:
> Hi,
>
> we solved 1 issue in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12338122
+1
O.
[
https://issues.apache.org/jira/browse/SLING-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret updated SLING-5952:
--
Fix Version/s: (was: Content Distribution Core 0.2.6)
Content Distribution
On Monday 06 March 2017 09:29:28 Timothee Maret wrote:
> Hi,
>
> The vote has passed with the following result :
>
> +1 (binding): Oliver Lietz, Robert Munteanu, Daniel Klco
> +1 (non binding): Tommaso Teofili
>
> Could a member of the @PMC please push the release to
> https://dist.apache.org/re
Hi,
The vote has passed with the following result :
+1 (binding): Oliver Lietz, Robert Munteanu, Daniel Klco
+1 (non binding): Tommaso Teofili
Could a member of the @PMC please push the release to
https://dist.apache.org/repos/dist/release/sling ?
I'll take care of the remaining steps once this
74 matches
Mail list logo